Re: [XEN PATCH 1/2] xen/console: drop return value from consoled_guest_rx/tx

[Nicola Vetrini <nicola.vetrini@bugseng.com>]

On 2024-02-26 09:00, Jan Beulich wrote:
> On 23.02.2024 23:56, Stefano Stabellini wrote:
>> On Fri, 23 Feb 2024, Nicola Vetrini wrote:
>>> These functions never saw a usage of their return value since
>>> they were introduced, so it can be dropped since their usages
>>> violate MISRA C Rule 17.7:
>>> "The value returned by a function having non-void return type shall 
>>> be used".
>>> 
>>> No functional change.
>>> 
>>> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
>> 
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> The cleanup is certainly okay, but would one of you mind clarifying in 
> how
> far this code is relevant for certification? I don't expect there are 
> plans
> to run shim Xen in any projected production uses for which 
> certification is
> relevant? (The subject prefix is also unnecessarily wide here, when 
> it's
> only daemon code which is affected, not console code in general.)
> 

I agree on the subject prefix being too wide. The configuration that 
uses consoled_guest_tx is #ifdef-ed for x86, so even in configurations 
that may never reach this condition this is relevant, unless its #ifdef 
is restricted to cases where the call may actually be reachable.
consoled_guest_rx was adjusted for uniformity, even though it's 
technically not included in the configuration under analysis at the 
moment.

-- 
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)