All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stefan Riedmüller" <S.Riedmueller@phytec.de>
To: "festevam@gmail.com" <festevam@gmail.com>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH 1/3] ARM: dts: imx6: pfla02: Fix USB vbus enable pinmuxing
Date: Mon, 29 Mar 2021 12:39:37 +0000	[thread overview]
Message-ID: <b449e9c40d225b3dbec9c79435b856f89ccdde29.camel@phytec.de> (raw)
In-Reply-To: <CAOMZO5AxkToaa3wFbx2KP6AyAnWVYKVsKOs-mgNMZLOzo3miuA@mail.gmail.com>

Hi Fabio,

On Mon, 2021-03-29 at 08:32 -0300, Fabio Estevam wrote:
> Hi Stefan,
> 
> On Mon, Mar 29, 2021 at 8:28 AM Stefan Riedmueller
> <s.riedmueller@phytec.de> wrote:
> 
> > -               pinctrl_usbh1: usbh1grp {
> > +               pinctrl_usbh1_vbus: usbh1vbusgrp {
> >                         fsl,pins = <
> > -                               MX6QDL_PAD_GPIO_0__USB_H1_PWR           0x
> > 80000000
> > +                               MX6QDL_PAD_GPIO_0__GPIO1_IO00           0x
> > 80000000
> 
> While you are on it, could you please use avoid the usage of
> 0x80000000 and explicitly pass the default value instead?

Thanks for your review. Sure, I'll fix that in a v2.

Stefan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Stefan Riedmüller" <S.Riedmueller@phytec.de>
To: "festevam@gmail.com" <festevam@gmail.com>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: Re: [PATCH 1/3] ARM: dts: imx6: pfla02: Fix USB vbus enable pinmuxing
Date: Mon, 29 Mar 2021 12:39:37 +0000	[thread overview]
Message-ID: <b449e9c40d225b3dbec9c79435b856f89ccdde29.camel@phytec.de> (raw)
In-Reply-To: <CAOMZO5AxkToaa3wFbx2KP6AyAnWVYKVsKOs-mgNMZLOzo3miuA@mail.gmail.com>

Hi Fabio,

On Mon, 2021-03-29 at 08:32 -0300, Fabio Estevam wrote:
> Hi Stefan,
> 
> On Mon, Mar 29, 2021 at 8:28 AM Stefan Riedmueller
> <s.riedmueller@phytec.de> wrote:
> 
> > -               pinctrl_usbh1: usbh1grp {
> > +               pinctrl_usbh1_vbus: usbh1vbusgrp {
> >                         fsl,pins = <
> > -                               MX6QDL_PAD_GPIO_0__USB_H1_PWR           0x
> > 80000000
> > +                               MX6QDL_PAD_GPIO_0__GPIO1_IO00           0x
> > 80000000
> 
> While you are on it, could you please use avoid the usage of
> 0x80000000 and explicitly pass the default value instead?

Thanks for your review. Sure, I'll fix that in a v2.

Stefan

  reply	other threads:[~2021-03-29 19:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 11:28 [PATCH 1/3] ARM: dts: imx6: pfla02: Fix USB vbus enable pinmuxing Stefan Riedmueller
2021-03-29 11:28 ` Stefan Riedmueller
2021-03-29 11:28 ` [PATCH 2/3] ARM: dts: imx6: pbab01: Set USB OTG port to peripheral Stefan Riedmueller
2021-03-29 11:28   ` Stefan Riedmueller
2021-03-29 11:33   ` Fabio Estevam
2021-03-29 11:33     ` Fabio Estevam
2021-03-29 11:28 ` [PATCH 3/3] ARM: dts: imx6: pbab01: Set vmmc supply for both SD interfaces Stefan Riedmueller
2021-03-29 11:28   ` Stefan Riedmueller
2021-03-29 11:34   ` Fabio Estevam
2021-03-29 11:34     ` Fabio Estevam
2021-03-29 12:41     ` Stefan Riedmüller
2021-03-29 12:41       ` Stefan Riedmüller
2021-03-29 11:32 ` [PATCH 1/3] ARM: dts: imx6: pfla02: Fix USB vbus enable pinmuxing Fabio Estevam
2021-03-29 11:32   ` Fabio Estevam
2021-03-29 12:39   ` Stefan Riedmüller [this message]
2021-03-29 12:39     ` Stefan Riedmüller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b449e9c40d225b3dbec9c79435b856f89ccdde29.camel@phytec.de \
    --to=s.riedmueller@phytec.de \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.