* [PATCH v6 0/7] arm64: dts: rockchip: Refine dts for Radxa ROCK 5C
@ 2024-12-23 1:39 ` FUKAUMI Naoki
0 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
This patch series includes fixes for improvements, trivial changes,
etc for Radxa ROCK 5C.
FUKAUMI Naoki (7):
arm64: dts: rockchip: Change the function of the blue LED for Radxa
ROCK 5C
arm64: dts: rockchip: Use a longer PWM period for the fan on Radxa
ROCK 5C
arm64: dts: rockchip: Remove the RTC and related nodes for Radxa ROCK
5C
arm64: dts: rockchip: Add cd-gpios for sdmmc for Radxa ROCK 5C
arm64: dts: rockchip: Fix the properties of the PMIC regulators for
Radxa ROCK 5C
arm64: dts: rockchip: Trivial changes for Radxa ROCK 5C
arm64: dts: rockchip: Sort nodes for Radxa ROCK 5C
.../boot/dts/rockchip/rk3588s-rock-5c.dts | 239 ++++++++----------
1 file changed, 107 insertions(+), 132 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCH v6 1/7] arm64: dts: rockchip: Change the function of the blue LED for Radxa ROCK 5C
2024-12-23 1:39 ` FUKAUMI Naoki
@ 2024-12-23 1:39 ` FUKAUMI Naoki
-1 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
Radxa ROCK 5C is an updated version of Radxa ROCK 5A so everything
should be as compatible as possible.
Change the function of the blue LED from HEARTBEAT to STATUS.
Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6
- Reword commit message
Changes in v5
- Reword commit message
Changes in v4
- new
---
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 9b14d5383cdc..23e9b447b6f0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -62,7 +62,7 @@ led-0 {
led-1 {
color = <LED_COLOR_ID_BLUE>;
default-state = "on";
- function = LED_FUNCTION_HEARTBEAT;
+ function = LED_FUNCTION_STATUS;
gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
};
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH v6 1/7] arm64: dts: rockchip: Change the function of the blue LED for Radxa ROCK 5C
@ 2024-12-23 1:39 ` FUKAUMI Naoki
0 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
Radxa ROCK 5C is an updated version of Radxa ROCK 5A so everything
should be as compatible as possible.
Change the function of the blue LED from HEARTBEAT to STATUS.
Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6
- Reword commit message
Changes in v5
- Reword commit message
Changes in v4
- new
---
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 9b14d5383cdc..23e9b447b6f0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -62,7 +62,7 @@ led-0 {
led-1 {
color = <LED_COLOR_ID_BLUE>;
default-state = "on";
- function = LED_FUNCTION_HEARTBEAT;
+ function = LED_FUNCTION_STATUS;
gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>;
linux,default-trigger = "heartbeat";
};
--
2.43.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v6 2/7] arm64: dts: rockchip: Use a longer PWM period for the fan on Radxa ROCK 5C
2024-12-23 1:39 ` FUKAUMI Naoki
@ 2024-12-23 1:39 ` FUKAUMI Naoki
-1 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
The fan on Radxa ROCK 5C is driven via an AO3416 MOSFET, which has a
total switch-on time of 0,6us and a total switch-off time of 6us [1],
meaning that the current PWM period of just 10us is too short for
fine-grained fan speed control. Increase the PWM period to 60us, so
that the switch-on and switch-off time of the MOSFET fall within a
more reasonable ~10% of the full period, thus making lower PWM duty
cycles meaningful.
[1] https://www.aosmd.com/pdfs/datasheet/AO3416.pdf
Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6:
- none
Changes in v5:
- Reword commit message (Alexey Charkov)
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- Reword commit message
---
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 23e9b447b6f0..910ec67bd4eb 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -73,7 +73,7 @@ fan {
#cooling-cells = <2>;
cooling-levels = <0 64 128 192 255>;
fan-supply = <&vcc_5v0>;
- pwms = <&pwm3 0 10000 0>;
+ pwms = <&pwm3 0 60000 0>;
};
pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH v6 2/7] arm64: dts: rockchip: Use a longer PWM period for the fan on Radxa ROCK 5C
@ 2024-12-23 1:39 ` FUKAUMI Naoki
0 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
The fan on Radxa ROCK 5C is driven via an AO3416 MOSFET, which has a
total switch-on time of 0,6us and a total switch-off time of 6us [1],
meaning that the current PWM period of just 10us is too short for
fine-grained fan speed control. Increase the PWM period to 60us, so
that the switch-on and switch-off time of the MOSFET fall within a
more reasonable ~10% of the full period, thus making lower PWM duty
cycles meaningful.
[1] https://www.aosmd.com/pdfs/datasheet/AO3416.pdf
Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6:
- none
Changes in v5:
- Reword commit message (Alexey Charkov)
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- Reword commit message
---
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 23e9b447b6f0..910ec67bd4eb 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -73,7 +73,7 @@ fan {
#cooling-cells = <2>;
cooling-levels = <0 64 128 192 255>;
fan-supply = <&vcc_5v0>;
- pwms = <&pwm3 0 10000 0>;
+ pwms = <&pwm3 0 60000 0>;
};
pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
--
2.43.0
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCH v6 2/7] arm64: dts: rockchip: Use a longer PWM period for the fan on Radxa ROCK 5C
2024-12-23 1:39 ` FUKAUMI Naoki
@ 2024-12-23 10:33 ` Dragan Simic
-1 siblings, 0 replies; 20+ messages in thread
From: Dragan Simic @ 2024-12-23 10:33 UTC (permalink / raw)
To: FUKAUMI Naoki; +Cc: heiko, robh, krzk+dt, conor+dt, devicetree, linux-rockchip
Hello Fukaumi,
On 2024-12-23 02:39, FUKAUMI Naoki wrote:
> The fan on Radxa ROCK 5C is driven via an AO3416 MOSFET, which has a
> total switch-on time of 0,6us and a total switch-off time of 6us [1],
> meaning that the current PWM period of just 10us is too short for
> fine-grained fan speed control. Increase the PWM period to 60us, so
> that the switch-on and switch-off time of the MOSFET fall within a
> more reasonable ~10% of the full period, thus making lower PWM duty
> cycles meaningful.
>
> [1] https://www.aosmd.com/pdfs/datasheet/AO3416.pdf
>
> Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
As a note, it seems that you forgot to include my Reviewed-by tag
for this patch in the v6. [*]
[*]
https://lore.kernel.org/linux-rockchip/616cd7b81d5469de7bd5a84d2d23387f@manjaro.org/
> ---
> Changes in v6:
> - none
> Changes in v5:
> - Reword commit message (Alexey Charkov)
> Changes in v4:
> - none
> Changes in v3:
> - none
> Changes in v2:
> - Reword commit message
> ---
> arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
> b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
> index 23e9b447b6f0..910ec67bd4eb 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
> @@ -73,7 +73,7 @@ fan {
> #cooling-cells = <2>;
> cooling-levels = <0 64 128 192 255>;
> fan-supply = <&vcc_5v0>;
> - pwms = <&pwm3 0 10000 0>;
> + pwms = <&pwm3 0 60000 0>;
> };
>
> pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH v6 2/7] arm64: dts: rockchip: Use a longer PWM period for the fan on Radxa ROCK 5C
@ 2024-12-23 10:33 ` Dragan Simic
0 siblings, 0 replies; 20+ messages in thread
From: Dragan Simic @ 2024-12-23 10:33 UTC (permalink / raw)
To: FUKAUMI Naoki; +Cc: heiko, robh, krzk+dt, conor+dt, devicetree, linux-rockchip
Hello Fukaumi,
On 2024-12-23 02:39, FUKAUMI Naoki wrote:
> The fan on Radxa ROCK 5C is driven via an AO3416 MOSFET, which has a
> total switch-on time of 0,6us and a total switch-off time of 6us [1],
> meaning that the current PWM period of just 10us is too short for
> fine-grained fan speed control. Increase the PWM period to 60us, so
> that the switch-on and switch-off time of the MOSFET fall within a
> more reasonable ~10% of the full period, thus making lower PWM duty
> cycles meaningful.
>
> [1] https://www.aosmd.com/pdfs/datasheet/AO3416.pdf
>
> Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
As a note, it seems that you forgot to include my Reviewed-by tag
for this patch in the v6. [*]
[*]
https://lore.kernel.org/linux-rockchip/616cd7b81d5469de7bd5a84d2d23387f@manjaro.org/
> ---
> Changes in v6:
> - none
> Changes in v5:
> - Reword commit message (Alexey Charkov)
> Changes in v4:
> - none
> Changes in v3:
> - none
> Changes in v2:
> - Reword commit message
> ---
> arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
> b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
> index 23e9b447b6f0..910ec67bd4eb 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
> @@ -73,7 +73,7 @@ fan {
> #cooling-cells = <2>;
> cooling-levels = <0 64 128 192 255>;
> fan-supply = <&vcc_5v0>;
> - pwms = <&pwm3 0 10000 0>;
> + pwms = <&pwm3 0 60000 0>;
> };
>
> pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v6 3/7] arm64: dts: rockchip: Remove the RTC and related nodes for Radxa ROCK 5C
2024-12-23 1:39 ` FUKAUMI Naoki
@ 2024-12-23 1:39 ` FUKAUMI Naoki
-1 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
There is no RTC on the actual board, so remove it.
Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6:
- Reword commit message
Changes in v5:
- Reword commit message
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- new
---
.../boot/dts/rockchip/rk3588s-rock-5c.dts | 23 -------------------
1 file changed, 23 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 910ec67bd4eb..8b7bb382a20c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -350,23 +350,6 @@ regulator-state-mem {
};
};
-&i2c5 {
- pinctrl-names = "default";
- pinctrl-0 = <&i2c5m2_xfer>;
- status = "okay";
-
- rtc@51 {
- compatible = "haoyu,hym8563";
- reg = <0x51>;
- #clock-cells = <0>;
- clock-output-names = "rtcic_32kout";
- interrupt-parent = <&gpio0>;
- interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
- pinctrl-names = "default";
- pinctrl-0 = <&rtc_int_l>;
- };
-};
-
&i2c7 {
status = "okay";
@@ -449,12 +432,6 @@ pow_en: pow-en {
};
};
- rtc {
- rtc_int_l: rtc-int-l {
- rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
- };
- };
-
usb {
usb_host_pwren_h: usb-host-pwren-h {
rockchip,pins = <4 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>;
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH v6 3/7] arm64: dts: rockchip: Remove the RTC and related nodes for Radxa ROCK 5C
@ 2024-12-23 1:39 ` FUKAUMI Naoki
0 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
There is no RTC on the actual board, so remove it.
Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6:
- Reword commit message
Changes in v5:
- Reword commit message
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- new
---
.../boot/dts/rockchip/rk3588s-rock-5c.dts | 23 -------------------
1 file changed, 23 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 910ec67bd4eb..8b7bb382a20c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -350,23 +350,6 @@ regulator-state-mem {
};
};
-&i2c5 {
- pinctrl-names = "default";
- pinctrl-0 = <&i2c5m2_xfer>;
- status = "okay";
-
- rtc@51 {
- compatible = "haoyu,hym8563";
- reg = <0x51>;
- #clock-cells = <0>;
- clock-output-names = "rtcic_32kout";
- interrupt-parent = <&gpio0>;
- interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
- pinctrl-names = "default";
- pinctrl-0 = <&rtc_int_l>;
- };
-};
-
&i2c7 {
status = "okay";
@@ -449,12 +432,6 @@ pow_en: pow-en {
};
};
- rtc {
- rtc_int_l: rtc-int-l {
- rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
- };
- };
-
usb {
usb_host_pwren_h: usb-host-pwren-h {
rockchip,pins = <4 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>;
--
2.43.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v6 4/7] arm64: dts: rockchip: Add cd-gpios for sdmmc for Radxa ROCK 5C
2024-12-23 1:39 ` FUKAUMI Naoki
@ 2024-12-23 1:39 ` FUKAUMI Naoki
-1 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
Due to the discussion about cd-gpios and sdmmmc_det pin
functionality[1], it would be better to add cd-gpios for now.
[1] https://lore.kernel.org/linux-rockchip/4920950.GXAFRqVoOG@diego/T/#u
Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6:
- Reword commit message
Changes in v5:
- Reword commit message
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- none
---
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 8b7bb382a20c..8379bc97705c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -476,6 +476,7 @@ &sdmmc {
bus-width = <4>;
cap-mmc-highspeed;
cap-sd-highspeed;
+ cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
disable-wp;
no-sdio;
no-mmc;
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH v6 4/7] arm64: dts: rockchip: Add cd-gpios for sdmmc for Radxa ROCK 5C
@ 2024-12-23 1:39 ` FUKAUMI Naoki
0 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
Due to the discussion about cd-gpios and sdmmmc_det pin
functionality[1], it would be better to add cd-gpios for now.
[1] https://lore.kernel.org/linux-rockchip/4920950.GXAFRqVoOG@diego/T/#u
Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6:
- Reword commit message
Changes in v5:
- Reword commit message
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- none
---
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 8b7bb382a20c..8379bc97705c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -476,6 +476,7 @@ &sdmmc {
bus-width = <4>;
cap-mmc-highspeed;
cap-sd-highspeed;
+ cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
disable-wp;
no-sdio;
no-mmc;
--
2.43.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v6 5/7] arm64: dts: rockchip: Fix the properties of the PMIC regulators for Radxa ROCK 5C
2024-12-23 1:39 ` FUKAUMI Naoki
@ 2024-12-23 1:39 ` FUKAUMI Naoki
-1 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
Fix mistakes(copy-pasto) in the previous commit.
Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6:
- Reword commit message
Changes in v5:
- Reword commit message
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- split from "arm64: dts: rockchip: fix pmic properties for Radxa ROCK 5C"
---
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 8379bc97705c..9ce69ffad125 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -635,7 +635,6 @@ vcc_2v0_pldo_s3: dcdc-reg7 {
regulator-boot-on;
regulator-min-microvolt = <2000000>;
regulator-max-microvolt = <2000000>;
- regulator-ramp-delay = <12500>;
regulator-state-mem {
regulator-on-in-suspend;
@@ -789,7 +788,8 @@ vdda_0v75_s0: nldo-reg3 {
regulator-max-microvolt = <750000>;
regulator-state-mem {
- regulator-off-in-suspend;
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <750000>;
};
};
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH v6 5/7] arm64: dts: rockchip: Fix the properties of the PMIC regulators for Radxa ROCK 5C
@ 2024-12-23 1:39 ` FUKAUMI Naoki
0 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
Fix mistakes(copy-pasto) in the previous commit.
Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6:
- Reword commit message
Changes in v5:
- Reword commit message
Changes in v4:
- none
Changes in v3:
- none
Changes in v2:
- split from "arm64: dts: rockchip: fix pmic properties for Radxa ROCK 5C"
---
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 8379bc97705c..9ce69ffad125 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -635,7 +635,6 @@ vcc_2v0_pldo_s3: dcdc-reg7 {
regulator-boot-on;
regulator-min-microvolt = <2000000>;
regulator-max-microvolt = <2000000>;
- regulator-ramp-delay = <12500>;
regulator-state-mem {
regulator-on-in-suspend;
@@ -789,7 +788,8 @@ vdda_0v75_s0: nldo-reg3 {
regulator-max-microvolt = <750000>;
regulator-state-mem {
- regulator-off-in-suspend;
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <750000>;
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v6 6/7] arm64: dts: rockchip: Trivial changes for Radxa ROCK 5C
2024-12-23 1:39 ` FUKAUMI Naoki
@ 2024-12-23 1:39 ` FUKAUMI Naoki
-1 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
No functional change.
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6:
- New
---
.../boot/dts/rockchip/rk3588s-rock-5c.dts | 79 +++++++++----------
1 file changed, 38 insertions(+), 41 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 9ce69ffad125..419730f06f8f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -25,7 +25,7 @@ chosen {
stdout-path = "serial2:1500000n8";
};
- analog-sound {
+ sound {
compatible = "audio-graph-card";
label = "rk3588-es8316";
dais = <&i2s0_8ch_p0>;
@@ -50,7 +50,7 @@ hdmi0_con_in: endpoint {
leds {
compatible = "gpio-leds";
pinctrl-names = "default";
- pinctrl-0 = <&led_pins>;
+ pinctrl-0 = <&led_0 &led_1>;
led-0 {
color = <LED_COLOR_ID_GREEN>;
@@ -76,28 +76,19 @@ fan {
pwms = <&pwm3 0 60000 0>;
};
- pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
+ vcc3v3_pcie2x1l2: regulator-3v3-0 {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&pow_en>;
- regulator-name = "pcie2x1l2_3v3";
+ regulator-name = "vcc3v3_pcie2x1l2";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
vin-supply = <&vcc_sysin>;
};
- vcc5v_dcin: regulator-vcc5v-dcin {
- compatible = "regulator-fixed";
- regulator-name = "vcc5v_dcin";
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <5000000>;
- regulator-max-microvolt = <5000000>;
- };
-
- vcc5v0_usb_host: regulator-vcc5v0-usb-host {
+ vcc5v0_usb_host: regulator-5v0-0 {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio4 RK_PB5 GPIO_ACTIVE_HIGH>;
@@ -109,7 +100,7 @@ vcc5v0_usb_host: regulator-vcc5v0-usb-host {
vin-supply = <&vcc_sysin>;
};
- vcc5v0_usb_otg0: regulator-vcc5v0-usb-otg0 {
+ vcc5v0_usb_otg0: regulator-5v0-1 {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
@@ -121,7 +112,7 @@ vcc5v0_usb_otg0: regulator-vcc5v0-usb-otg0 {
vin-supply = <&vcc_sysin>;
};
- vcc_1v1_nldo_s3: regulator-vcc-1v1-nldo-s3 {
+ vcc_1v1_nldo_s3: regulator-1v1 {
compatible = "regulator-fixed";
regulator-name = "vcc_1v1_nldo_s3";
regulator-always-on;
@@ -131,7 +122,7 @@ vcc_1v1_nldo_s3: regulator-vcc-1v1-nldo-s3 {
vin-supply = <&vcc_sysin>;
};
- vcc_3v3_pmu: regulator-vcc-3v3-pmu {
+ vcc_3v3_pmu: regulator-3v3-1 {
compatible = "regulator-fixed";
regulator-name = "vcc_3v3_pmu";
regulator-always-on;
@@ -141,17 +132,17 @@ vcc_3v3_pmu: regulator-vcc-3v3-pmu {
vin-supply = <&vcc_3v3_s3>;
};
- vcc_3v3_s0: regulator-vcc-3v3-s0 {
+ vcc_3v3_s0: regulator-3v3-2 {
compatible = "regulator-fixed";
regulator-name = "vcc_3v3_s0";
regulator-always-on;
regulator-boot-on;
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- vin-supply = <&vcc_1v8_s0>;
+ vin-supply = <&vcc_3v3_s3>;
};
- vcc_5v0: regulator-vcc-5v0 {
+ vcc_5v0: regulator-5v0-2 {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>;
@@ -163,17 +154,16 @@ vcc_5v0: regulator-vcc-5v0 {
vin-supply = <&vcc_sysin>;
};
- vcc_sysin: regulator-vcc-sysin {
+ vcc_sysin: regulator-5v0-3 {
compatible = "regulator-fixed";
regulator-name = "vcc_sysin";
regulator-always-on;
regulator-boot-on;
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
- vin-supply = <&vcc5v_dcin>;
};
- vcca: regulator-vcca {
+ vcca: regulator-4v0 {
compatible = "regulator-fixed";
regulator-name = "vcca";
regulator-always-on;
@@ -183,7 +173,7 @@ vcca: regulator-vcca {
vin-supply = <&vcc_sysin>;
};
- vdd_3v3: regulator-vdd-3v3 {
+ vdd_3v3: regulator-3v3-3 {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>;
@@ -404,48 +394,53 @@ &pcie2x1l2 {
pinctrl-names = "default";
pinctrl-0 = <&pcie20x1_2_perstn_m0>;
reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>;
- vpcie3v3-supply = <&pcie2x1l2_3v3>;
+ vpcie3v3-supply = <&vcc3v3_pcie2x1l2>;
status = "okay";
};
&pinctrl {
leds {
- led_pins: led-pins {
- rockchip,pins = <3 RK_PC4 RK_FUNC_GPIO &pcfg_pull_none>,
- <3 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>;
+ led_0: led-0 {
+ rockchip,pins = <3 RK_PC4 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+
+ led_1: led-1 {
+ rockchip,pins = <3 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
- mdio {
- gmac1_rstn: gmac1-rstn {
+ ethernet-phy {
+ gmac1_rstn: ethernet-phy-0 {
rockchip,pins = <3 RK_PB7 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
pcie {
- pcie20x1_2_perstn_m0: pcie20x1-2-perstn-m0 {
+ pcie20x1_2_perstn_m0: pcie-0 {
rockchip,pins = <3 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>;
};
- pow_en: pow-en {
+ pow_en: regulator-3v3-0 {
rockchip,pins = <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
usb {
- usb_host_pwren_h: usb-host-pwren-h {
+ usb_host_pwren_h: regulator-5v0-0 {
rockchip,pins = <4 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>;
};
- usb_otg_pwren_h: usb-otg-pwren-h {
+ usb_otg_pwren_h: regulator-5v0-1 {
rockchip,pins = <0 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
};
- usb_wifi_pwr: usb-wifi-pwr {
+ usb_wifi_pwr: regulator-3v3-3 {
rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
};
+ };
- vcc_5v0_pwren_h: vcc-5v0-pwren-h {
+ regulators {
+ vcc_5v0_pwren_h: regulator-5v0-2 {
rockchip,pins = <4 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
@@ -464,11 +459,14 @@ &saradc {
&sdhci {
bus-width = <8>;
+ cap-mmc-highspeed;
mmc-hs400-1_8v;
mmc-hs400-enhanced-strobe;
- no-sdio;
no-sd;
+ no-sdio;
non-removable;
+ vmmc-supply = <&vcc_3v3_s0>;
+ vqmmc-supply = <&vcc_1v8_s3>;
status = "okay";
};
@@ -479,7 +477,6 @@ &sdmmc {
cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
disable-wp;
no-sdio;
- no-mmc;
sd-uhs-sdr104;
vmmc-supply = <&vcc_3v3_s3>;
vqmmc-supply = <&vccio_sd_s0>;
@@ -630,7 +627,7 @@ regulator-state-mem {
};
vcc_2v0_pldo_s3: dcdc-reg7 {
- regulator-name = "vdd_2v0_pldo_s3";
+ regulator-name = "vcc_2v0_pldo_s3";
regulator-always-on;
regulator-boot-on;
regulator-min-microvolt = <2000000>;
@@ -665,8 +662,8 @@ regulator-state-mem {
};
};
- vcc1v8_pmu_ddr_s3: dcdc-reg10 {
- regulator-name = "vcc1v8_pmu_ddr_s3";
+ vcc_1v8_s3: dcdc-reg10 {
+ regulator-name = "vcc_1v8_s3";
regulator-always-on;
regulator-boot-on;
regulator-min-microvolt = <1800000>;
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH v6 6/7] arm64: dts: rockchip: Trivial changes for Radxa ROCK 5C
@ 2024-12-23 1:39 ` FUKAUMI Naoki
0 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
No functional change.
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6:
- New
---
.../boot/dts/rockchip/rk3588s-rock-5c.dts | 79 +++++++++----------
1 file changed, 38 insertions(+), 41 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 9ce69ffad125..419730f06f8f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -25,7 +25,7 @@ chosen {
stdout-path = "serial2:1500000n8";
};
- analog-sound {
+ sound {
compatible = "audio-graph-card";
label = "rk3588-es8316";
dais = <&i2s0_8ch_p0>;
@@ -50,7 +50,7 @@ hdmi0_con_in: endpoint {
leds {
compatible = "gpio-leds";
pinctrl-names = "default";
- pinctrl-0 = <&led_pins>;
+ pinctrl-0 = <&led_0 &led_1>;
led-0 {
color = <LED_COLOR_ID_GREEN>;
@@ -76,28 +76,19 @@ fan {
pwms = <&pwm3 0 60000 0>;
};
- pcie2x1l2_3v3: regulator-pcie2x1l2-3v3 {
+ vcc3v3_pcie2x1l2: regulator-3v3-0 {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio0 RK_PC5 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&pow_en>;
- regulator-name = "pcie2x1l2_3v3";
+ regulator-name = "vcc3v3_pcie2x1l2";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
vin-supply = <&vcc_sysin>;
};
- vcc5v_dcin: regulator-vcc5v-dcin {
- compatible = "regulator-fixed";
- regulator-name = "vcc5v_dcin";
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <5000000>;
- regulator-max-microvolt = <5000000>;
- };
-
- vcc5v0_usb_host: regulator-vcc5v0-usb-host {
+ vcc5v0_usb_host: regulator-5v0-0 {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio4 RK_PB5 GPIO_ACTIVE_HIGH>;
@@ -109,7 +100,7 @@ vcc5v0_usb_host: regulator-vcc5v0-usb-host {
vin-supply = <&vcc_sysin>;
};
- vcc5v0_usb_otg0: regulator-vcc5v0-usb-otg0 {
+ vcc5v0_usb_otg0: regulator-5v0-1 {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio0 RK_PD4 GPIO_ACTIVE_HIGH>;
@@ -121,7 +112,7 @@ vcc5v0_usb_otg0: regulator-vcc5v0-usb-otg0 {
vin-supply = <&vcc_sysin>;
};
- vcc_1v1_nldo_s3: regulator-vcc-1v1-nldo-s3 {
+ vcc_1v1_nldo_s3: regulator-1v1 {
compatible = "regulator-fixed";
regulator-name = "vcc_1v1_nldo_s3";
regulator-always-on;
@@ -131,7 +122,7 @@ vcc_1v1_nldo_s3: regulator-vcc-1v1-nldo-s3 {
vin-supply = <&vcc_sysin>;
};
- vcc_3v3_pmu: regulator-vcc-3v3-pmu {
+ vcc_3v3_pmu: regulator-3v3-1 {
compatible = "regulator-fixed";
regulator-name = "vcc_3v3_pmu";
regulator-always-on;
@@ -141,17 +132,17 @@ vcc_3v3_pmu: regulator-vcc-3v3-pmu {
vin-supply = <&vcc_3v3_s3>;
};
- vcc_3v3_s0: regulator-vcc-3v3-s0 {
+ vcc_3v3_s0: regulator-3v3-2 {
compatible = "regulator-fixed";
regulator-name = "vcc_3v3_s0";
regulator-always-on;
regulator-boot-on;
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- vin-supply = <&vcc_1v8_s0>;
+ vin-supply = <&vcc_3v3_s3>;
};
- vcc_5v0: regulator-vcc-5v0 {
+ vcc_5v0: regulator-5v0-2 {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>;
@@ -163,17 +154,16 @@ vcc_5v0: regulator-vcc-5v0 {
vin-supply = <&vcc_sysin>;
};
- vcc_sysin: regulator-vcc-sysin {
+ vcc_sysin: regulator-5v0-3 {
compatible = "regulator-fixed";
regulator-name = "vcc_sysin";
regulator-always-on;
regulator-boot-on;
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
- vin-supply = <&vcc5v_dcin>;
};
- vcca: regulator-vcca {
+ vcca: regulator-4v0 {
compatible = "regulator-fixed";
regulator-name = "vcca";
regulator-always-on;
@@ -183,7 +173,7 @@ vcca: regulator-vcca {
vin-supply = <&vcc_sysin>;
};
- vdd_3v3: regulator-vdd-3v3 {
+ vdd_3v3: regulator-3v3-3 {
compatible = "regulator-fixed";
enable-active-high;
gpio = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>;
@@ -404,48 +394,53 @@ &pcie2x1l2 {
pinctrl-names = "default";
pinctrl-0 = <&pcie20x1_2_perstn_m0>;
reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>;
- vpcie3v3-supply = <&pcie2x1l2_3v3>;
+ vpcie3v3-supply = <&vcc3v3_pcie2x1l2>;
status = "okay";
};
&pinctrl {
leds {
- led_pins: led-pins {
- rockchip,pins = <3 RK_PC4 RK_FUNC_GPIO &pcfg_pull_none>,
- <3 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>;
+ led_0: led-0 {
+ rockchip,pins = <3 RK_PC4 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+
+ led_1: led-1 {
+ rockchip,pins = <3 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
- mdio {
- gmac1_rstn: gmac1-rstn {
+ ethernet-phy {
+ gmac1_rstn: ethernet-phy-0 {
rockchip,pins = <3 RK_PB7 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
pcie {
- pcie20x1_2_perstn_m0: pcie20x1-2-perstn-m0 {
+ pcie20x1_2_perstn_m0: pcie-0 {
rockchip,pins = <3 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>;
};
- pow_en: pow-en {
+ pow_en: regulator-3v3-0 {
rockchip,pins = <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
usb {
- usb_host_pwren_h: usb-host-pwren-h {
+ usb_host_pwren_h: regulator-5v0-0 {
rockchip,pins = <4 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>;
};
- usb_otg_pwren_h: usb-otg-pwren-h {
+ usb_otg_pwren_h: regulator-5v0-1 {
rockchip,pins = <0 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
};
- usb_wifi_pwr: usb-wifi-pwr {
+ usb_wifi_pwr: regulator-3v3-3 {
rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
};
+ };
- vcc_5v0_pwren_h: vcc-5v0-pwren-h {
+ regulators {
+ vcc_5v0_pwren_h: regulator-5v0-2 {
rockchip,pins = <4 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
@@ -464,11 +459,14 @@ &saradc {
&sdhci {
bus-width = <8>;
+ cap-mmc-highspeed;
mmc-hs400-1_8v;
mmc-hs400-enhanced-strobe;
- no-sdio;
no-sd;
+ no-sdio;
non-removable;
+ vmmc-supply = <&vcc_3v3_s0>;
+ vqmmc-supply = <&vcc_1v8_s3>;
status = "okay";
};
@@ -479,7 +477,6 @@ &sdmmc {
cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
disable-wp;
no-sdio;
- no-mmc;
sd-uhs-sdr104;
vmmc-supply = <&vcc_3v3_s3>;
vqmmc-supply = <&vccio_sd_s0>;
@@ -630,7 +627,7 @@ regulator-state-mem {
};
vcc_2v0_pldo_s3: dcdc-reg7 {
- regulator-name = "vdd_2v0_pldo_s3";
+ regulator-name = "vcc_2v0_pldo_s3";
regulator-always-on;
regulator-boot-on;
regulator-min-microvolt = <2000000>;
@@ -665,8 +662,8 @@ regulator-state-mem {
};
};
- vcc1v8_pmu_ddr_s3: dcdc-reg10 {
- regulator-name = "vcc1v8_pmu_ddr_s3";
+ vcc_1v8_s3: dcdc-reg10 {
+ regulator-name = "vcc_1v8_s3";
regulator-always-on;
regulator-boot-on;
regulator-min-microvolt = <1800000>;
--
2.43.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v6 7/7] arm64: dts: rockchip: Sort nodes for Radxa ROCK 5C
2024-12-23 1:39 ` FUKAUMI Naoki
@ 2024-12-23 1:39 ` FUKAUMI Naoki
-1 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
Sort nodes alphanumerically. No functional change.
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6:
- Reflect other commits, no functional change
Changes in v5:
- Reword commit message
Changes in v4:
- Reflect other commits, no functional change
Changes in v3:
- none
Changes in v2:
- new
---
.../boot/dts/rockchip/rk3588s-rock-5c.dts | 176 +++++++++---------
1 file changed, 88 insertions(+), 88 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 419730f06f8f..a3deae077233 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -25,15 +25,12 @@ chosen {
stdout-path = "serial2:1500000n8";
};
- sound {
- compatible = "audio-graph-card";
- label = "rk3588-es8316";
- dais = <&i2s0_8ch_p0>;
- routing = "MIC2", "Mic Jack",
- "Headphones", "HPOL",
- "Headphones", "HPOR";
- widgets = "Microphone", "Mic Jack",
- "Headphone", "Headphones";
+ fan {
+ compatible = "pwm-fan";
+ #cooling-cells = <2>;
+ cooling-levels = <0 64 128 192 255>;
+ fan-supply = <&vcc_5v0>;
+ pwms = <&pwm3 0 60000 0>;
};
hdmi0-con {
@@ -68,12 +65,14 @@ led-1 {
};
};
- fan {
- compatible = "pwm-fan";
- #cooling-cells = <2>;
- cooling-levels = <0 64 128 192 255>;
- fan-supply = <&vcc_5v0>;
- pwms = <&pwm3 0 60000 0>;
+ vcc_1v1_nldo_s3: regulator-1v1 {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_1v1_nldo_s3";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1100000>;
+ vin-supply = <&vcc_sysin>;
};
vcc3v3_pcie2x1l2: regulator-3v3-0 {
@@ -88,6 +87,50 @@ vcc3v3_pcie2x1l2: regulator-3v3-0 {
vin-supply = <&vcc_sysin>;
};
+ vcc_3v3_pmu: regulator-3v3-1 {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_3v3_pmu";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ vin-supply = <&vcc_3v3_s3>;
+ };
+
+ vcc_3v3_s0: regulator-3v3-2 {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_3v3_s0";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ vin-supply = <&vcc_3v3_s3>;
+ };
+
+ vdd_3v3: regulator-3v3-3 {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ gpio = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&usb_wifi_pwr>;
+ regulator-name = "vdd_3v3";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ vin-supply = <&vcc_3v3_s3>;
+ };
+
+ vcca: regulator-4v0 {
+ compatible = "regulator-fixed";
+ regulator-name = "vcca";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <4000000>;
+ regulator-max-microvolt = <4000000>;
+ vin-supply = <&vcc_sysin>;
+ };
+
vcc5v0_usb_host: regulator-5v0-0 {
compatible = "regulator-fixed";
enable-active-high;
@@ -112,36 +155,6 @@ vcc5v0_usb_otg0: regulator-5v0-1 {
vin-supply = <&vcc_sysin>;
};
- vcc_1v1_nldo_s3: regulator-1v1 {
- compatible = "regulator-fixed";
- regulator-name = "vcc_1v1_nldo_s3";
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <1100000>;
- regulator-max-microvolt = <1100000>;
- vin-supply = <&vcc_sysin>;
- };
-
- vcc_3v3_pmu: regulator-3v3-1 {
- compatible = "regulator-fixed";
- regulator-name = "vcc_3v3_pmu";
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- vin-supply = <&vcc_3v3_s3>;
- };
-
- vcc_3v3_s0: regulator-3v3-2 {
- compatible = "regulator-fixed";
- regulator-name = "vcc_3v3_s0";
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- vin-supply = <&vcc_3v3_s3>;
- };
-
vcc_5v0: regulator-5v0-2 {
compatible = "regulator-fixed";
enable-active-high;
@@ -163,28 +176,15 @@ vcc_sysin: regulator-5v0-3 {
regulator-max-microvolt = <5000000>;
};
- vcca: regulator-4v0 {
- compatible = "regulator-fixed";
- regulator-name = "vcca";
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <4000000>;
- regulator-max-microvolt = <4000000>;
- vin-supply = <&vcc_sysin>;
- };
-
- vdd_3v3: regulator-3v3-3 {
- compatible = "regulator-fixed";
- enable-active-high;
- gpio = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>;
- pinctrl-names = "default";
- pinctrl-0 = <&usb_wifi_pwr>;
- regulator-name = "vdd_3v3";
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- vin-supply = <&vcc_3v3_s3>;
+ sound {
+ compatible = "audio-graph-card";
+ label = "rk3588-es8316";
+ dais = <&i2s0_8ch_p0>;
+ routing = "MIC2", "Mic Jack",
+ "Headphones", "HPOL",
+ "Headphones", "HPOR";
+ widgets = "Microphone", "Mic Jack",
+ "Headphone", "Headphones";
};
};
@@ -399,6 +399,12 @@ &pcie2x1l2 {
};
&pinctrl {
+ ethernet-phy {
+ gmac1_rstn: ethernet-phy-0 {
+ rockchip,pins = <3 RK_PB7 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+
leds {
led_0: led-0 {
rockchip,pins = <3 RK_PC4 RK_FUNC_GPIO &pcfg_pull_none>;
@@ -409,12 +415,6 @@ led_1: led-1 {
};
};
- ethernet-phy {
- gmac1_rstn: ethernet-phy-0 {
- rockchip,pins = <3 RK_PB7 RK_FUNC_GPIO &pcfg_pull_none>;
- };
- };
-
pcie {
pcie20x1_2_perstn_m0: pcie-0 {
rockchip,pins = <3 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>;
@@ -425,7 +425,17 @@ pow_en: regulator-3v3-0 {
};
};
+ regulators {
+ vcc_5v0_pwren_h: regulator-5v0-2 {
+ rockchip,pins = <4 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+
usb {
+ usb_wifi_pwr: regulator-3v3-3 {
+ rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+
usb_host_pwren_h: regulator-5v0-0 {
rockchip,pins = <4 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>;
};
@@ -433,16 +443,6 @@ usb_host_pwren_h: regulator-5v0-0 {
usb_otg_pwren_h: regulator-5v0-1 {
rockchip,pins = <0 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
};
-
- usb_wifi_pwr: regulator-3v3-3 {
- rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
- };
- };
-
- regulators {
- vcc_5v0_pwren_h: regulator-5v0-2 {
- rockchip,pins = <4 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>;
- };
};
};
@@ -854,10 +854,6 @@ &uart2 {
status = "okay";
};
-&usbdp_phy0 {
- status = "okay";
-};
-
&usb_host0_ehci {
status = "okay";
};
@@ -879,7 +875,7 @@ &usb_host2_xhci {
status = "okay";
};
-&vop_mmu {
+&usbdp_phy0 {
status = "okay";
};
@@ -887,6 +883,10 @@ &vop {
status = "okay";
};
+&vop_mmu {
+ status = "okay";
+};
+
&vp0 {
vp0_out_hdmi0: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
reg = <ROCKCHIP_VOP2_EP_HDMI0>;
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH v6 7/7] arm64: dts: rockchip: Sort nodes for Radxa ROCK 5C
@ 2024-12-23 1:39 ` FUKAUMI Naoki
0 siblings, 0 replies; 20+ messages in thread
From: FUKAUMI Naoki @ 2024-12-23 1:39 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, dsimic, devicetree, linux-rockchip,
FUKAUMI Naoki
Sort nodes alphanumerically. No functional change.
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
Changes in v6:
- Reflect other commits, no functional change
Changes in v5:
- Reword commit message
Changes in v4:
- Reflect other commits, no functional change
Changes in v3:
- none
Changes in v2:
- new
---
.../boot/dts/rockchip/rk3588s-rock-5c.dts | 176 +++++++++---------
1 file changed, 88 insertions(+), 88 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
index 419730f06f8f..a3deae077233 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts
@@ -25,15 +25,12 @@ chosen {
stdout-path = "serial2:1500000n8";
};
- sound {
- compatible = "audio-graph-card";
- label = "rk3588-es8316";
- dais = <&i2s0_8ch_p0>;
- routing = "MIC2", "Mic Jack",
- "Headphones", "HPOL",
- "Headphones", "HPOR";
- widgets = "Microphone", "Mic Jack",
- "Headphone", "Headphones";
+ fan {
+ compatible = "pwm-fan";
+ #cooling-cells = <2>;
+ cooling-levels = <0 64 128 192 255>;
+ fan-supply = <&vcc_5v0>;
+ pwms = <&pwm3 0 60000 0>;
};
hdmi0-con {
@@ -68,12 +65,14 @@ led-1 {
};
};
- fan {
- compatible = "pwm-fan";
- #cooling-cells = <2>;
- cooling-levels = <0 64 128 192 255>;
- fan-supply = <&vcc_5v0>;
- pwms = <&pwm3 0 60000 0>;
+ vcc_1v1_nldo_s3: regulator-1v1 {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_1v1_nldo_s3";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1100000>;
+ vin-supply = <&vcc_sysin>;
};
vcc3v3_pcie2x1l2: regulator-3v3-0 {
@@ -88,6 +87,50 @@ vcc3v3_pcie2x1l2: regulator-3v3-0 {
vin-supply = <&vcc_sysin>;
};
+ vcc_3v3_pmu: regulator-3v3-1 {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_3v3_pmu";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ vin-supply = <&vcc_3v3_s3>;
+ };
+
+ vcc_3v3_s0: regulator-3v3-2 {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_3v3_s0";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ vin-supply = <&vcc_3v3_s3>;
+ };
+
+ vdd_3v3: regulator-3v3-3 {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ gpio = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&usb_wifi_pwr>;
+ regulator-name = "vdd_3v3";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ vin-supply = <&vcc_3v3_s3>;
+ };
+
+ vcca: regulator-4v0 {
+ compatible = "regulator-fixed";
+ regulator-name = "vcca";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <4000000>;
+ regulator-max-microvolt = <4000000>;
+ vin-supply = <&vcc_sysin>;
+ };
+
vcc5v0_usb_host: regulator-5v0-0 {
compatible = "regulator-fixed";
enable-active-high;
@@ -112,36 +155,6 @@ vcc5v0_usb_otg0: regulator-5v0-1 {
vin-supply = <&vcc_sysin>;
};
- vcc_1v1_nldo_s3: regulator-1v1 {
- compatible = "regulator-fixed";
- regulator-name = "vcc_1v1_nldo_s3";
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <1100000>;
- regulator-max-microvolt = <1100000>;
- vin-supply = <&vcc_sysin>;
- };
-
- vcc_3v3_pmu: regulator-3v3-1 {
- compatible = "regulator-fixed";
- regulator-name = "vcc_3v3_pmu";
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- vin-supply = <&vcc_3v3_s3>;
- };
-
- vcc_3v3_s0: regulator-3v3-2 {
- compatible = "regulator-fixed";
- regulator-name = "vcc_3v3_s0";
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- vin-supply = <&vcc_3v3_s3>;
- };
-
vcc_5v0: regulator-5v0-2 {
compatible = "regulator-fixed";
enable-active-high;
@@ -163,28 +176,15 @@ vcc_sysin: regulator-5v0-3 {
regulator-max-microvolt = <5000000>;
};
- vcca: regulator-4v0 {
- compatible = "regulator-fixed";
- regulator-name = "vcca";
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <4000000>;
- regulator-max-microvolt = <4000000>;
- vin-supply = <&vcc_sysin>;
- };
-
- vdd_3v3: regulator-3v3-3 {
- compatible = "regulator-fixed";
- enable-active-high;
- gpio = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>;
- pinctrl-names = "default";
- pinctrl-0 = <&usb_wifi_pwr>;
- regulator-name = "vdd_3v3";
- regulator-always-on;
- regulator-boot-on;
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- vin-supply = <&vcc_3v3_s3>;
+ sound {
+ compatible = "audio-graph-card";
+ label = "rk3588-es8316";
+ dais = <&i2s0_8ch_p0>;
+ routing = "MIC2", "Mic Jack",
+ "Headphones", "HPOL",
+ "Headphones", "HPOR";
+ widgets = "Microphone", "Mic Jack",
+ "Headphone", "Headphones";
};
};
@@ -399,6 +399,12 @@ &pcie2x1l2 {
};
&pinctrl {
+ ethernet-phy {
+ gmac1_rstn: ethernet-phy-0 {
+ rockchip,pins = <3 RK_PB7 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+
leds {
led_0: led-0 {
rockchip,pins = <3 RK_PC4 RK_FUNC_GPIO &pcfg_pull_none>;
@@ -409,12 +415,6 @@ led_1: led-1 {
};
};
- ethernet-phy {
- gmac1_rstn: ethernet-phy-0 {
- rockchip,pins = <3 RK_PB7 RK_FUNC_GPIO &pcfg_pull_none>;
- };
- };
-
pcie {
pcie20x1_2_perstn_m0: pcie-0 {
rockchip,pins = <3 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>;
@@ -425,7 +425,17 @@ pow_en: regulator-3v3-0 {
};
};
+ regulators {
+ vcc_5v0_pwren_h: regulator-5v0-2 {
+ rockchip,pins = <4 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+
usb {
+ usb_wifi_pwr: regulator-3v3-3 {
+ rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+
usb_host_pwren_h: regulator-5v0-0 {
rockchip,pins = <4 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>;
};
@@ -433,16 +443,6 @@ usb_host_pwren_h: regulator-5v0-0 {
usb_otg_pwren_h: regulator-5v0-1 {
rockchip,pins = <0 RK_PD4 RK_FUNC_GPIO &pcfg_pull_none>;
};
-
- usb_wifi_pwr: regulator-3v3-3 {
- rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
- };
- };
-
- regulators {
- vcc_5v0_pwren_h: regulator-5v0-2 {
- rockchip,pins = <4 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>;
- };
};
};
@@ -854,10 +854,6 @@ &uart2 {
status = "okay";
};
-&usbdp_phy0 {
- status = "okay";
-};
-
&usb_host0_ehci {
status = "okay";
};
@@ -879,7 +875,7 @@ &usb_host2_xhci {
status = "okay";
};
-&vop_mmu {
+&usbdp_phy0 {
status = "okay";
};
@@ -887,6 +883,10 @@ &vop {
status = "okay";
};
+&vop_mmu {
+ status = "okay";
+};
+
&vp0 {
vp0_out_hdmi0: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
reg = <ROCKCHIP_VOP2_EP_HDMI0>;
--
2.43.0
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH v6 0/7] arm64: dts: rockchip: Refine dts for Radxa ROCK 5C
2024-12-23 1:39 ` FUKAUMI Naoki
@ 2024-12-27 15:18 ` Rob Herring (Arm)
-1 siblings, 0 replies; 20+ messages in thread
From: Rob Herring (Arm) @ 2024-12-27 15:18 UTC (permalink / raw)
To: FUKAUMI Naoki
Cc: dsimic, heiko, linux-rockchip, krzk+dt, devicetree, conor+dt
On Mon, 23 Dec 2024 01:39:19 +0000, FUKAUMI Naoki wrote:
> This patch series includes fixes for improvements, trivial changes,
> etc for Radxa ROCK 5C.
>
> FUKAUMI Naoki (7):
> arm64: dts: rockchip: Change the function of the blue LED for Radxa
> ROCK 5C
> arm64: dts: rockchip: Use a longer PWM period for the fan on Radxa
> ROCK 5C
> arm64: dts: rockchip: Remove the RTC and related nodes for Radxa ROCK
> 5C
> arm64: dts: rockchip: Add cd-gpios for sdmmc for Radxa ROCK 5C
> arm64: dts: rockchip: Fix the properties of the PMIC regulators for
> Radxa ROCK 5C
> arm64: dts: rockchip: Trivial changes for Radxa ROCK 5C
> arm64: dts: rockchip: Sort nodes for Radxa ROCK 5C
>
> .../boot/dts/rockchip/rk3588s-rock-5c.dts | 239 ++++++++----------
> 1 file changed, 107 insertions(+), 132 deletions(-)
>
> --
> 2.43.0
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-rock-5c.dtb' for 20241223013926.1134-1-naoki@radxa.com:
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dtb: ethernet-phy: 'reg' is a required property
from schema $id: http://devicetree.org/schemas/net/ethernet-phy.yaml#
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v6 0/7] arm64: dts: rockchip: Refine dts for Radxa ROCK 5C
@ 2024-12-27 15:18 ` Rob Herring (Arm)
0 siblings, 0 replies; 20+ messages in thread
From: Rob Herring (Arm) @ 2024-12-27 15:18 UTC (permalink / raw)
To: FUKAUMI Naoki
Cc: dsimic, heiko, linux-rockchip, krzk+dt, devicetree, conor+dt
On Mon, 23 Dec 2024 01:39:19 +0000, FUKAUMI Naoki wrote:
> This patch series includes fixes for improvements, trivial changes,
> etc for Radxa ROCK 5C.
>
> FUKAUMI Naoki (7):
> arm64: dts: rockchip: Change the function of the blue LED for Radxa
> ROCK 5C
> arm64: dts: rockchip: Use a longer PWM period for the fan on Radxa
> ROCK 5C
> arm64: dts: rockchip: Remove the RTC and related nodes for Radxa ROCK
> 5C
> arm64: dts: rockchip: Add cd-gpios for sdmmc for Radxa ROCK 5C
> arm64: dts: rockchip: Fix the properties of the PMIC regulators for
> Radxa ROCK 5C
> arm64: dts: rockchip: Trivial changes for Radxa ROCK 5C
> arm64: dts: rockchip: Sort nodes for Radxa ROCK 5C
>
> .../boot/dts/rockchip/rk3588s-rock-5c.dts | 239 ++++++++----------
> 1 file changed, 107 insertions(+), 132 deletions(-)
>
> --
> 2.43.0
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-rock-5c.dtb' for 20241223013926.1134-1-naoki@radxa.com:
arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dtb: ethernet-phy: 'reg' is a required property
from schema $id: http://devicetree.org/schemas/net/ethernet-phy.yaml#
^ permalink raw reply [flat|nested] 20+ messages in thread