All of lore.kernel.org
 help / color / mirror / Atom feed
From: khsieh@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: dri-devel@lists.freedesktop.org, robdclark@gmail.com,
	sean@poorly.run, tanmay@codeaurora.org, abhinavk@codeaurora.org,
	aravindh@codeaurora.org, airlied@linux.ie, daniel@ffwll.ch,
	linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state
Date: Wed, 13 Jan 2021 15:44:32 -0800	[thread overview]
Message-ID: <b4a6e7695d12c3191bff75668f386da9@codeaurora.org> (raw)
In-Reply-To: <161056933099.3661239.9450322359293035316@swboyd.mtv.corp.google.com>

On 2021-01-13 12:22, Stephen Boyd wrote:
> Quoting khsieh@codeaurora.org (2021-01-13 09:44:24)
>> On 2021-01-11 11:55, Stephen Boyd wrote:
>> > Quoting Kuogee Hsieh (2021-01-07 12:30:24)
>> >> irq_hpd event can only be executed at connected state. Therefore
>> >> irq_hpd event should be postponed if it happened at connection
>> >> pending state. This patch also make sure both link rate and lane
>> >
>> > Why does it happen at connection pending state?
>> plug in need two state to complete it.
>> advance to connection pending state once link training completed and
>> sent uevent notification to frame work.
>> transition to connected state after frame work provided resolution
>> timing and start transmit video panel.
>> Therefore irq_hpd should not be handled if it occurred before 
>> connected
>> state.
> 
> Sure that's what's going on in the patch but you didn't answer my
> question. Why does irq_hpd happen before connected state?

I have no idea why it happen this way.
during debug 
https://partnerissuetracker.corp.google.com/issues/170598152
I saw two different scenario
1) irq_hpd followed by unplug with less than 20 ms in between. this one 
fixed by this patch set.
2) plug followed by irq_hpd around 300ms in between. it does not cause 
problem. but it should be handled in order (after connected state).

WARNING: multiple messages have this Message-ID (diff)
From: khsieh@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: freedreno@lists.freedesktop.org, airlied@linux.ie,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, abhinavk@codeaurora.org,
	tanmay@codeaurora.org, aravindh@codeaurora.org, sean@poorly.run
Subject: Re: [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state
Date: Wed, 13 Jan 2021 15:44:32 -0800	[thread overview]
Message-ID: <b4a6e7695d12c3191bff75668f386da9@codeaurora.org> (raw)
In-Reply-To: <161056933099.3661239.9450322359293035316@swboyd.mtv.corp.google.com>

On 2021-01-13 12:22, Stephen Boyd wrote:
> Quoting khsieh@codeaurora.org (2021-01-13 09:44:24)
>> On 2021-01-11 11:55, Stephen Boyd wrote:
>> > Quoting Kuogee Hsieh (2021-01-07 12:30:24)
>> >> irq_hpd event can only be executed at connected state. Therefore
>> >> irq_hpd event should be postponed if it happened at connection
>> >> pending state. This patch also make sure both link rate and lane
>> >
>> > Why does it happen at connection pending state?
>> plug in need two state to complete it.
>> advance to connection pending state once link training completed and
>> sent uevent notification to frame work.
>> transition to connected state after frame work provided resolution
>> timing and start transmit video panel.
>> Therefore irq_hpd should not be handled if it occurred before 
>> connected
>> state.
> 
> Sure that's what's going on in the patch but you didn't answer my
> question. Why does irq_hpd happen before connected state?

I have no idea why it happen this way.
during debug 
https://partnerissuetracker.corp.google.com/issues/170598152
I saw two different scenario
1) irq_hpd followed by unplug with less than 20 ms in between. this one 
fixed by this patch set.
2) plug followed by irq_hpd around 300ms in between. it does not cause 
problem. but it should be handled in order (after connected state).
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2021-01-14  1:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 20:30 [PATCH 0/2] *** fix missing unplug interrupt problem *** Kuogee Hsieh
2021-01-07 20:30 ` Kuogee Hsieh
2021-01-07 20:30 ` [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state Kuogee Hsieh
2021-01-07 20:30   ` Kuogee Hsieh
2021-01-11 19:55   ` Stephen Boyd
2021-01-11 19:55     ` Stephen Boyd
2021-01-13 17:44     ` khsieh
2021-01-13 17:44       ` khsieh
2021-01-13 20:21       ` Stephen Boyd
2021-01-13 20:21         ` Stephen Boyd
2021-01-13 20:22       ` Stephen Boyd
2021-01-13 20:22         ` Stephen Boyd
2021-01-13 23:44         ` khsieh [this message]
2021-01-13 23:44           ` khsieh
2021-01-14  0:00           ` Stephen Boyd
2021-01-14  0:00             ` Stephen Boyd
2021-01-14 17:13             ` khsieh
2021-01-14 17:13               ` khsieh
2021-01-07 20:30 ` [PATCH 2/2] drm/msm/dp: unplug interrupt missed after irq_hpd handler Kuogee Hsieh
2021-01-07 20:30   ` Kuogee Hsieh
2021-01-11 19:54   ` Stephen Boyd
2021-01-11 19:54     ` Stephen Boyd
2021-01-13 17:48     ` khsieh
2021-01-13 17:48       ` khsieh
2021-01-13 20:23       ` Stephen Boyd
2021-01-13 20:23         ` Stephen Boyd
2021-01-13 23:46         ` khsieh
2021-01-13 23:46           ` khsieh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4a6e7695d12c3191bff75668f386da9@codeaurora.org \
    --to=khsieh@codeaurora.org \
    --cc=abhinavk@codeaurora.org \
    --cc=airlied@linux.ie \
    --cc=aravindh@codeaurora.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    --cc=tanmay@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.