RE: Lenovo LOQ rtw_8852be

[Ping-Ke Shih <pkshih@realtek.com>]

> -----Original Message-----
> From: Ali Ghandour <gandour.ali@gmail.com>
> Sent: Monday, November 27, 2023 2:19 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: linux-wireless@vger.kernel.org
> Subject: Re: Lenovo LOQ rtw_8852be
> 
> seems like the same error persists after downgrading:
> 
> $ uname -r
> 5.17.0-1035-oem
> 
> $ sudo dmesg | grep rtw
> [    4.859848] rtw89_8852be 0000:09:00.0: loaded firmware
> rtw89/rtw8852b_fw-1.bin
> [    4.860214] rtw89_8852be 0000:09:00.0: enabling device (0000 -> 0003)
> [    4.861546] rtw89_8852be 0000:09:00.0: Firmware version 0.29.29.5
> (da87cccd), cmd version 0, type 5
> [    4.861550] rtw89_8852be 0000:09:00.0: Firmware version 0.29.29.5
> (da87cccd), cmd version 0, type 3
> [    4.861556] rtw89_8852be 0000:09:00.0: MAC has already powered on
> [    4.867246] rtw89_8852be 0000:09:00.0: [ERR]pci config read 719

We did changes after 5.18, but your 5.17 print out error with
"pci config read" instead of "dbi_r8_pcie". 

-       ret = rtw89_dbi_read8(rtwdev, RTW89_PCIE_L1_CTRL, &bdr_ori);
+       ret = rtw89_pci_read_config_byte(rtwdev, RTW89_PCIE_L1_CTRL, &bdr_ori);
        if (ret) {
-               rtw89_err(rtwdev, "[ERR]dbi_r8_pcie %X\n", RTW89_PCIE_L1_CTRL);  // 5.17
+               rtw89_err(rtwdev, "[ERR]pci config read %X\n", RTW89_PCIE_L1_CTRL); // 5.18
                return ret;
        }

Uh. I know the reason why you see the new one, because 8852be is supported
by kernel 6.2, and distro backport the driver to old kernel.


If you can build driver yourself, please revert below patch and try again.
Fixes: db38d9cd26c9 ("rtw89: use pci_read/write_config instead of dbi read/write")

> >
> > $ lspci -tv
> > -[0000:00]-+-00.0  Intel Corporation Device a715

I will try to Google to see if I can find some information about this PCI host controller.

Can I know the type of your platoform Lenovo LOQ? Is it a regular notebook computer?

> >
> > $ sudo lspci -s 09:00.0 -xxxx
> > 09:00.0 Network controller: Realtek Semiconductor Co., Ltd. Device b852

[...]

> > f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

In my side, lspci with '-xxxx', it can display PCI configuration space 0 ~ ff0.
In your side, lspci has the same behavior as driver that can't read 0x719.

The PCI EXT capabilities locate from 100h. Not sure if host controller driver
limits to display them? 

Ping-Ke