All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	Nathan Chancellor <nathan@kernel.org>,
	kernel test robot <lkp@intel.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] ARM: socfpga: fix missing RESET_CONTROLLER
Date: Mon, 7 Feb 2022 03:48:54 -0600	[thread overview]
Message-ID: <b4e83e9a-306c-ca80-e977-05bf23b91cfa@kernel.org> (raw)
In-Reply-To: <a655b739-f6f5-3e68-4e1a-4be76ebdaef5@canonical.com>



On 2/7/22 03:47, Krzysztof Kozlowski wrote:
> On 07/02/2022 10:45, Dinh Nguyen wrote:
>>
>>
>> On 2/7/22 02:44, Krzysztof Kozlowski wrote:
>>> The SocFPGA machine since commit b3ca9888f35f ("reset: socfpga: add an
>>> early reset driver for SoCFPGA") uses reset controller, so it should
>>> select RESET_CONTROLLER explicitly.  Selecting ARCH_HAS_RESET_CONTROLLER
>>> is not enough because it affects only default choice still allowing a
>>> non-buildable configuration:
>>>
>>>     /usr/bin/arm-linux-gnueabi-ld: arch/arm/mach-socfpga/socfpga.o: in function `socfpga_init_irq':
>>>     arch/arm/mach-socfpga/socfpga.c:56: undefined reference to `socfpga_reset_init'
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Cc: <stable@vger.kernel.org>
>>> Fixes: b3ca9888f35f ("reset: socfpga: add an early reset driver for SoCFPGA")
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>> ---
>>>    arch/arm/mach-socfpga/Kconfig | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig
>>> index 43ddec677c0b..594edf9bbea4 100644
>>> --- a/arch/arm/mach-socfpga/Kconfig
>>> +++ b/arch/arm/mach-socfpga/Kconfig
>>> @@ -2,6 +2,7 @@
>>>    menuconfig ARCH_INTEL_SOCFPGA
>>>    	bool "Altera SOCFPGA family"
>>>    	depends on ARCH_MULTI_V7
>>> +	select ARCH_HAS_RESET_CONTROLLER
>>>    	select ARCH_SUPPORTS_BIG_ENDIAN
>>>    	select ARM_AMBA
>>>    	select ARM_GIC
>>> @@ -18,6 +19,7 @@ menuconfig ARCH_INTEL_SOCFPGA
>>>    	select PL310_ERRATA_727915
>>>    	select PL310_ERRATA_753970 if PL310
>>>    	select PL310_ERRATA_769419
>>> +	select RESET_CONTROLLER
>>>    
>>>    if ARCH_INTEL_SOCFPGA
>>>    config SOCFPGA_SUSPEND
>>
>> Acked-By: Dinh Nguyen <dinguyen@kernel.org>
> 
> Hi Dinh,
> 
> I was expecting you will pick it up. If you only ack, who is going to
> take it? Shall I send it directly to soc@?
> 

Ok...I'll pick it up.

Dinh

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Dinh Nguyen <dinguyen@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	Nathan Chancellor <nathan@kernel.org>,
	kernel test robot <lkp@intel.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] ARM: socfpga: fix missing RESET_CONTROLLER
Date: Mon, 7 Feb 2022 03:48:54 -0600	[thread overview]
Message-ID: <b4e83e9a-306c-ca80-e977-05bf23b91cfa@kernel.org> (raw)
In-Reply-To: <a655b739-f6f5-3e68-4e1a-4be76ebdaef5@canonical.com>



On 2/7/22 03:47, Krzysztof Kozlowski wrote:
> On 07/02/2022 10:45, Dinh Nguyen wrote:
>>
>>
>> On 2/7/22 02:44, Krzysztof Kozlowski wrote:
>>> The SocFPGA machine since commit b3ca9888f35f ("reset: socfpga: add an
>>> early reset driver for SoCFPGA") uses reset controller, so it should
>>> select RESET_CONTROLLER explicitly.  Selecting ARCH_HAS_RESET_CONTROLLER
>>> is not enough because it affects only default choice still allowing a
>>> non-buildable configuration:
>>>
>>>     /usr/bin/arm-linux-gnueabi-ld: arch/arm/mach-socfpga/socfpga.o: in function `socfpga_init_irq':
>>>     arch/arm/mach-socfpga/socfpga.c:56: undefined reference to `socfpga_reset_init'
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Cc: <stable@vger.kernel.org>
>>> Fixes: b3ca9888f35f ("reset: socfpga: add an early reset driver for SoCFPGA")
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>> ---
>>>    arch/arm/mach-socfpga/Kconfig | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig
>>> index 43ddec677c0b..594edf9bbea4 100644
>>> --- a/arch/arm/mach-socfpga/Kconfig
>>> +++ b/arch/arm/mach-socfpga/Kconfig
>>> @@ -2,6 +2,7 @@
>>>    menuconfig ARCH_INTEL_SOCFPGA
>>>    	bool "Altera SOCFPGA family"
>>>    	depends on ARCH_MULTI_V7
>>> +	select ARCH_HAS_RESET_CONTROLLER
>>>    	select ARCH_SUPPORTS_BIG_ENDIAN
>>>    	select ARM_AMBA
>>>    	select ARM_GIC
>>> @@ -18,6 +19,7 @@ menuconfig ARCH_INTEL_SOCFPGA
>>>    	select PL310_ERRATA_727915
>>>    	select PL310_ERRATA_753970 if PL310
>>>    	select PL310_ERRATA_769419
>>> +	select RESET_CONTROLLER
>>>    
>>>    if ARCH_INTEL_SOCFPGA
>>>    config SOCFPGA_SUSPEND
>>
>> Acked-By: Dinh Nguyen <dinguyen@kernel.org>
> 
> Hi Dinh,
> 
> I was expecting you will pick it up. If you only ack, who is going to
> take it? Shall I send it directly to soc@?
> 

Ok...I'll pick it up.

Dinh

  reply	other threads:[~2022-02-07  9:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07  8:44 [PATCH] ARM: socfpga: fix missing RESET_CONTROLLER Krzysztof Kozlowski
2022-02-07  8:44 ` Krzysztof Kozlowski
2022-02-07  9:45 ` Dinh Nguyen
2022-02-07  9:45   ` Dinh Nguyen
2022-02-07  9:47   ` Krzysztof Kozlowski
2022-02-07  9:47     ` Krzysztof Kozlowski
2022-02-07  9:48     ` Dinh Nguyen [this message]
2022-02-07  9:48       ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4e83e9a-306c-ca80-e977-05bf23b91cfa@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=arnd@arndb.de \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=nathan@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.