All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chaoyi Chen <chaoyi.chen@rock-chips.com>,
	Chaoyi Chen <kernel@airkyi.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Quentin Schulz <quentin.schulz@cherry.de>,
	Jonas Karlman <jonas@kwiboo.se>, Hsun Lai <i@chainsx.cn>,
	John Clark <inindev@gmail.com>, Jimmy Hon <honyuenkwun@gmail.com>,
	Dragan Simic <dsimic@manjaro.org>,
	Michael Riesch <michael.riesch@collabora.com>,
	Peter Robinson <pbrobinson@gmail.com>,
	Alexey Charkov <alchark@gmail.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Andy Yan <andy.yan@rock-chips.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: usb: Add binding for WCH CH334/CH335 hub controller
Date: Mon, 12 Jan 2026 15:28:49 +0100	[thread overview]
Message-ID: <b4eb4ab6-6fde-4c01-8069-470545ffdac4@kernel.org> (raw)
In-Reply-To: <1515a445-576a-4833-a604-c31062f7d3fa@rock-chips.com>

On 12/01/2026 09:59, Chaoyi Chen wrote:
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    #include <dt-bindings/gpio/gpio.h>
>>> +    usb {
>>> +        dr_mode = "host";

One more thing - drop above line.

>>> +        #address-cells = <1>;
>>> +        #size-cells = <0>;
>>> +
>>> +        hub: hub@1 {
>>> +            compatible = "usb1a86,8091";
>>> +            reg = <1>;
>>> +            reset-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;
>>
>> Are you sure?
> 
> I guess what you're concerned about here is the polarity? 
> If that's the case, then there's no problem.

Yes, I was wondering whether polarity is set correctly.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chaoyi Chen <chaoyi.chen@rock-chips.com>,
	Chaoyi Chen <kernel@airkyi.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Quentin Schulz <quentin.schulz@cherry.de>,
	Jonas Karlman <jonas@kwiboo.se>, Hsun Lai <i@chainsx.cn>,
	John Clark <inindev@gmail.com>, Jimmy Hon <honyuenkwun@gmail.com>,
	Dragan Simic <dsimic@manjaro.org>,
	Michael Riesch <michael.riesch@collabora.com>,
	Peter Robinson <pbrobinson@gmail.com>,
	Alexey Charkov <alchark@gmail.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Andy Yan <andy.yan@rock-chips.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: usb: Add binding for WCH CH334/CH335 hub controller
Date: Mon, 12 Jan 2026 15:28:49 +0100	[thread overview]
Message-ID: <b4eb4ab6-6fde-4c01-8069-470545ffdac4@kernel.org> (raw)
In-Reply-To: <1515a445-576a-4833-a604-c31062f7d3fa@rock-chips.com>

On 12/01/2026 09:59, Chaoyi Chen wrote:
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> +  - |
>>> +    #include <dt-bindings/gpio/gpio.h>
>>> +    usb {
>>> +        dr_mode = "host";

One more thing - drop above line.

>>> +        #address-cells = <1>;
>>> +        #size-cells = <0>;
>>> +
>>> +        hub: hub@1 {
>>> +            compatible = "usb1a86,8091";
>>> +            reg = <1>;
>>> +            reset-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;
>>
>> Are you sure?
> 
> I guess what you're concerned about here is the polarity? 
> If that's the case, then there's no problem.

Yes, I was wondering whether polarity is set correctly.

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-01-12 14:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12  2:28 [PATCH v3 0/3] arm64: dts: rockchip: Add rk3576 evb2 board Chaoyi Chen
2026-01-12  2:28 ` Chaoyi Chen
2026-01-12  2:28 ` [PATCH v3 1/3] dt-bindings: usb: Add binding for WCH CH334/CH335 hub controller Chaoyi Chen
2026-01-12  2:28   ` Chaoyi Chen
2026-01-12  8:50   ` Krzysztof Kozlowski
2026-01-12  8:50     ` Krzysztof Kozlowski
2026-01-12  8:59     ` Chaoyi Chen
2026-01-12  8:59       ` Chaoyi Chen
2026-01-12 14:28       ` Krzysztof Kozlowski [this message]
2026-01-12 14:28         ` Krzysztof Kozlowski
2026-01-13  3:27         ` Chaoyi Chen
2026-01-13  3:27           ` Chaoyi Chen
2026-01-13  3:45           ` Chaoyi Chen
2026-01-13  3:45             ` Chaoyi Chen
2026-01-13  7:41           ` Krzysztof Kozlowski
2026-01-13  7:41             ` Krzysztof Kozlowski
2026-01-12 14:00   ` Quentin Schulz
2026-01-12 14:00     ` Quentin Schulz
2026-01-13  3:38     ` Chaoyi Chen
2026-01-13  3:38       ` Chaoyi Chen
2026-01-12  2:28 ` [PATCH v3 2/3] dt-bindings: arm: rockchip: Add rk3576 evb2 board Chaoyi Chen
2026-01-12  2:28   ` Chaoyi Chen
2026-01-12  2:28 ` [PATCH v3 3/3] arm64: dts: " Chaoyi Chen
2026-01-12  2:28   ` Chaoyi Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4eb4ab6-6fde-4c01-8069-470545ffdac4@kernel.org \
    --to=krzk@kernel.org \
    --cc=alchark@gmail.com \
    --cc=andy.yan@rock-chips.com \
    --cc=chaoyi.chen@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dsimic@manjaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=honyuenkwun@gmail.com \
    --cc=i@chainsx.cn \
    --cc=inindev@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel@airkyi.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michael.riesch@collabora.com \
    --cc=pbrobinson@gmail.com \
    --cc=quentin.schulz@cherry.de \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=shawn.lin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.