From: Matthias Brugger <matthias.bgg@gmail.com>
To: frank-w@public-files.de, linux-mediatek@lists.infradead.org,
Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Sean Wang" <sean.wang@mediatek.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
"Richard Fontana" <rfontana@redhat.com>,
"Mark Brown" <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"René van Dorst" <opensource@vdorst.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Eddie Huang" <eddie.huang@mediatek.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Kate Stewart" <kstewart@linuxfoundation.org>,
linux-rtc@vger.kernel.org
Subject: Re: [BUG] [PATCH v5 02/10] mfd: mt6397: extract irq related code from core driver
Date: Fri, 23 Aug 2019 17:42:05 +0200 [thread overview]
Message-ID: <b5a21908-faee-17d1-ce26-99b941c0fa70@gmail.com> (raw)
In-Reply-To: <0A87F427-2D81-412A-9549-09A51A021799@public-files.de>
On 23/08/2019 17:26, Frank Wunderlich wrote:
>
>
> Am 23. August 2019 16:56:13 MESZ schrieb Matthias Brugger <matthias.bgg@gmail.com>:
>> are you sure that you provide the correct chip_id here? I saw 0x2023
>> (if I
>> remember correctly), while this switch checks for 0x23, 0x91 and 0x97,
>> so I'm
>> not sure if the problem really lies here. I didn't dig into the code to
>> find out
>> how the chip_id is created.
>
> The chip-id 0x2023 is reported with 5.3-rc5, next-code says 0x0. So i guess the chipid is read out/calculated the wrong way. If calculation is not changed the read is changed compared to 5.3
>
I suppose that's because 3/10 has code that should be in 2/10 and for some
reason 3/10 was not pushed for linux-next inclusion. Although it has the same
Acked-for-mfd-by tag.
@Frank, can you test if adding 3/10 to your code base fixes the issue?
Regards,
Matthias
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: frank-w@public-files.de, linux-mediatek@lists.infradead.org,
Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Mark Brown" <broonie@kernel.org>,
"Sean Wang" <sean.wang@mediatek.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
"Richard Fontana" <rfontana@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Kate Stewart" <kstewart@linuxfoundation.org>,
"René van Dorst" <opensource@vdorst.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Eddie Huang" <eddie.huang@mediatek.com>,
"Lee Jones" <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org
Subject: Re: [BUG] [PATCH v5 02/10] mfd: mt6397: extract irq related code from core driver
Date: Fri, 23 Aug 2019 17:42:05 +0200 [thread overview]
Message-ID: <b5a21908-faee-17d1-ce26-99b941c0fa70@gmail.com> (raw)
In-Reply-To: <0A87F427-2D81-412A-9549-09A51A021799@public-files.de>
On 23/08/2019 17:26, Frank Wunderlich wrote:
>
>
> Am 23. August 2019 16:56:13 MESZ schrieb Matthias Brugger <matthias.bgg@gmail.com>:
>> are you sure that you provide the correct chip_id here? I saw 0x2023
>> (if I
>> remember correctly), while this switch checks for 0x23, 0x91 and 0x97,
>> so I'm
>> not sure if the problem really lies here. I didn't dig into the code to
>> find out
>> how the chip_id is created.
>
> The chip-id 0x2023 is reported with 5.3-rc5, next-code says 0x0. So i guess the chipid is read out/calculated the wrong way. If calculation is not changed the read is changed compared to 5.3
>
I suppose that's because 3/10 has code that should be in 2/10 and for some
reason 3/10 was not pushed for linux-next inclusion. Although it has the same
Acked-for-mfd-by tag.
@Frank, can you test if adding 3/10 to your code base fixes the issue?
Regards,
Matthias
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-23 15:42 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 3:45 [PATCH v5 00/10] Add Support for MediaTek PMIC MT6358 Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` [PATCH v5 01/10] mfd: mt6397: clean up code Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` [PATCH v5 02/10] mfd: mt6397: extract irq related code from core driver Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 12:13 ` [BUG] " Frank Wunderlich
2019-08-23 12:13 ` Frank Wunderlich
2019-08-23 12:13 ` Frank Wunderlich
2019-08-23 14:56 ` Matthias Brugger
2019-08-23 14:56 ` Matthias Brugger
2019-08-23 15:26 ` Frank Wunderlich
2019-08-23 15:26 ` Frank Wunderlich
2019-08-23 15:26 ` Frank Wunderlich
2019-08-23 15:42 ` Matthias Brugger [this message]
2019-08-23 15:42 ` Matthias Brugger
[not found] ` <b5a21908-faee-17d1-ce26-99b941c0fa70-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-08-23 17:16 ` Aw: " Frank Wunderlich
2019-08-23 17:16 ` Frank Wunderlich
2019-08-23 17:16 ` Frank Wunderlich
2019-08-29 6:24 ` Hsin-hsiung Wang
2019-08-29 6:24 ` Hsin-hsiung Wang
2019-08-29 6:24 ` Hsin-hsiung Wang
2019-09-19 18:59 ` Frank Wunderlich
2019-09-19 18:59 ` Frank Wunderlich
2019-09-30 19:44 ` Aw: " Frank Wunderlich
2019-09-30 19:44 ` Frank Wunderlich
2019-09-30 19:44 ` Frank Wunderlich
2019-08-24 7:04 ` Frank Wunderlich
[not found] ` <725410A8-8B5B-472A-8904-57B912475783-SipyoOjXbOMoAHOVJHB0wA@public.gmane.org>
2019-08-24 9:16 ` Frank Wunderlich
2019-08-23 15:35 ` Frank Wunderlich
2019-08-23 15:35 ` Frank Wunderlich
2019-08-23 15:35 ` Frank Wunderlich
2019-08-23 15:53 ` Frank Wunderlich
2019-08-23 15:53 ` Frank Wunderlich
2019-08-23 14:53 ` Matthias Brugger
2019-08-23 14:53 ` Matthias Brugger
2019-08-23 3:45 ` [PATCH v5 03/10] mfd: mt6397: modify suspend/resume behavior Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 15:12 ` Matthias Brugger
2019-08-23 15:12 ` Matthias Brugger
2019-08-23 3:45 ` [PATCH v5 04/10] dt-bindings: mfd: Add compatible for the MediaTek MT6358 PMIC Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` [PATCH v5 05/10] regulator: Add document for MT6358 regulator Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-28 10:44 ` Mark Brown
2019-08-28 10:44 ` Mark Brown
2019-08-28 13:13 ` Applied "regulator: Add document for MT6358 regulator" to the regulator tree Mark Brown
2019-08-28 13:13 ` Mark Brown
2019-08-28 13:13 ` Mark Brown
2019-08-23 3:45 ` [PATCH v5 06/10] mfd: Add support for the MediaTek MT6358 PMIC Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-12-02 8:06 ` Pi-Hsun Shih
2019-12-02 8:06 ` Pi-Hsun Shih
2019-12-02 8:06 ` Pi-Hsun Shih
2019-12-06 8:55 ` Hsin-hsiung Wang
2019-12-06 8:55 ` Hsin-hsiung Wang
2019-12-06 8:55 ` Hsin-hsiung Wang
2019-08-23 3:45 ` [PATCH v5 07/10] regulator: mt6358: Add support for MT6358 regulator Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-28 10:45 ` Mark Brown
2019-08-28 10:45 ` Mark Brown
2019-08-29 6:09 ` Hsin-hsiung Wang
2019-08-29 6:09 ` Hsin-hsiung Wang
2019-08-29 6:09 ` Hsin-hsiung Wang
2019-08-28 13:13 ` Applied "regulator: mt6358: Add support for MT6358 regulator" to the regulator tree Mark Brown
2019-08-28 13:13 ` Mark Brown
2019-08-28 13:13 ` Mark Brown
2019-08-23 3:45 ` [PATCH v5 08/10] arm64: dts: mt6358: add PMIC MT6358 related nodes Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` [PATCH v5 09/10] rtc: mt6397: fix alarm register overwrite Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 15:35 ` Matthias Brugger
2019-08-23 15:35 ` Matthias Brugger
2019-08-29 5:34 ` Hsin-hsiung Wang
2019-08-29 5:34 ` Hsin-hsiung Wang
2019-08-29 5:34 ` Hsin-hsiung Wang
[not found] ` <1566531931-9772-1-git-send-email-hsin-hsiung.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-08-23 3:45 ` [PATCH v5 10/10] rtc: mt6397: Add support for the MediaTek MT6358 RTC Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
2019-08-23 3:45 ` Hsin-Hsiung Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5a21908-faee-17d1-ce26-99b941c0fa70@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=frank-w@public-files.de \
--cc=gregkh@linuxfoundation.org \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=kstewart@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=opensource@vdorst.com \
--cc=rfontana@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.