From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Michal Orzel" <michal.orzel@amd.com>,
"Oleksii Kurochko" <oleksii.kurochko@gmail.com>,
"Shawn Anastasio" <sanastasio@raptorengineering.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 3/4] xen: Centralise the declaration of dump_execution_state()
Date: Mon, 10 Feb 2025 10:25:12 +0100 [thread overview]
Message-ID: <b62763a2-899b-4d4d-9c9c-64a2698714e2@suse.com> (raw)
In-Reply-To: <20250208000256.431883-4-andrew.cooper3@citrix.com>
On 08.02.2025 01:02, Andrew Cooper wrote:
> Three architectures have an identical dump_execution_state(), and PPC has a
> stub for show_execution_state() that just isn't wired up yet.
>
> show_execution_state() is declared in a common header, meaning that
> dump_execution_state() really ought to be too. Move them both into xen/bug.h
> as they're tightly tied to run_in_exception_handler().
Hmm, show_execution_state() certainly has wider use than just with
run_in_exception_handler(). I don't think kernel.h was a great home for its
decl, but I'm thinking the same of bug.h. Nevertheless (not the least short
of having any better suggestion) ...
> Drop the include of
> xen/kernel.h from ubsan.c which was required reviously for RISC-V to compile.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Jan
next prev parent reply other threads:[~2025-02-10 9:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 0:02 [PATCH 0/4] Other fixes from UBSAN enablement Andrew Cooper
2025-02-08 0:02 ` [PATCH for-4.20? 1/4] ARM32/traps: Fix do_trap_undefined_instruction()'s detection of kernel text Andrew Cooper
2025-02-10 10:13 ` Orzel, Michal
2025-02-10 22:31 ` Andrew Cooper
2025-02-10 21:23 ` Julien Grall
2025-02-10 22:23 ` Andrew Cooper
2025-02-11 10:05 ` Julien Grall
2025-02-08 0:02 ` [PATCH 2/4] ARM: Fix register constraints in run_in_exception_handler() Andrew Cooper
2025-02-10 9:21 ` Oleksii Kurochko
2025-02-10 21:31 ` Julien Grall
2025-02-10 22:41 ` Andrew Cooper
2025-02-12 22:59 ` Julien Grall
2025-02-10 10:33 ` Orzel, Michal
2025-02-10 21:29 ` Julien Grall
2025-02-10 22:10 ` Andrew Cooper
2025-02-08 0:02 ` [PATCH 3/4] xen: Centralise the declaration of dump_execution_state() Andrew Cooper
2025-02-10 9:23 ` Oleksii Kurochko
2025-02-10 9:25 ` Jan Beulich [this message]
2025-02-08 0:02 ` [PATCH 4/4] [BROKEN] PPC: Activate UBSAN in testing Andrew Cooper
2025-02-21 19:49 ` Shawn Anastasio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b62763a2-899b-4d4d-9c9c-64a2698714e2@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sanastasio@raptorengineering.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.