From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien@xen.org>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Michal Orzel <michal.orzel@amd.com>
Subject: Re: [PATCH 2/4] ARM: Fix register constraints in run_in_exception_handler()
Date: Mon, 10 Feb 2025 22:41:52 +0000 [thread overview]
Message-ID: <ea51509b-034b-4fa8-8a3f-8304a2bc48f3@citrix.com> (raw)
In-Reply-To: <c93ad2d7-6ac2-4a5b-b6d8-07459a2884b6@xen.org>
On 10/02/2025 9:31 pm, Julien Grall wrote:
>
>
> On 10/02/2025 09:21, Oleksii Kurochko wrote:
>>
>> On 2/8/25 1:02 AM, Andrew Cooper wrote:
>>> Right now, run_in_exception_handler() takes an input in an arbitrary
>>> register,
>>> and clobbers BUG_FN_REG. This causes the compiler to calculate fn
>>> in the
>>> wrong regsiter.
>>
>> Probably, we should give a chance for the patch which suggests to use
>> GENERIC_BUG_FRAME:
>> https://lore.kernel.org/xen-
>> devel/8fdb98350ae4fc6029738d0aabe13a57e1945a50.1680086655.git.oleksii.kurochko@gmail.com/
>
> That would be the ideal if someone has time for it. Otherwise, patch
> #3 needs to be modified (see my answer on patch #2).
>
> But I would also be ok with this as a stop-gap for the time being.
Getting ARM onto GENERIC_BUG_FRAME would definitely be best all around,
but that is an almost-2-year-old patch with an open "it doesn't compile
on ARM32" issue.
I presume that all which is wanted is *a* solution that compiles (and
works) everywhere we support?
~Andrew
next prev parent reply other threads:[~2025-02-10 22:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 0:02 [PATCH 0/4] Other fixes from UBSAN enablement Andrew Cooper
2025-02-08 0:02 ` [PATCH for-4.20? 1/4] ARM32/traps: Fix do_trap_undefined_instruction()'s detection of kernel text Andrew Cooper
2025-02-10 10:13 ` Orzel, Michal
2025-02-10 22:31 ` Andrew Cooper
2025-02-10 21:23 ` Julien Grall
2025-02-10 22:23 ` Andrew Cooper
2025-02-11 10:05 ` Julien Grall
2025-02-08 0:02 ` [PATCH 2/4] ARM: Fix register constraints in run_in_exception_handler() Andrew Cooper
2025-02-10 9:21 ` Oleksii Kurochko
2025-02-10 21:31 ` Julien Grall
2025-02-10 22:41 ` Andrew Cooper [this message]
2025-02-12 22:59 ` Julien Grall
2025-02-10 10:33 ` Orzel, Michal
2025-02-10 21:29 ` Julien Grall
2025-02-10 22:10 ` Andrew Cooper
2025-02-08 0:02 ` [PATCH 3/4] xen: Centralise the declaration of dump_execution_state() Andrew Cooper
2025-02-10 9:23 ` Oleksii Kurochko
2025-02-10 9:25 ` Jan Beulich
2025-02-08 0:02 ` [PATCH 4/4] [BROKEN] PPC: Activate UBSAN in testing Andrew Cooper
2025-02-21 19:49 ` Shawn Anastasio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea51509b-034b-4fa8-8a3f-8304a2bc48f3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.