From: ZhangGuoDong <zhang.guodong@linux.dev>
To: Namjae Jeon <linkinjeon@kernel.org>, smfrench@gmail.com
Cc: chenxiaosong@kylinos.cn, linux-cifs@vger.kernel.org
Subject: Re: [PATCH v3 0/5] smb: move duplicate definitions into common header file, part 2
Date: Wed, 25 Feb 2026 11:14:18 +0800 [thread overview]
Message-ID: <b654ba09-e96a-4e8a-becb-6c30c38f325d@linux.dev> (raw)
In-Reply-To: <CAKYAXd_MuUe9R4vnkmGEkWxG7endJFqGDiEprLcvgJDixakX2A@mail.gmail.com>
For patches 0005, struct `smb311_posix_qinfo` and `smb2_posix_info`
cannot use flexible array member for SID buffers. So we can only move
fixed (non-variable) part of the structures to the common header file.
We should extract and move the fixed (non-variable) part to the common
header file, since it is defined three times which makes it hard to
maintain.
Link:
https://gitlab.com/samba-team/smb3-posix-spec/-/blob/master/fscc_posix_extensions.md#2311-fileposixinformation
struct smb311_posix_qinfo / smb2_posix_info {
fixed (non-variable) part
variable sized owner SID and group SID
le32 filenamelength
u8 filename[] // variable
};
On 2026/2/20 09:27, Namjae Jeon wrote:
> For patches 0004 and 0005, please move the complete definition to the
> common header instead of a partial split. So we should also use a
> flexible array member for this, and ensure that all related code is
> updated to handle the flexible array correctly.
> Thanks.
prev parent reply other threads:[~2026-02-25 3:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 8:20 [PATCH v3 0/5] smb: move duplicate definitions into common header file, part 2 zhang.guodong
2026-02-16 8:20 ` [PATCH v3 1/5] smb: move smb3_fs_vol_info into common/fscc.h zhang.guodong
2026-02-16 16:05 ` kernel test robot
2026-02-16 8:20 ` [PATCH v3 2/5] smb: move some definitions from common/smb2pdu.h " zhang.guodong
2026-02-16 8:20 ` [PATCH v3 3/5] smb: move file_basic_info " zhang.guodong
2026-02-16 8:20 ` [PATCH v3 4/5] smb: introduce struct create_posix_ctxt_rsp zhang.guodong
2026-02-16 18:22 ` kernel test robot
2026-02-17 14:20 ` ZhangGuoDong
[not found] ` <CAH2r5muK5WrHkJsJ=Rix7ceFFZNzpQkUZSaSsHi8PMXVpw88pw@mail.gmail.com>
[not found] ` <b840459a-8a31-46e7-817a-3b80e9ed1353@linux.dev>
[not found] ` <CAH2r5muScb7NmeJa1BNwAt8Qzb7WmwVfvskZ=9LEV6WWyO5HyQ@mail.gmail.com>
[not found] ` <d6149e9f-9607-4379-a74d-c4bbe12fef00@linux.dev>
2026-02-19 8:16 ` ChenXiaoSong
2026-02-19 13:14 ` ChenXiaoSong
2026-02-16 8:20 ` [PATCH v3 5/5] smb: introduce struct file_posix_info zhang.guodong
2026-02-20 1:27 ` [PATCH v3 0/5] smb: move duplicate definitions into common header file, part 2 Namjae Jeon
2026-02-20 10:54 ` ZhangGuoDong
2026-02-22 7:39 ` ChenXiaoSong
2026-02-22 15:26 ` ChenXiaoSong
2026-02-22 15:42 ` ChenXiaoSong
2026-02-25 3:14 ` ZhangGuoDong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b654ba09-e96a-4e8a-becb-6c30c38f325d@linux.dev \
--to=zhang.guodong@linux.dev \
--cc=chenxiaosong@kylinos.cn \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.