Re: [PATCH v3 4/5] smb: introduce struct create_posix_ctxt_rsp

[ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev>]

Hi GuoDong,

The changes to patch 04 should be as follows:

--- a/fs/smb/client/smb2pdu.c
+++ b/fs/smb/client/smb2pdu.c
@@ -2362,9 +2362,9 @@ parse_posix_ctxt(struct create_context *cc, struct
-       posix->ctxt_rsp.nlink = le32_to_cpu(*(__le32 *)(beg + 0));
-       posix->ctxt_rsp.reparse_tag = le32_to_cpu(*(__le32 *)(beg + 4));
-       posix->ctxt_rsp.mode = le32_to_cpu(*(__le32 *)(beg + 8));
+       posix->ctxt_rsp.nlink = *(__le32 *)(beg + 0);
+       posix->ctxt_rsp.reparse_tag = *(__le32 *)(beg + 4);
+       posix->ctxt_rsp.mode = *(__le32 *)(beg + 8);

Thanks,
ChenXiaoSong <chenxiaosong@kylinos.cn>

On 2026/2/19 16:16, ChenXiaoSong wrote:
> The changes in parse_posix_ctxt() seem to be fixing a bug. Perhaps we 
> should submit it as a separate bugfix patch (add Reported-by: kernel 
> test robot).
> 
> Steve, what do you think?
> 
> Thanks,
> ChenXiaoSong <chenxiaosong@kylinos.cn>
> 
> On 2026/2/19 15:19, ZhangGuoDong wrote:
>> I can now see these warnings. We should make the following changes, 
>> what do you think?
>>
>> --- a/fs/smb/client/cifsglob.h
>> +++ b/fs/smb/client/cifsglob.h
>> @@ -1270,7 +1270,7 @@ struct cifs_tcon {
>> -       __u32 vol_serial_number;
>> +       __le32 vol_serial_number;
>>
>> --- a/fs/smb/client/smb2pdu.c
>> +++ b/fs/smb/client/smb2pdu.c
>> @@ -2362,9 +2362,9 @@ parse_posix_ctxt(struct create_context *cc, 
>> struct smb2_file_all_info *info,
>> -       posix->ctxt_rsp.nlink = le32_to_cpu(*(__le32 *)(beg + 0));
>> -       posix->ctxt_rsp.reparse_tag = le32_to_cpu(*(__le32 *)(beg + 4));
>> -       posix->ctxt_rsp.mode = le32_to_cpu(*(__le32 *)(beg + 8));
>> +       posix->ctxt_rsp.nlink = cpu_to_le32(*(u32 *)(beg + 0));
>> +       posix->ctxt_rsp.reparse_tag = cpu_to_le32(*(u32 *)(beg + 4));
>> +       posix->ctxt_rsp.mode = cpu_to_le32(*(u32 *)(beg + 8));