* [PATCH] drm/bridge: refcount last_bridge in drm_atomic_bridge_chain_select_bus_fmts()
@ 2025-09-24 15:11 Luca Ceresoli
2025-09-25 11:43 ` Maxime Ripard
2025-10-03 7:11 ` Luca Ceresoli
0 siblings, 2 replies; 3+ messages in thread
From: Luca Ceresoli @ 2025-09-24 15:11 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: Hui Pu, Thomas Petazzoni, dri-devel, linux-kernel, Luca Ceresoli
Get a reference for the last_bridge when it is obtained and release it
using a cleanup action.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
drivers/gpu/drm/drm_bridge.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index 630b5e6594e0affad9ba48791207c7b403da5db8..53e7ece36dd940aabd1c0880f296fce7224a12ac 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -1086,12 +1086,12 @@ drm_atomic_bridge_chain_select_bus_fmts(struct drm_bridge *bridge,
struct drm_encoder *encoder = bridge->encoder;
struct drm_bridge_state *last_bridge_state;
unsigned int i, num_out_bus_fmts = 0;
- struct drm_bridge *last_bridge;
u32 *out_bus_fmts;
int ret = 0;
- last_bridge = list_last_entry(&encoder->bridge_chain,
- struct drm_bridge, chain_node);
+ struct drm_bridge *last_bridge __free(drm_bridge_put) =
+ drm_bridge_get(list_last_entry(&encoder->bridge_chain,
+ struct drm_bridge, chain_node));
last_bridge_state = drm_atomic_get_new_bridge_state(crtc_state->state,
last_bridge);
---
base-commit: 90315cd293f321ada7bbd43a59636716e102d68a
change-id: 20250924-b4-drm-bridge-alloc-getput-drm_atomic_bridge_chain_select_bus_fmts-8e3b6004cbe2
Best regards,
--
Luca Ceresoli <luca.ceresoli@bootlin.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: refcount last_bridge in drm_atomic_bridge_chain_select_bus_fmts()
2025-09-24 15:11 [PATCH] drm/bridge: refcount last_bridge in drm_atomic_bridge_chain_select_bus_fmts() Luca Ceresoli
@ 2025-09-25 11:43 ` Maxime Ripard
2025-10-03 7:11 ` Luca Ceresoli
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2025-09-25 11:43 UTC (permalink / raw)
To: Luca Ceresoli
Cc: dri-devel, linux-kernel, Andrzej Hajda, David Airlie, Hui Pu,
Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
Maarten Lankhorst, Maxime Ripard, Neil Armstrong, Robert Foss,
Simona Vetter, Thomas Petazzoni, Thomas Zimmermann
On Wed, 24 Sep 2025 17:11:01 +0200, Luca Ceresoli wrote:
> Get a reference for the last_bridge when it is obtained and release it
> using a cleanup action.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: refcount last_bridge in drm_atomic_bridge_chain_select_bus_fmts()
2025-09-24 15:11 [PATCH] drm/bridge: refcount last_bridge in drm_atomic_bridge_chain_select_bus_fmts() Luca Ceresoli
2025-09-25 11:43 ` Maxime Ripard
@ 2025-10-03 7:11 ` Luca Ceresoli
1 sibling, 0 replies; 3+ messages in thread
From: Luca Ceresoli @ 2025-10-03 7:11 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Luca Ceresoli
Cc: Hui Pu, Thomas Petazzoni, dri-devel, linux-kernel
On Wed, 24 Sep 2025 17:11:01 +0200, Luca Ceresoli wrote:
> Get a reference for the last_bridge when it is obtained and release it
> using a cleanup action.
>
>
Applied, thanks!
[1/1] drm/bridge: refcount last_bridge in drm_atomic_bridge_chain_select_bus_fmts()
commit: 0f2efbe6d8305b91c9b2c92ebaf8c24a614bc305
Best regards,
--
Luca Ceresoli <luca.ceresoli@bootlin.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-03 7:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-24 15:11 [PATCH] drm/bridge: refcount last_bridge in drm_atomic_bridge_chain_select_bus_fmts() Luca Ceresoli
2025-09-25 11:43 ` Maxime Ripard
2025-10-03 7:11 ` Luca Ceresoli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.