* [PATCH] soc: ti: smartreflex: void function return statements are not generally useful [not found] <20230707133447.28102-1-panzhiai@cdjrlc.com> @ 2023-07-07 13:38 ` hexingwei001 2023-07-07 14:24 ` hexingwei001 1 sibling, 0 replies; 4+ messages in thread From: hexingwei001 @ 2023-07-07 13:38 UTC (permalink / raw) To: nm, ssantosh; +Cc: linux-kernel, linux-arm-kernel, linux-pm void function omap_sr_shutdown return statements are not generally useful, so deleted the return in function omap_sr_shutdown(). Signed-off-by: Xingwei He <hexingwei001@208suo.com> --- drivers/soc/ti/smartreflex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c index 62b2f1464e46..20abfb0b8f26 100644 --- a/drivers/soc/ti/smartreflex.c +++ b/drivers/soc/ti/smartreflex.c @@ -955,7 +955,7 @@ static void omap_sr_shutdown(struct platform_device *pdev) if (sr_info->autocomp_active) sr_stop_vddautocomp(sr_info); - return; + } static const struct of_device_id omap_sr_match[] = { ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] soc: ti: smartreflex: void function return statements are not generally useful @ 2023-07-07 13:38 ` hexingwei001 0 siblings, 0 replies; 4+ messages in thread From: hexingwei001 @ 2023-07-07 13:38 UTC (permalink / raw) To: nm, ssantosh; +Cc: linux-kernel, linux-arm-kernel, linux-pm void function omap_sr_shutdown return statements are not generally useful, so deleted the return in function omap_sr_shutdown(). Signed-off-by: Xingwei He <hexingwei001@208suo.com> --- drivers/soc/ti/smartreflex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c index 62b2f1464e46..20abfb0b8f26 100644 --- a/drivers/soc/ti/smartreflex.c +++ b/drivers/soc/ti/smartreflex.c @@ -955,7 +955,7 @@ static void omap_sr_shutdown(struct platform_device *pdev) if (sr_info->autocomp_active) sr_stop_vddautocomp(sr_info); - return; + } static const struct of_device_id omap_sr_match[] = { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] soc: ti: smartreflex: void function return statements are not generally useful [not found] <20230707133447.28102-1-panzhiai@cdjrlc.com> 2023-07-07 13:38 ` hexingwei001 @ 2023-07-07 14:24 ` hexingwei001 2023-07-07 14:54 ` Dan Carpenter 1 sibling, 1 reply; 4+ messages in thread From: hexingwei001 @ 2023-07-07 14:24 UTC (permalink / raw) To: hdegoede, mchehab Cc: linux-staging, linux-kernel, colin.i.king, gregkh, sakari.ailus void function omap_sr_shutdown return statements are not generally useful, so deleted the return in function omap_sr_shutdown(). Signed-off-by: Xingwei He <hexingwei001@208suo.com> --- drivers/soc/ti/smartreflex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c index 62b2f1464e46..20abfb0b8f26 100644 --- a/drivers/soc/ti/smartreflex.c +++ b/drivers/soc/ti/smartreflex.c @@ -955,7 +955,7 @@ static void omap_sr_shutdown(struct platform_device *pdev) if (sr_info->autocomp_active) sr_stop_vddautocomp(sr_info); - return; + } static const struct of_device_id omap_sr_match[] = { ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: ti: smartreflex: void function return statements are not generally useful 2023-07-07 14:24 ` hexingwei001 @ 2023-07-07 14:54 ` Dan Carpenter 0 siblings, 0 replies; 4+ messages in thread From: Dan Carpenter @ 2023-07-07 14:54 UTC (permalink / raw) To: hexingwei001 Cc: hdegoede, mchehab, linux-staging, linux-kernel, colin.i.king, gregkh, sakari.ailus No need to CC linux-staging@lists.linux.dev. Use scripts/get_maintainer.pl to find the appropriate lists. Your From header doesn't have your name, just your email address. The subject is too long. Change it to: [PATCH] soc: ti: smartreflex: Remove unnecessary return statement The patch is corrupted. Take a look at Documentation/process/email-clients.rst. Send an email to yourself first to verify it applies. > diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c > index 62b2f1464e46..20abfb0b8f26 100644 > --- a/drivers/soc/ti/smartreflex.c > +++ b/drivers/soc/ti/smartreflex.c > @@ -955,7 +955,7 @@ static void omap_sr_shutdown(struct platform_device > *pdev) > if (sr_info->autocomp_active) > sr_stop_vddautocomp(sr_info); > > - return; > + This introduces two blank lines in a row which is a style violation. In fact, there should be no blank lines before the last } closing brace in a function so delete the other blank line as well. > } regards, dan carpenter ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-07 14:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230707133447.28102-1-panzhiai@cdjrlc.com>
2023-07-07 13:38 ` [PATCH] soc: ti: smartreflex: void function return statements are not generally useful hexingwei001
2023-07-07 13:38 ` hexingwei001
2023-07-07 14:24 ` hexingwei001
2023-07-07 14:54 ` Dan Carpenter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.