All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
	kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org,
	kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	pbonzini@redhat.com, tsbogend@alpha.franken.de,
	paulus@ozlabs.org, mpe@ellerman.id.au, benh@kernel.crashing.org,
	borntraeger@de.ibm.com, frankja@linux.ibm.com, david@redhat.com,
	cohuck@redhat.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com,
	sean.j.christopherson@intel.com, wanpengli@tencent.com,
	jmattson@google.com, joro@8bytes.org, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
	james.morse@arm.com, julien.thierry.kdev@gmail.com,
	suzuki.poulose@arm.com, christoffer.dall@arm.com,
	peterx@redhat.com, thuth@redhat.com
Subject: Re: [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function
Date: Thu, 16 Apr 2020 08:58:45 +0000	[thread overview]
Message-ID: <b700f9bde1218b217ca4e571b1d29c1e@kernel.org> (raw)
In-Reply-To: <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com>

On 2020-04-16 09:45, Tianjia Zhang wrote:
> On 2020/4/16 16:28, Marc Zyngier wrote:

[...]

>> Overall, there is a large set of cleanups to be done when both the 
>> vcpu and the run
>> structures are passed as parameters at the same time. Just grepping 
>> the tree for
>> kvm_run is pretty instructive.
>> 
>>          M.
> 
> Sorry, it's my mistake, I only compiled the x86 platform, I will
> submit patch again.

Not a mistake. All I'm saying is that there is an opportunity for a 
larger
series that cleans up the code base, rather than just doing a couple of
localized changes.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: wanpengli@tencent.com, kvm@vger.kernel.org, david@redhat.com,
	benh@kernel.crashing.org, heiko.carstens@de.ibm.com,
	linux-kernel@vger.kernel.org, paulus@ozlabs.org, hpa@zytor.com,
	kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org,
	frankja@linux.ibm.com, mpe@ellerman.id.au, joro@8bytes.org,
	x86@kernel.org, borntraeger@de.ibm.com, mingo@redhat.com,
	thuth@redhat.com, gor@linux.ibm.com, kvm-ppc@vger.kernel.org,
	bp@alien8.de, tglx@linutronix.de,
	linux-arm-kernel@lists.infradead.org, jmattson@google.com,
	tsbogend@alpha.franken.de, cohuck@redhat.com,
	linux-mips@vger.kernel.org, sean.j.christopherson@intel.com,
	pbonzini@redhat.com, Vitaly Kuznetsov <vkuznets@redhat.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function
Date: Thu, 16 Apr 2020 09:58:45 +0100	[thread overview]
Message-ID: <b700f9bde1218b217ca4e571b1d29c1e@kernel.org> (raw)
In-Reply-To: <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com>

On 2020-04-16 09:45, Tianjia Zhang wrote:
> On 2020/4/16 16:28, Marc Zyngier wrote:

[...]

>> Overall, there is a large set of cleanups to be done when both the 
>> vcpu and the run
>> structures are passed as parameters at the same time. Just grepping 
>> the tree for
>> kvm_run is pretty instructive.
>> 
>>          M.
> 
> Sorry, it's my mistake, I only compiled the x86 platform, I will
> submit patch again.

Not a mistake. All I'm saying is that there is an opportunity for a 
larger
series that cleans up the code base, rather than just doing a couple of
localized changes.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
	kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org,
	kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	pbonzini@redhat.com, tsbogend@alpha.franken.de,
	paulus@ozlabs.org, mpe@ellerman.id.au, benh@kernel.crashing.org,
	borntraeger@de.ibm.com, frankja@linux.ibm.com, david@redhat.com,
	cohuck@redhat.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com,
	sean.j.christopherson@intel.com, wanpengli@tencent.com,
	jmattson@google.com, joro@8bytes.org, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
	james.morse@arm.com, julien.thierry.kdev@gmail.com,
	suzuki.poulose@arm.com, christoffer.dall@arm.com,
	peterx@redhat.com, thuth@redhat.com
Subject: Re: [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function
Date: Thu, 16 Apr 2020 09:58:45 +0100	[thread overview]
Message-ID: <b700f9bde1218b217ca4e571b1d29c1e@kernel.org> (raw)
In-Reply-To: <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com>

On 2020-04-16 09:45, Tianjia Zhang wrote:
> On 2020/4/16 16:28, Marc Zyngier wrote:

[...]

>> Overall, there is a large set of cleanups to be done when both the 
>> vcpu and the run
>> structures are passed as parameters at the same time. Just grepping 
>> the tree for
>> kvm_run is pretty instructive.
>> 
>>          M.
> 
> Sorry, it's my mistake, I only compiled the x86 platform, I will
> submit patch again.

Not a mistake. All I'm saying is that there is an opportunity for a 
larger
series that cleans up the code base, rather than just doing a couple of
localized changes.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: christoffer.dall@arm.com, wanpengli@tencent.com,
	kvm@vger.kernel.org, david@redhat.com, heiko.carstens@de.ibm.com,
	peterx@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
	kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org,
	frankja@linux.ibm.com, joro@8bytes.org, x86@kernel.org,
	borntraeger@de.ibm.com, mingo@redhat.com,
	julien.thierry.kdev@gmail.com, thuth@redhat.com,
	gor@linux.ibm.com, suzuki.poulose@arm.com,
	kvm-ppc@vger.kernel.org, bp@alien8.de, tglx@linutronix.de,
	linux-arm-kernel@lists.infradead.org, jmattson@google.com,
	tsbogend@alpha.franken.de, cohuck@redhat.com,
	linux-mips@vger.kernel.org, sean.j.christopherson@intel.com,
	james.morse@arm.com, pbonzini@redhat.com,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function
Date: Thu, 16 Apr 2020 09:58:45 +0100	[thread overview]
Message-ID: <b700f9bde1218b217ca4e571b1d29c1e@kernel.org> (raw)
In-Reply-To: <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com>

On 2020-04-16 09:45, Tianjia Zhang wrote:
> On 2020/4/16 16:28, Marc Zyngier wrote:

[...]

>> Overall, there is a large set of cleanups to be done when both the 
>> vcpu and the run
>> structures are passed as parameters at the same time. Just grepping 
>> the tree for
>> kvm_run is pretty instructive.
>> 
>>          M.
> 
> Sorry, it's my mistake, I only compiled the x86 platform, I will
> submit patch again.

Not a mistake. All I'm saying is that there is an opportunity for a 
larger
series that cleans up the code base, rather than just doing a couple of
localized changes.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: christoffer.dall@arm.com, wanpengli@tencent.com,
	kvm@vger.kernel.org, david@redhat.com, benh@kernel.crashing.org,
	heiko.carstens@de.ibm.com, peterx@redhat.com,
	linux-kernel@vger.kernel.org, paulus@ozlabs.org, hpa@zytor.com,
	kvmarm@lists.cs.columbia.edu, linux-s390@vger.kernel.org,
	frankja@linux.ibm.com, mpe@ellerman.id.au, joro@8bytes.org,
	x86@kernel.org, borntraeger@de.ibm.com, mingo@redhat.com,
	julien.thierry.kdev@gmail.com, thuth@redhat.com,
	gor@linux.ibm.com, suzuki.poulose@arm.com,
	kvm-ppc@vger.kernel.org, bp@alien8.de, tglx@linutronix.de,
	linux-arm-kernel@lists.infradead.org, jmattson@google.com,
	tsbogend@alpha.franken.de, cohuck@redhat.com,
	linux-mips@vger.kernel.org, sean.j.christopherson@intel.com,
	james.morse@arm.com, pbonzini@redhat.com,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function
Date: Thu, 16 Apr 2020 09:58:45 +0100	[thread overview]
Message-ID: <b700f9bde1218b217ca4e571b1d29c1e@kernel.org> (raw)
In-Reply-To: <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com>

On 2020-04-16 09:45, Tianjia Zhang wrote:
> On 2020/4/16 16:28, Marc Zyngier wrote:

[...]

>> Overall, there is a large set of cleanups to be done when both the 
>> vcpu and the run
>> structures are passed as parameters at the same time. Just grepping 
>> the tree for
>> kvm_run is pretty instructive.
>> 
>>          M.
> 
> Sorry, it's my mistake, I only compiled the x86 platform, I will
> submit patch again.

Not a mistake. All I'm saying is that there is an opportunity for a 
larger
series that cleans up the code base, rather than just doing a couple of
localized changes.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-04-16  8:58 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16  5:10 [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function Tianjia Zhang
2020-04-16  5:10 ` Tianjia Zhang
2020-04-16  5:10 ` Tianjia Zhang
2020-04-16  5:10 ` Tianjia Zhang
2020-04-16  5:10 ` Tianjia Zhang
2020-04-16  7:03 ` Vitaly Kuznetsov
2020-04-16  7:03   ` Vitaly Kuznetsov
2020-04-16  7:03   ` Vitaly Kuznetsov
2020-04-16  7:03   ` Vitaly Kuznetsov
2020-04-16  7:03   ` Vitaly Kuznetsov
2020-04-16  7:03   ` Vitaly Kuznetsov
2020-04-16  8:28   ` Marc Zyngier
2020-04-16  8:28     ` Marc Zyngier
2020-04-16  8:28     ` Marc Zyngier
2020-04-16  8:28     ` Marc Zyngier
2020-04-16  8:28     ` Marc Zyngier
2020-04-16  8:45     ` Tianjia Zhang
2020-04-16  8:45       ` Tianjia Zhang
2020-04-16  8:45       ` Tianjia Zhang
2020-04-16  8:45       ` Tianjia Zhang
2020-04-16  8:45       ` Tianjia Zhang
2020-04-16  8:50       ` Cornelia Huck
2020-04-16  8:50         ` Cornelia Huck
2020-04-16  8:50         ` Cornelia Huck
2020-04-16  8:50         ` Cornelia Huck
2020-04-16  8:50         ` Cornelia Huck
2020-04-16  9:08         ` Tianjia Zhang
2020-04-16  9:08           ` Tianjia Zhang
2020-04-16  9:08           ` Tianjia Zhang
2020-04-16  9:08           ` Tianjia Zhang
2020-04-16  9:08           ` Tianjia Zhang
2020-04-16  8:58       ` Marc Zyngier [this message]
2020-04-16  8:58         ` Marc Zyngier
2020-04-16  8:58         ` Marc Zyngier
2020-04-16  8:58         ` Marc Zyngier
2020-04-16  8:58         ` Marc Zyngier
2020-04-16  8:10 ` Cornelia Huck
2020-04-16  8:10   ` Cornelia Huck
2020-04-16  8:10   ` Cornelia Huck
2020-04-16  8:10   ` Cornelia Huck
2020-04-16  8:10   ` Cornelia Huck
2020-04-16 14:16 ` Paolo Bonzini
2020-04-16 14:16   ` Paolo Bonzini
2020-04-16 14:16   ` Paolo Bonzini
2020-04-16 14:16   ` Paolo Bonzini
2020-04-16 14:16   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b700f9bde1218b217ca4e571b1d29c1e@kernel.org \
    --to=maz@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=borntraeger@de.ibm.com \
    --cc=bp@alien8.de \
    --cc=christoffer.dall@arm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@ozlabs.org \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=suzuki.poulose@arm.com \
    --cc=tglx@linutronix.de \
    --cc=thuth@redhat.com \
    --cc=tianjia.zhang@linux.alibaba.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.