From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dave Airlie <airlied@gmail.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] intel/gtt: unmap pages after rewriting GTT table.
Date: Tue, 11 Jan 2011 13:28:52 +0000 [thread overview]
Message-ID: <b7da2f$q3pp34@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1294708636-18201-1-git-send-email-airlied@gmail.com>
On Tue, 11 Jan 2011 11:17:16 +1000, Dave Airlie <airlied@gmail.com> wrote:
> This fixes a regression caused by the GTT rework that
> 450f2b3d51025a1749b694ee13f0e4e23ed58750 is part off.
>
> On my ILK laptop with DMAR enabled I was seeing the occasional
> DMAR warning.
>
> The ordering in the previous code was to rewrite the GTT table
> before unampping the pages and that makes sense to me.
Dave you mentioned on IRC that this is not sufficient to quieten DMAR,
right? The unbind+unmap looks safer than unmap+unbind, so that seems to
be a good patch regardless.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-01-11 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 1:17 [PATCH] intel/gtt: unmap pages after rewriting GTT table Dave Airlie
2011-01-11 13:28 ` Chris Wilson [this message]
2011-01-11 20:11 ` Dave Airlie
2011-01-11 23:12 ` [git pull] outstanding fixes for i915 from d-i-n Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b7da2f$q3pp34@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=airlied@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.