From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: fix per-pipe reads after "cleanup"
Date: Thu, 17 Feb 2011 21:08:08 +0000 [thread overview]
Message-ID: <b7da2f$qfeb4i@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <20110217104053.1a568b5e@jbarnes-desktop>
On Thu, 17 Feb 2011 10:40:53 -0800, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> In a few places I replaced reads of per-pipe registers with the actual
> register offsets themselves (converting I915_READ(reg) to _PIPE(reg)).
> Alexey caught this on his 9xx machine because the cursor control write
> was affected. A quick audit showed a few more places where I'd borked
> a read, so here's a patch to fix things up.
Shoot the reviewer. Thanks for finding those needles in the haystack,
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-02-17 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 18:40 [PATCH] drm/i915: fix per-pipe reads after "cleanup" Jesse Barnes
2011-02-17 21:08 ` Chris Wilson [this message]
2011-02-17 21:33 ` Alexey Fisher
2011-02-17 21:36 ` Jesse Barnes
2011-02-17 22:02 ` Alexey Fisher
2011-02-17 22:03 ` Alexey Fisher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b7da2f$qfeb4i@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.