From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Arjan van de Ven <arjan@linux.intel.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: add a tracepoint for gpu frequency changes
Date: Sun, 02 Sep 2012 08:41:21 +0100 [thread overview]
Message-ID: <b94cdc$6f4l79@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <134cae9b5b455bbcd2a3d2bb2e169938@bwidawsk.net>
On Sat, 01 Sep 2012 18:16:52 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> On 2012-09-01 12:22, Chris Wilson wrote:
> > On Sat, 01 Sep 2012 11:35:13 -0700, Ben Widawsky <ben@bwidawsk.net>
> > wrote:
> >> I have no problem with Daniel's patch. It's just a matter of cutting
> >> through some scheduler BS of "when the GPU wants to change
> >> frequency"
> >> vs. "when we actually change the GPU frequency." I think *both* are
> >> interesting.
> >
> > We already trace the interrupt, which has been invaluable in
> > debugging. And there is no other source currently... :)
> > -Chris
>
> No we do not trace it (/me is looking on cgit, so perhaps a bit error
> prone). Sure we trace GT interrupts, but not pm interrupts (again,
> unless I am missing something via code browsing on the web).
Oh we definitely do otherwise it would have been a bit difficult to have
noticed that we woke up every 10ms to service a PM event that we then
ignore...
> Furthermore, even if we have added a generic interrupt trace event and
> I've missed it: I think it's still nice to have a power/performance
> specific one for users like powerTOP, as opposed to driver developers.
As complete BS as GPU op/s? If you can find a tracepoint that is
actionable from within powertop, go for it.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2012-09-02 7:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 11:26 [PATCH] drm/i915: add a tracepoint for gpu frequency changes Daniel Vetter
2012-08-30 13:34 ` [Intel-gfx] " Chris Wilson
2012-08-31 9:07 ` Daniel Vetter
2012-08-30 13:51 ` Paul Menzel
2012-09-01 18:26 ` [Intel-gfx] " Ben Widawsky
2012-09-01 18:28 ` Arjan van de Ven
2012-09-01 18:35 ` Ben Widawsky
2012-09-01 19:14 ` Daniel Vetter
2012-09-02 1:36 ` Ben Widawsky
2012-09-02 2:44 ` Arjan van de Ven
2012-09-02 3:05 ` Ben Widawsky
2012-09-02 3:06 ` [Intel-gfx] " Arjan van de Ven
2012-09-02 3:11 ` Ben Widawsky
2012-09-03 7:56 ` Daniel Vetter
2012-09-03 7:53 ` Daniel Vetter
2012-09-01 19:22 ` [Intel-gfx] " Chris Wilson
2012-09-02 1:16 ` Ben Widawsky
2012-09-02 7:41 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b94cdc$6f4l79@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=arjan@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.