From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 4/5] drm/i915: clear up wedged transitions
Date: Tue, 13 Nov 2012 08:56:39 +0000 [thread overview]
Message-ID: <b94cdc$7apge8@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1352758073-31330-5-git-send-email-daniel.vetter@ffwll.ch>
On Mon, 12 Nov 2012 23:07:52 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> While auditing the code I've noticed one place (the throttle ioctl)
> which does not yet wait for the reset handler to complete and doesn't
> properly decode the wedge state into -EAGAIN/-EIO. Fix this up by
> calling the right helpers. This might explain the oddball "my
> compositor just died in a successfull gpu reset" reports.
It is a standalone bugfix and should be split into its own patch. But I
don't think it quite has the impact you describe, since it only called
by the ddx and only sna bothers to check the error code. And one
side-effect is that I think for especilly this case
i915_gem_check_wedge() should be setting set_need_resched() before
returning -EAGAIN.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-11-13 8:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 22:07 [PATCH 0/5] robustify reset state transitions Daniel Vetter
2012-11-12 22:07 ` [PATCH 1/5] drm/i915: move dev_priv->mm out of line Daniel Vetter
2012-11-12 22:07 ` [PATCH 2/5] drm/i915: extract hangcheck/reset/error_state state into substruct Daniel Vetter
2012-11-12 22:07 ` [PATCH 3/5] drm/i915: move wedged to the other gpu error handling stuff Daniel Vetter
2012-11-12 22:07 ` [PATCH 4/5] drm/i915: clear up wedged transitions Daniel Vetter
2012-11-13 8:56 ` Chris Wilson [this message]
2012-11-13 10:12 ` Daniel Vetter
2012-11-13 16:40 ` [PATCH 1/2] drm/i915: fix reset handling in the throttle ioctl Daniel Vetter
2012-11-13 16:40 ` [PATCH 2/2] drm/i915: clear up wedged transitions Daniel Vetter
2012-11-12 22:07 ` [PATCH 5/5] drm/i915: create a race-free reset detection Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b94cdc$7apge8@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.