From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/2] drm/i915: disable shrinker lock stealing for create_mmap_offset
Date: Wed, 19 Dec 2012 13:49:29 +0000 [thread overview]
Message-ID: <b94cdc$7s5nf4@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <1355924026-13159-2-git-send-email-daniel.vetter@ffwll.ch>
On Wed, 19 Dec 2012 14:33:46 +0100, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> The mmap offset structure is not part of the drm/i915 code, but
> provided by gem helpers. To avoid leaky abstractions (by either
> depending upon implementation details of said helper wrt to
> preallocations, or reimplementing it in our code and so fuzzing
> around in internal details of that helpr) simply disable
> the shrinker lock stealing accross calls into the helper functions.
>
> This should fix igt/gem_tiled_swapping.
Proving that if we just fixed the code stolen from us, we'd run less
chance of introducing bugs.... :-p
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-12-19 13:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 12:08 [PATCH] drm/i915: optionally disable shrinker lock stealing Daniel Vetter
2012-12-19 12:22 ` Chris Wilson
2012-12-19 13:33 ` [PATCH 1/2] " Daniel Vetter
2012-12-19 13:33 ` [PATCH 2/2] drm/i915: disable shrinker lock stealing for create_mmap_offset Daniel Vetter
2012-12-19 13:49 ` Chris Wilson [this message]
[not found] ` <1355928016-15701-1-git-send-email-daniel.vetter@ffwll.ch>
[not found] ` <f5ae8a$7um44j@fmsmga002.fm.intel.com>
2012-12-20 14:03 ` [PATCH] " Daniel Vetter
2012-12-20 14:11 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b94cdc$7s5nf4@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.