From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Bernd Schubert <bernd.schubert@fastmail.fm>
Cc: linux-raid@vger.kernel.org, Shaohua Li <shli@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: md: Combine two kmalloc() calls into one in sb_equal()
Date: Fri, 09 Dec 2016 21:58:22 +0000 [thread overview]
Message-ID: <b992386f-bf20-8483-d7dd-ee4c29625ecb@users.sourceforge.net> (raw)
In-Reply-To: <a33e87c6-9b47-96e2-a877-b86bc8949eb6@fastmail.fm>
> Irrelevant, the variable is not used before checking it.
* Will it be more appropriate to attempt another memory allocation only if
the previous one succeeded already?
* Can it be a bit more efficient to duplicate only the required data
in a single function call before?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Bernd Schubert <bernd.schubert@fastmail.fm>
Cc: linux-raid@vger.kernel.org, Shaohua Li <shli@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: md: Combine two kmalloc() calls into one in sb_equal()
Date: Fri, 9 Dec 2016 22:58:22 +0100 [thread overview]
Message-ID: <b992386f-bf20-8483-d7dd-ee4c29625ecb@users.sourceforge.net> (raw)
In-Reply-To: <a33e87c6-9b47-96e2-a877-b86bc8949eb6@fastmail.fm>
> Irrelevant, the variable is not used before checking it.
* Will it be more appropriate to attempt another memory allocation only if
the previous one succeeded already?
* Can it be a bit more efficient to duplicate only the required data
in a single function call before?
Regards,
Markus
next prev parent reply other threads:[~2016-12-09 21:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 18:30 [PATCH] md: Combine two kmalloc() calls into one in sb_equal() SF Markus Elfring
2016-12-09 18:30 ` SF Markus Elfring
2016-12-09 19:05 ` Joe Perches
2016-12-09 19:05 ` Joe Perches
2016-12-09 20:05 ` SF Markus Elfring
2016-12-09 20:05 ` SF Markus Elfring
2016-12-09 20:51 ` Joe Perches
2016-12-09 20:51 ` Joe Perches
2016-12-09 21:30 ` [PATCH] " Al Viro
2016-12-09 21:30 ` Al Viro
2016-12-09 21:57 ` Joe Perches
2016-12-09 21:57 ` Joe Perches
2016-12-09 19:09 ` Bernd Schubert
2016-12-09 19:09 ` Bernd Schubert
2016-12-09 19:54 ` SF Markus Elfring
2016-12-09 19:54 ` SF Markus Elfring
2016-12-09 21:18 ` Bernd Schubert
2016-12-09 21:18 ` Bernd Schubert
2016-12-09 21:58 ` SF Markus Elfring [this message]
2016-12-09 21:58 ` SF Markus Elfring
2016-12-09 22:04 ` Bernd Schubert
2016-12-09 22:04 ` Bernd Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b992386f-bf20-8483-d7dd-ee4c29625ecb@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=bernd.schubert@fastmail.fm \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.