From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dan Carpenter <error27@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [patch] i915: signedness bug in check_overlay_src()
Date: Wed, 27 Oct 2010 21:58:45 +0000 [thread overview]
Message-ID: <b9dded$gtljue@orsmga002.jf.intel.com> (raw)
In-Reply-To: <20101027211724.GI6062@bicker>
On Wed, 27 Oct 2010 23:17:25 +0200, Dan Carpenter <error27@gmail.com> wrote:
> "depth" should be signed in case packed_depth_bytes() returns -EINVAL.
>
> This probably doesn't make a difference at runtime. In the original
> code we would return -EINVAL later if (rec->offset_Y % 4294967274) is
> non-zero.
Applied to fixes, thanks.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dan Carpenter <error27@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [patch] i915: signedness bug in check_overlay_src()
Date: Wed, 27 Oct 2010 22:58:45 +0100 [thread overview]
Message-ID: <b9dded$gtljue@orsmga002.jf.intel.com> (raw)
In-Reply-To: <20101027211724.GI6062@bicker>
On Wed, 27 Oct 2010 23:17:25 +0200, Dan Carpenter <error27@gmail.com> wrote:
> "depth" should be signed in case packed_depth_bytes() returns -EINVAL.
>
> This probably doesn't make a difference at runtime. In the original
> code we would return -EINVAL later if (rec->offset_Y % 4294967274) is
> non-zero.
Applied to fixes, thanks.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2010-10-27 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 21:17 [patch] i915: signedness bug in check_overlay_src() Dan Carpenter
2010-10-27 21:17 ` Dan Carpenter
2010-10-27 21:58 ` Chris Wilson [this message]
2010-10-27 21:58 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b9dded$gtljue@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=error27@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.