All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dave Airlie <airlied@gmail.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: dumb scanout create/mmap for intel/radeon (v3)
Date: Fri, 07 Jan 2011 00:12:15 +0000	[thread overview]
Message-ID: <b9dded$hj9137@orsmga002.jf.intel.com> (raw)
In-Reply-To: <1294355811-3225-1-git-send-email-airlied@gmail.com>

On Fri,  7 Jan 2011 09:16:51 +1000, Dave Airlie <airlied@gmail.com> wrote:
> +int
> +i915_gem_dumb_create(struct drm_file *file,
> +		     struct drm_device *dev,
> +		     struct drm_mode_create_dumb *args)
> +{
> +	/* have to work out size/pitch and return them */
> +	args->pitch = ALIGN(args->width & ((args->bpp + 1) / 8), 64);
                                        ^ oops
I think you meant args->width * ((args->bpp + 7) /8)

> +	args->size = args->pitch * args->height;
> +	return i915_gem_create(file, dev,
> +			       args->size, &args->handle);
> +}

The only issue with the dumb libkms fb is the transition to X. Is the
nature of the dumb fb such that we would be prohibited from blitting to
the X fb, or can we use platform specific knowledge to know how we can
abuse it?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2011-01-07  0:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-06 23:16 [PATCH] drm: dumb scanout create/mmap for intel/radeon (v3) Dave Airlie
2011-01-07  0:12 ` Chris Wilson [this message]
2011-01-07  0:12 ` Corbin Simpson
2011-01-07  0:18 ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='b9dded$hj9137@orsmga002.jf.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.