* Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride
2025-02-11 10:44 ` [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride Cheng Jiang
@ 2025-02-11 11:03 ` Krzysztof Kozlowski
2025-02-13 5:56 ` Cheng Jiang
2025-02-11 14:34 ` Konrad Dybcio
2025-03-26 16:24 ` Dmitry Baryshkov
2 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-11 11:03 UTC (permalink / raw)
To: Cheng Jiang, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_jiaymao, quic_shuaz,
quic_zijuhu, quic_mohamull
On 11/02/2025 11:44, Cheng Jiang wrote:
> };
> };
>
> +&uart2 {
> + status = "okay";
> + bluetooth: bluetooth {
Why do you need the label?
> + compatible = "qcom,wcn6855-bt";
> + firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&bt_en_state>;
> + enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
> +
> + vddio-supply = <&vreg_conn_pa>; /* bt-vdd-ctrl1-supply */
> + vddbtcxmx-supply = <&vreg_conn_1p8>; /* bt-vdd-ctrl2-supply */
Only one space before '='.
I think this has multiple test failures.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride
2025-02-11 11:03 ` Krzysztof Kozlowski
@ 2025-02-13 5:56 ` Cheng Jiang
2025-02-13 7:36 ` Krzysztof Kozlowski
0 siblings, 1 reply; 11+ messages in thread
From: Cheng Jiang @ 2025-02-13 5:56 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_jiaymao, quic_shuaz,
quic_zijuhu, quic_mohamull
Hi Krzysztof,
On 2/11/2025 7:03 PM, Krzysztof Kozlowski wrote:
> On 11/02/2025 11:44, Cheng Jiang wrote:
>> };
>> };
>>
>> +&uart2 {
>> + status = "okay";
>> + bluetooth: bluetooth {
>
> Why do you need the label?
>
Yes, label is not needed.
>> + compatible = "qcom,wcn6855-bt";
>> + firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
>> +
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&bt_en_state>;
>> + enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
>> +
>> + vddio-supply = <&vreg_conn_pa>; /* bt-vdd-ctrl1-supply */
>> + vddbtcxmx-supply = <&vreg_conn_1p8>; /* bt-vdd-ctrl2-supply */
>
> Only one space before '='.
>
> I think this has multiple test failures.
>
Ack, Will change in next version.
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride
2025-02-13 5:56 ` Cheng Jiang
@ 2025-02-13 7:36 ` Krzysztof Kozlowski
2025-02-13 10:35 ` Cheng Jiang
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-13 7:36 UTC (permalink / raw)
To: Cheng Jiang, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_jiaymao, quic_shuaz,
quic_zijuhu, quic_mohamull
On 13/02/2025 06:56, Cheng Jiang wrote:
> Yes, label is not needed.
>>> + compatible = "qcom,wcn6855-bt";
>>> + firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
>>> +
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&bt_en_state>;
>>> + enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
>>> +
>>> + vddio-supply = <&vreg_conn_pa>; /* bt-vdd-ctrl1-supply */
>>> + vddbtcxmx-supply = <&vreg_conn_1p8>; /* bt-vdd-ctrl2-supply */
>>
>> Only one space before '='.
>>
>> I think this has multiple test failures.
>>
> Ack, Will change in next version.
Are you going to test it as well?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride
2025-02-13 7:36 ` Krzysztof Kozlowski
@ 2025-02-13 10:35 ` Cheng Jiang
0 siblings, 0 replies; 11+ messages in thread
From: Cheng Jiang @ 2025-02-13 10:35 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_jiaymao, quic_shuaz,
quic_zijuhu, quic_mohamull
Hi Krzysztof,
On 2/13/2025 3:36 PM, Krzysztof Kozlowski wrote:
> On 13/02/2025 06:56, Cheng Jiang wrote:
>> Yes, label is not needed.
>>>> + compatible = "qcom,wcn6855-bt";
>>>> + firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
>>>> +
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&bt_en_state>;
>>>> + enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
>>>> +
>>>> + vddio-supply = <&vreg_conn_pa>; /* bt-vdd-ctrl1-supply */
>>>> + vddbtcxmx-supply = <&vreg_conn_1p8>; /* bt-vdd-ctrl2-supply */
>>>
>>> Only one space before '='.
>>>
>>> I think this has multiple test failures.
>>>
>> Ack, Will change in next version.
>
> Are you going to test it as well?
>
Yes, I will test it. Thanks!
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride
2025-02-11 10:44 ` [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride Cheng Jiang
2025-02-11 11:03 ` Krzysztof Kozlowski
@ 2025-02-11 14:34 ` Konrad Dybcio
2025-02-13 5:59 ` Cheng Jiang
2025-03-26 16:24 ` Dmitry Baryshkov
2 siblings, 1 reply; 11+ messages in thread
From: Konrad Dybcio @ 2025-02-11 14:34 UTC (permalink / raw)
To: Cheng Jiang, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_jiaymao, quic_shuaz,
quic_zijuhu, quic_mohamull
On 11.02.2025 11:44 AM, Cheng Jiang wrote:
> Enable BT on qcs8300-ride by adding a node for the BT module. Since the
> platform uses the QCA6698 Bluetooth chip. While the QCA6698 shares th
> same IP core as the WCN6855, it has different RF components and RAM sizes,
> requiring new firmware files. Use the firmware-name property to specify
> the NVM and rampatch firmware to load.
>
> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 24 +++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index a6991e8e2df6..93458773b72d 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -17,6 +17,7 @@ / {
>
> aliases {
> serial0 = &uart7;
> + serial1 = &uart2;
> };
>
> chosen {
> @@ -451,6 +452,13 @@ &serdes0 {
> };
>
> &tlmm {
> + bt_en_state: bt-en-state {
> + pins = "gpio55";
> + function = "normal";
> + output-low;
> + bias-pull-down;
> + };
> +
> ethernet0_default: ethernet0-default-state {
> ethernet0_mdc: ethernet0-mdc-pins {
> pins = "gpio5";
> @@ -544,6 +552,22 @@ wlan_en_state: wlan-en-state {
> };
> };
>
> +&uart2 {
> + status = "okay";
> + bluetooth: bluetooth {
Please add a newline between the last property and subnodes
> + compatible = "qcom,wcn6855-bt";
> + firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&bt_en_state>;
You should use qcom,wcn6855-pmu (see e.g. sc8280xp-crd.dts)
> + enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
> +
> + vddio-supply = <&vreg_conn_pa>; /* bt-vdd-ctrl1-supply */
> + vddbtcxmx-supply = <&vreg_conn_1p8>; /* bt-vdd-ctrl2-supply */
Drop these comments
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride
2025-02-11 14:34 ` Konrad Dybcio
@ 2025-02-13 5:59 ` Cheng Jiang
0 siblings, 0 replies; 11+ messages in thread
From: Cheng Jiang @ 2025-02-13 5:59 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, quic_jiaymao, quic_shuaz,
quic_zijuhu, quic_mohamull
Hi Konrad,
On 2/11/2025 10:34 PM, Konrad Dybcio wrote:
> On 11.02.2025 11:44 AM, Cheng Jiang wrote:
>> Enable BT on qcs8300-ride by adding a node for the BT module. Since the
>> platform uses the QCA6698 Bluetooth chip. While the QCA6698 shares th
>> same IP core as the WCN6855, it has different RF components and RAM sizes,
>> requiring new firmware files. Use the firmware-name property to specify
>> the NVM and rampatch firmware to load.
>>
>> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 24 +++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> index a6991e8e2df6..93458773b72d 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> @@ -17,6 +17,7 @@ / {
>>
>> aliases {
>> serial0 = &uart7;
>> + serial1 = &uart2;
>> };
>>
>> chosen {
>> @@ -451,6 +452,13 @@ &serdes0 {
>> };
>>
>> &tlmm {
>> + bt_en_state: bt-en-state {
>> + pins = "gpio55";
>> + function = "normal";
>> + output-low;
>> + bias-pull-down;
>> + };
>> +
>> ethernet0_default: ethernet0-default-state {
>> ethernet0_mdc: ethernet0-mdc-pins {
>> pins = "gpio5";
>> @@ -544,6 +552,22 @@ wlan_en_state: wlan-en-state {
>> };
>> };
>>
>> +&uart2 {
>> + status = "okay";
>> + bluetooth: bluetooth {
>
> Please add a newline between the last property and subnodes
>
Ack.
>> + compatible = "qcom,wcn6855-bt";
>> + firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
>> +
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&bt_en_state>;
>
> You should use qcom,wcn6855-pmu (see e.g. sc8280xp-crd.dts)
>
Ack. Will use the power sequence for BT power control.
>> + enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>; /* BT_EN */
>> +
>> + vddio-supply = <&vreg_conn_pa>; /* bt-vdd-ctrl1-supply */
>> + vddbtcxmx-supply = <&vreg_conn_1p8>; /* bt-vdd-ctrl2-supply */
>
> Drop these comments
>
Ack.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride
2025-02-11 10:44 ` [PATCH v1 1/1] arm64: dts: qcom: qcs8300-ride: enable BT on qcs8300-ride Cheng Jiang
2025-02-11 11:03 ` Krzysztof Kozlowski
2025-02-11 14:34 ` Konrad Dybcio
@ 2025-03-26 16:24 ` Dmitry Baryshkov
2 siblings, 0 replies; 11+ messages in thread
From: Dmitry Baryshkov @ 2025-03-26 16:24 UTC (permalink / raw)
To: Cheng Jiang
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
quic_jiaymao, quic_shuaz, quic_zijuhu, quic_mohamull
On Tue, Feb 11, 2025 at 06:44:21PM +0800, Cheng Jiang wrote:
> Enable BT on qcs8300-ride by adding a node for the BT module. Since the
> platform uses the QCA6698 Bluetooth chip. While the QCA6698 shares th
> same IP core as the WCN6855, it has different RF components and RAM sizes,
> requiring new firmware files. Use the firmware-name property to specify
> the NVM and rampatch firmware to load.
>
> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 24 +++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
Just so that it doesn't get lost. It should be rebased on top of WiFi patchset ([1])
[1] https://lore.kernel.org/linux-arm-msm/20250325075331.1662306-1-quic_stonez@quicinc.com/
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 11+ messages in thread