From: atx@atx.name
To: Jean Delvare <jdelvare@suse.de>
Cc: linux@roeck-us.net, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] drivers/hwmon: bugfix and support for emc1412 in emc1403.c
Date: Sun, 11 May 2014 11:27:38 +0000 [thread overview]
Message-ID: <b9f6fe08e91b81bfd870105ab36a531c@rainloop.atalax.net> (raw)
In-Reply-To: <20140511131228.019bdba5@endymion.delvare>
May 11 2014 1:12 PM, "Jean Delvare" wrote:
> Hi Josef,
>
> On Sun, 11 May 2014 12:31:52 +0200, Josef Gajdusek wrote:
>
>
>> Adds support for emc1412 to emc1403.c + minor bugfix
>>
>> * Renamed generic thermal_* prefixed names to emc1403_*
>>
>>
>> Why? This adds a lot of noise to your patch and the benefit isn't
>> obvious. If you really want to do that, then it should be a separate
>> patch.
>>
>>
>>> * Fixed set_hyst being broken (i. e. writing 86000 set hysteresis to 84000)
>>>
>>
>>
>> Bug fixes should be sent as separate patches, so that they can be
>> ported back to stable, long-term and distribution kernels.
>>
>>
>> * Added support for emc1412
>>
>> Signed-off-by: Josef Gajdusek
>>
>> +MODULE_ALIAS("i2c:emc1403");
>>
>
>
> Why add an alias which is already present?
>
> --
> Jean Delvare
> SUSE L3 Support
>
Hello,
thanks for your feedback. I am going to split and change the patches as you suggested and then resend within few hours.
Josef Gajdusek <atx@atx.name>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: atx@atx.name
To: "Jean Delvare" <jdelvare@suse.de>
Cc: linux@roeck-us.net, lm-sensors@lm-sensors.org,
linux-kernel@vger.kernel.org
Subject: Re[2]: [PATCH] drivers/hwmon: bugfix and support for emc1412 in emc1403.c
Date: Sun, 11 May 2014 11:27:38 +0000 [thread overview]
Message-ID: <b9f6fe08e91b81bfd870105ab36a531c@rainloop.atalax.net> (raw)
In-Reply-To: <20140511131228.019bdba5@endymion.delvare>
May 11 2014 1:12 PM, "Jean Delvare" wrote:
> Hi Josef,
>
> On Sun, 11 May 2014 12:31:52 +0200, Josef Gajdusek wrote:
>
>
>> Adds support for emc1412 to emc1403.c + minor bugfix
>>
>> * Renamed generic thermal_* prefixed names to emc1403_*
>>
>>
>> Why? This adds a lot of noise to your patch and the benefit isn't
>> obvious. If you really want to do that, then it should be a separate
>> patch.
>>
>>
>>> * Fixed set_hyst being broken (i. e. writing 86000 set hysteresis to 84000)
>>>
>>
>>
>> Bug fixes should be sent as separate patches, so that they can be
>> ported back to stable, long-term and distribution kernels.
>>
>>
>> * Added support for emc1412
>>
>> Signed-off-by: Josef Gajdusek
>>
>> +MODULE_ALIAS("i2c:emc1403");
>>
>
>
> Why add an alias which is already present?
>
> --
> Jean Delvare
> SUSE L3 Support
>
Hello,
thanks for your feedback. I am going to split and change the patches as you suggested and then resend within few hours.
Josef Gajdusek <atx@atx.name>
next prev parent reply other threads:[~2014-05-11 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 10:31 [lm-sensors] [PATCH] drivers/hwmon: bugfix and support for emc1412 in emc1403.c Josef Gajdusek
2014-05-11 10:31 ` Josef Gajdusek
2014-05-11 11:12 ` [lm-sensors] " Jean Delvare
2014-05-11 11:12 ` Jean Delvare
2014-05-11 11:27 ` atx [this message]
2014-05-11 11:27 ` Re[2]: " atx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9f6fe08e91b81bfd870105ab36a531c@rainloop.atalax.net \
--to=atx@atx.name \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.