All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabor Juhos <j4g8y7@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: core: always verify OOB offset in mtd_check_oob_ops()
Date: Mon, 1 Sep 2025 16:12:11 +0200	[thread overview]
Message-ID: <ba1336ce-cc0d-4dcf-99ff-1934cb02372a@gmail.com> (raw)
In-Reply-To: <874itmpcrs.fsf@bootlin.com>

Hi Miquel,

2025. 09. 01. 14:39 keltezéssel, Miquel Raynal írta:

...

>> This behaviour is more accurate than the current one where most tests
>> are indicating successful writing of OOB data even that in fact nothing
>> gets written into the device, which is quite misleading.
>>
>> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> 
> Thanks a lot for this contribution, I'm ready to take it. Just one
> question, do you consider it should be backported? I would tend to
> answer yes to this question, which would involve you sending a v2 with:
> 
>        Fixes:
>        Cc: stable...
> 
> Otherwise I can take it as-is if you convince me it is not so relevant
> :-)

I can't convince even myself about that, so will send a v2. :)

Regards,
Gabor

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Gabor Juhos <j4g8y7@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: core: always verify OOB offset in mtd_check_oob_ops()
Date: Mon, 1 Sep 2025 16:12:11 +0200	[thread overview]
Message-ID: <ba1336ce-cc0d-4dcf-99ff-1934cb02372a@gmail.com> (raw)
In-Reply-To: <874itmpcrs.fsf@bootlin.com>

Hi Miquel,

2025. 09. 01. 14:39 keltezéssel, Miquel Raynal írta:

...

>> This behaviour is more accurate than the current one where most tests
>> are indicating successful writing of OOB data even that in fact nothing
>> gets written into the device, which is quite misleading.
>>
>> Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
> 
> Thanks a lot for this contribution, I'm ready to take it. Just one
> question, do you consider it should be backported? I would tend to
> answer yes to this question, which would involve you sending a v2 with:
> 
>        Fixes:
>        Cc: stable...
> 
> Otherwise I can take it as-is if you convince me it is not so relevant
> :-)

I can't convince even myself about that, so will send a v2. :)

Regards,
Gabor

  reply	other threads:[~2025-09-01 17:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-31 14:40 [PATCH] mtd: core: always verify OOB offset in mtd_check_oob_ops() Gabor Juhos
2025-08-31 14:40 ` Gabor Juhos
2025-08-31 17:14 ` Daniel Golle
2025-08-31 17:14   ` Daniel Golle
2025-09-01 12:39 ` Miquel Raynal
2025-09-01 12:39   ` Miquel Raynal
2025-09-01 14:12   ` Gabor Juhos [this message]
2025-09-01 14:12     ` Gabor Juhos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba1336ce-cc0d-4dcf-99ff-1934cb02372a@gmail.com \
    --to=j4g8y7@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.