All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Stefan Wahren" <wahrenst@gmx.net>,
	"Jim Quinlan" <jim2101024@gmail.com>,
	"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Cyril Brulebois" <kibi@debian.org>
Cc: bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Jonathan Bell <jonathan@raspberrypi.com>
Subject: Re: [PATCH] PCI: brcmstb: fix broken brcm_pcie_mdio_write() polling
Date: Sat, 17 Feb 2024 09:27:20 -0800	[thread overview]
Message-ID: <ba9fa05c-0a3d-4d68-bdb1-d9e6e2c59c78@broadcom.com> (raw)
In-Reply-To: <20240217133722.14391-1-wahrenst@gmx.net>

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]



On 2/17/2024 5:37 AM, Stefan Wahren wrote:
> From: Jonathan Bell <jonathan@raspberrypi.com>
> 
> MDIO_WR_DONE() tests bit 31, which is always 0 (==done) as
> readw_poll_timeout_atomic does a 16-bit read. Replace with the readl
> variant.
> 
> Fixes: ca5dcc76314d ("PCI: brcmstb: Replace status loops with read_poll_timeout_atomic()")
> Signed-off-by: Jonathan Bell <jonathan@raspberrypi.com>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>

Excellent catch! Not sure what the real world impact was.

Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Stefan Wahren" <wahrenst@gmx.net>,
	"Jim Quinlan" <jim2101024@gmail.com>,
	"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Cyril Brulebois" <kibi@debian.org>
Cc: bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Jonathan Bell <jonathan@raspberrypi.com>
Subject: Re: [PATCH] PCI: brcmstb: fix broken brcm_pcie_mdio_write() polling
Date: Sat, 17 Feb 2024 09:27:20 -0800	[thread overview]
Message-ID: <ba9fa05c-0a3d-4d68-bdb1-d9e6e2c59c78@broadcom.com> (raw)
In-Reply-To: <20240217133722.14391-1-wahrenst@gmx.net>


[-- Attachment #1.1: Type: text/plain, Size: 575 bytes --]



On 2/17/2024 5:37 AM, Stefan Wahren wrote:
> From: Jonathan Bell <jonathan@raspberrypi.com>
> 
> MDIO_WR_DONE() tests bit 31, which is always 0 (==done) as
> readw_poll_timeout_atomic does a 16-bit read. Replace with the readl
> variant.
> 
> Fixes: ca5dcc76314d ("PCI: brcmstb: Replace status loops with read_poll_timeout_atomic()")
> Signed-off-by: Jonathan Bell <jonathan@raspberrypi.com>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>

Excellent catch! Not sure what the real world impact was.

Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-02-17 17:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-17 13:37 [PATCH] PCI: brcmstb: fix broken brcm_pcie_mdio_write() polling Stefan Wahren
2024-02-17 13:37 ` Stefan Wahren
2024-02-17 17:27 ` Florian Fainelli [this message]
2024-02-17 17:27   ` Florian Fainelli
2024-03-02  9:45   ` Stefan Wahren
2024-03-02  9:45     ` Stefan Wahren
2024-03-07 18:59     ` Stefan Wahren
2024-03-07 18:59       ` Stefan Wahren
2024-03-09 17:13       ` Krzysztof Wilczyński
2024-03-09 17:13         ` Krzysztof Wilczyński
2024-03-09 17:08 ` Krzysztof Wilczyński
2024-03-09 17:08   ` Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba9fa05c-0a3d-4d68-bdb1-d9e6e2c59c78@broadcom.com \
    --to=florian.fainelli@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=jim2101024@gmail.com \
    --cc=jonathan@raspberrypi.com \
    --cc=kibi@debian.org \
    --cc=kw@linux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=nsaenz@kernel.org \
    --cc=robh@kernel.org \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.