All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hao Yao <hao.yao@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Bingbu Cao <bingbu.cao@linux.intel.com>
Cc: Bingbu Cao <bingbu.cao@intel.com>,
	Tianshu Qiu <tian.shu.qiu@intel.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	<linux-media@vger.kernel.org>
Subject: Re: [PATCH] media: ipu6: Remove workaround for Meteor Lake ES2
Date: Fri, 25 Apr 2025 14:28:12 +0800	[thread overview]
Message-ID: <badce13d-bded-4e50-89f5-74538b2c44f7@intel.com> (raw)
In-Reply-To: <aAsgQjNEacme1NZU@kekkonen.localdomain>

Hi Sakari, Bingbu,

On 2025/4/25 13:40, Sakari Ailus wrote:
> Hi Bingbu,
> 
> On Fri, Apr 25, 2025 at 11:05:54AM +0800, Bingbu Cao wrote:
>> Sakari,
>>
>> On 4/24/25 7:55 PM, Sakari Ailus wrote:
>>> Hi Bingbu,
>>>
>>> On Thu, Apr 24, 2025 at 12:18:06PM +0800, Bingbu Cao wrote:
>>>> Hao,
>>>>
>>>> On 3/11/25 4:41 PM, Hao Yao wrote:
>>>>> There was a hardware bug which need IPU6 driver to disable the ATS.
>>>>> This workaround is not needed anymore as the bug was fixed in
>>>>> hardware level.
>>>>>
>>>>
>>>> It is better to send v2 with fixes tag here:
>>>>
>>>> Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
>>>
>>> Is this worth backporting? Nothing is broken because of this, is it?
>>
>> It is necessary. IPU6 on Raptor Lake share same device ID with
>> Meteor Lake, this workaround will break camera on Raptor Lake.
>>
>> And Meteor Lake ES2 is not used in product.
> 
> Ok, this should be visible in the commit message.
> 
> How about adding:
> 
> Additionally, Raptor Lake has the same IPU6 PCI ID and x86 stepping and but
> does have the bug. Removing the Meteor Lake workaround is also required for
> the driver to function on Raptor Lake.
> 
In fact it should be Arrow Lake. I will add below to next version:
---
  Additionally, Arrow Lake has the same IPU6 PCI ID and x86 stepping 

  but does not have the bug. Removing the Meteor Lake workaround is 

  also required for the driver to function on Arrow Lake. 

  

  Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device 

  driver")
---

  reply	other threads:[~2025-04-25  6:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-11  8:41 [PATCH] media: ipu6: Remove workaround for Meteor Lake ES2 Hao Yao
2025-03-11  9:03 ` Stanislaw Gruszka
2025-04-24  4:18 ` Bingbu Cao
2025-04-24 11:55   ` Sakari Ailus
2025-04-25  3:05     ` Bingbu Cao
2025-04-25  5:40       ` Sakari Ailus
2025-04-25  6:28         ` Hao Yao [this message]
2025-04-25  6:30           ` Sakari Ailus
2025-04-25  6:29             ` Bingbu Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=badce13d-bded-4e50-89f5-74538b2c44f7@intel.com \
    --to=hao.yao@intel.com \
    --cc=bingbu.cao@intel.com \
    --cc=bingbu.cao@linux.intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tian.shu.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.