Re: [PATCH] media: ipu6: Remove workaround for Meteor Lake ES2

[Bingbu Cao <bingbu.cao@linux.intel.com>]

Sakari,

On 4/24/25 7:55 PM, Sakari Ailus wrote:
> Hi Bingbu,
> 
> On Thu, Apr 24, 2025 at 12:18:06PM +0800, Bingbu Cao wrote:
>> Hao,
>>
>> On 3/11/25 4:41 PM, Hao Yao wrote:
>>> There was a hardware bug which need IPU6 driver to disable the ATS.
>>> This workaround is not needed anymore as the bug was fixed in
>>> hardware level.
>>>
>>
>> It is better to send v2 with fixes tag here:
>>
>> Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
> 
> Is this worth backporting? Nothing is broken because of this, is it?

It is necessary. IPU6 on Raptor Lake share same device ID with
Meteor Lake, this workaround will break camera on Raptor Lake.

And Meteor Lake ES2 is not used in product.

> 
>>
>>> Signed-off-by: Hao Yao <hao.yao@intel.com>
>>> ---
>>>  drivers/media/pci/intel/ipu6/ipu6.c | 5 -----
>>>  1 file changed, 5 deletions(-)
>>>
>>> diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
>>> index 277af7cda8ee..b00d0705fefa 100644
>>> --- a/drivers/media/pci/intel/ipu6/ipu6.c
>>> +++ b/drivers/media/pci/intel/ipu6/ipu6.c
>>> @@ -464,11 +464,6 @@ static int ipu6_pci_config_setup(struct pci_dev *dev, u8 hw_ver)
>>>  {
>>>  	int ret;
>>>  
>>> -	/* disable IPU6 PCI ATS on mtl ES2 */
>>> -	if (is_ipu6ep_mtl(hw_ver) && boot_cpu_data.x86_stepping == 0x2 &&
>>> -	    pci_ats_supported(dev))
>>> -		pci_disable_ats(dev);
>>> -
>>>  	/* No PCI msi capability for IPU6EP */
>>>  	if (is_ipu6ep(hw_ver) || is_ipu6ep_mtl(hw_ver)) {
>>>  		/* likely do nothing as msi not enabled by default */
>>>
>>
> 

-- 
Best regards,
Bingbu Cao