All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/fontconfig: bump to 2.16.0
@ 2025-01-25 18:21 Thomas Devoogdt
  2025-01-25 21:38 ` Julien Olivain
  2025-01-26 10:42 ` Julien Olivain
  0 siblings, 2 replies; 6+ messages in thread
From: Thomas Devoogdt @ 2025-01-25 18:21 UTC (permalink / raw)
  To: buildroot; +Cc: Eric Le Bihan, Thomas Devoogdt

Announcements:
 2.16.0: https://lists.freedesktop.org/archives/fontconfig/2025-January/007143.html
 2.15.0: https://lists.freedesktop.org/archives/fontconfig/2023-December/007064.html

Some notes:

- The hash is no longer part of the announcement but
  can instead be found in the release archive.

- Switched to meson while at it.

- Dropped the patch, since it's part of the autotools.

- Dropped some configs args, --with-arch, --disable-static,
  since meson now handles the arch, and disable static as
  it has most probably not been needed anymore for years.
  Was part of commit dd4faf6f6f3fb32657b5d0c4fb72d15a7f571b2e.
  "cairo: add host version"

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 ...read-as-a-dependency-of-a-static-lib.patch | 43 -------------------
 package/fontconfig/fontconfig.hash            |  4 +-
 package/fontconfig/fontconfig.mk              | 16 +++----
 3 files changed, 7 insertions(+), 56 deletions(-)
 delete mode 100644 package/fontconfig/0001-add-pthread-as-a-dependency-of-a-static-lib.patch

diff --git a/package/fontconfig/0001-add-pthread-as-a-dependency-of-a-static-lib.patch b/package/fontconfig/0001-add-pthread-as-a-dependency-of-a-static-lib.patch
deleted file mode 100644
index c6aa514534..0000000000
--- a/package/fontconfig/0001-add-pthread-as-a-dependency-of-a-static-lib.patch
+++ /dev/null
@@ -1,43 +0,0 @@
-From 40ec04a8bf36dd8d0aa3da98b167792ce2dcd114 Mon Sep 17 00:00:00 2001
-From: Silvan Scherrer <silvan.scherrer@aroa.ch>
-Date: Sun, 20 Sep 2020 12:52:08 +0200
-Subject: [PATCH] add pthread as a dependency of a static lib
-
-Downloaded from https://trac.netlabs.org/ports/changeset/2220
-
-Upstream: https://gitlab.freedesktop.org/fontconfig/fontconfig/-/merge_requests/121
-
-Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
----
- configure.ac     | 2 ++
- fontconfig.pc.in | 4 ++--
- 2 files changed, 4 insertions(+), 2 deletions(-)
-
-diff --git a/configure.ac b/configure.ac
-index f3189a7..594d6fd 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -690,6 +690,8 @@ fi
- have_pthread=false
- if test "$os_win32" = no; then
- 	AX_PTHREAD([have_pthread=true])
-+	AC_SUBST(PTHREAD_CFLAGS)
-+	AC_SUBST(PTHREAD_LIBS)
- fi
- if $have_pthread; then
- 	LIBS="$PTHREAD_LIBS $LIBS"
-diff --git a/fontconfig.pc.in b/fontconfig.pc.in
-index 61b35fb..f823bac 100644
---- a/fontconfig.pc.in
-+++ b/fontconfig.pc.in
-@@ -14,5 +14,5 @@ Version: @VERSION@
- Requires: @PKGCONFIG_REQUIRES@
- Requires.private: @PKGCONFIG_REQUIRES_PRIVATELY@
- Libs: -L${libdir} -lfontconfig
--Libs.private: @ICONV_LIBS@ @PKG_EXPAT_LIBS@
--Cflags: -I${includedir} @ICONV_CFLAGS@ @PKG_EXPAT_CFLAGS@
-+Libs.private: @ICONV_LIBS@ @PKG_EXPAT_LIBS@ @PTHREAD_LIBS@
-+Cflags: -I${includedir} @ICONV_CFLAGS@ @PKG_EXPAT_CFLAGS@ @PTHREAD_CFLAGS@
--- 
-2.27.0
-
diff --git a/package/fontconfig/fontconfig.hash b/package/fontconfig/fontconfig.hash
index a4f87caf1e..b9c95d40b2 100644
--- a/package/fontconfig/fontconfig.hash
+++ b/package/fontconfig/fontconfig.hash
@@ -1,5 +1,5 @@
-# From https://lists.freedesktop.org/archives/fontconfig/2023-January/006950.html
-sha256  dba695b57bce15023d2ceedef82062c2b925e51f5d4cc4aef736cf13f60a468b  fontconfig-2.14.2.tar.xz
+# From https://www.freedesktop.org/software/fontconfig/release/fontconfig-2.16.0.tar.xz.sha256sum
+sha256  6a33dc555cc9ba8b10caf7695878ef134eeb36d0af366041f639b1da9b6ed220  fontconfig-2.16.0.tar.xz
 
 # Locally calculated
 sha256  51a51aa9823704fd90bccc616cdd17ebabb5b2b3e9cbde886ca02c7002288067  COPYING
diff --git a/package/fontconfig/fontconfig.mk b/package/fontconfig/fontconfig.mk
index 11758a4c80..b60086c9c8 100644
--- a/package/fontconfig/fontconfig.mk
+++ b/package/fontconfig/fontconfig.mk
@@ -4,11 +4,9 @@
 #
 ################################################################################
 
-FONTCONFIG_VERSION = 2.14.2
+FONTCONFIG_VERSION = 2.16.0
 FONTCONFIG_SITE = https://www.freedesktop.org/software/fontconfig/release
 FONTCONFIG_SOURCE = fontconfig-$(FONTCONFIG_VERSION).tar.xz
-# 0001-add-pthread-as-a-dependency-of-a-static-lib.patch
-FONTCONFIG_AUTORECONF = YES
 FONTCONFIG_INSTALL_STAGING = YES
 FONTCONFIG_DEPENDENCIES = freetype expat host-pkgconf host-gperf \
 	$(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs,util-linux) \
@@ -21,12 +19,8 @@ FONTCONFIG_LICENSE_FILES = COPYING
 FONTCONFIG_CPE_ID_VALID = YES
 
 FONTCONFIG_CONF_OPTS = \
-	--with-arch=$(GNU_TARGET_NAME) \
-	--with-cache-dir=/var/cache/fontconfig \
-	--disable-docs
+	-Dcache-dir=/var/cache/fontconfig \
+	-Ddoc=disabled
 
-HOST_FONTCONFIG_CONF_OPTS = \
-	--disable-static
-
-$(eval $(autotools-package))
-$(eval $(host-autotools-package))
+$(eval $(meson-package))
+$(eval $(host-meson-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [PATCH] package/fontconfig: bump to 2.16.0
  2025-01-25 18:21 [Buildroot] [PATCH] package/fontconfig: bump to 2.16.0 Thomas Devoogdt
@ 2025-01-25 21:38 ` Julien Olivain
  2025-01-26 10:42 ` Julien Olivain
  1 sibling, 0 replies; 6+ messages in thread
From: Julien Olivain @ 2025-01-25 21:38 UTC (permalink / raw)
  To: Thomas Devoogdt; +Cc: buildroot, Eric Le Bihan

On 25/01/2025 19:21, Thomas Devoogdt wrote:
> Announcements:
>  2.16.0: 
> https://lists.freedesktop.org/archives/fontconfig/2025-January/007143.html
>  2.15.0: 
> https://lists.freedesktop.org/archives/fontconfig/2023-December/007064.html
> 
> Some notes:
> 
> - The hash is no longer part of the announcement but
>   can instead be found in the release archive.
> 
> - Switched to meson while at it.
> 
> - Dropped the patch, since it's part of the autotools.
> 
> - Dropped some configs args, --with-arch, --disable-static,
>   since meson now handles the arch, and disable static as
>   it has most probably not been needed anymore for years.
>   Was part of commit dd4faf6f6f3fb32657b5d0c4fb72d15a7f571b2e.
>   "cairo: add host version"
> 
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [PATCH] package/fontconfig: bump to 2.16.0
  2025-01-25 18:21 [Buildroot] [PATCH] package/fontconfig: bump to 2.16.0 Thomas Devoogdt
  2025-01-25 21:38 ` Julien Olivain
@ 2025-01-26 10:42 ` Julien Olivain
  2025-01-27 12:56   ` [Buildroot] [PATCH 1/2] package/fontconfig: fix compile issue if BR2_DEBUG_3 has been selected Thomas Devoogdt
  1 sibling, 1 reply; 6+ messages in thread
From: Julien Olivain @ 2025-01-26 10:42 UTC (permalink / raw)
  To: Thomas Devoogdt; +Cc: buildroot, Eric Le Bihan

Hi Thomas,

On 25/01/2025 19:21, Thomas Devoogdt wrote:
> -FONTCONFIG_VERSION = 2.14.2
> +FONTCONFIG_VERSION = 2.16.0

This bump seems to introduce new build failures. See:
https://autobuild.buildroot.org/?reason=fontconfig-2.16.0

Those failures seems related to:
https://gitlab.freedesktop.org/fontconfig/fontconfig/-/issues/436

Can have a look please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/2] package/fontconfig: fix compile issue if BR2_DEBUG_3 has been selected
  2025-01-26 10:42 ` Julien Olivain
@ 2025-01-27 12:56   ` Thomas Devoogdt
  2025-01-27 12:56     ` [Buildroot] [PATCH 2/2] package/fontconfig: fix compilation on targets without pthread support Thomas Devoogdt
  2025-01-27 20:19     ` [Buildroot] [PATCH 1/2] package/fontconfig: fix compile issue if BR2_DEBUG_3 has been selected Julien Olivain
  0 siblings, 2 replies; 6+ messages in thread
From: Thomas Devoogdt @ 2025-01-27 12:56 UTC (permalink / raw)
  To: buildroot; +Cc: Julien Olivain, Eric Le Bihan, Thomas Devoogdt

src/fcobjshash.gperf:568:7: error: stray '#' in program
src/fcobjshash.gperf:1:18: error: expected '=', ',', ';', 'asm' or '__attribute__' before numeric constant
    1 | #define __STDC__ 1
      |                  ^

This issue has been raised upstream [1], and reported in buildroot [2].
Upstream has not yet defined a solution, so force it to -g2 for the time being.

Fixes:
 - https://autobuild.buildroot.org/results/6ae/6aef28611ad05d8db65105ab150ae980bc6bff4e/build-end.log
 - https://autobuild.buildroot.org/results/cc3/cc38846fdf63954422ec08d3ae57f2f09ebbf8c8/build-end.log
 - https://autobuild.buildroot.org/results/b7a/b7ad9a7ecb1d06b8a3d9e86d386195f3c212b9d8/build-end.log
 - ...

[1] https://gitlab.freedesktop.org/fontconfig/fontconfig/-/issues/436
[2] https://patchwork.ozlabs.org/comment/3450162/

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 package/fontconfig/fontconfig.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/fontconfig/fontconfig.mk b/package/fontconfig/fontconfig.mk
index cc6ca88585..c6375979e8 100644
--- a/package/fontconfig/fontconfig.mk
+++ b/package/fontconfig/fontconfig.mk
@@ -20,5 +20,11 @@ FONTCONFIG_CONF_OPTS = \
 	-Dcache-dir=/var/cache/fontconfig \
 	-Ddoc=disabled
 
+FONTCONFIG_CFLAGS = $(TARGET_CFLAGS)
+
+ifeq ($(BR2_DEBUG_3),y)
+FONTCONFIG_CFLAGS += -g2
+endif
+
 $(eval $(meson-package))
 $(eval $(host-meson-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 2/2] package/fontconfig: fix compilation on targets without pthread support
  2025-01-27 12:56   ` [Buildroot] [PATCH 1/2] package/fontconfig: fix compile issue if BR2_DEBUG_3 has been selected Thomas Devoogdt
@ 2025-01-27 12:56     ` Thomas Devoogdt
  2025-01-27 20:19     ` [Buildroot] [PATCH 1/2] package/fontconfig: fix compile issue if BR2_DEBUG_3 has been selected Julien Olivain
  1 sibling, 0 replies; 6+ messages in thread
From: Thomas Devoogdt @ 2025-01-27 12:56 UTC (permalink / raw)
  To: buildroot; +Cc: Julien Olivain, Eric Le Bihan, Thomas Devoogdt, Thomas Devoogdt

From: Thomas Devoogdt <thomas.devoogdt@barco.com>

The br-arm-full-nothread fails because meson (wrongly) assumes thread
support when cross-compiling. So add an explicit check on pthread support.

Fixes:
 - https://autobuild.buildroot.org/results/5b0/5b0ae4c858e9debddf9bd9bd86cfacb6951b4c3f/build-end.log

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 ...explicitly-check-for-pthread-support.patch | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 package/fontconfig/0001-meson.build-explicitly-check-for-pthread-support.patch

diff --git a/package/fontconfig/0001-meson.build-explicitly-check-for-pthread-support.patch b/package/fontconfig/0001-meson.build-explicitly-check-for-pthread-support.patch
new file mode 100644
index 0000000000..ca394ab7d5
--- /dev/null
+++ b/package/fontconfig/0001-meson.build-explicitly-check-for-pthread-support.patch
@@ -0,0 +1,37 @@
+From 3c9de31dda1a1d44fade7a61e66c989178d6c2a4 Mon Sep 17 00:00:00 2001
+From: Thomas Devoogdt <thomas@devoogdt.com>
+Date: Sun, 26 Jan 2025 10:15:39 +0100
+Subject: [PATCH] meson.build: explicitly check for pthread support
+
+Tested using buildroot. The br-arm-full-nothread fails
+because meson assumes thread support when cross-compiling.
+
+Dependency threads found: YES unknown (cached)
+Has header "pthread.h" : NO
+
+Upstream: https://gitlab.freedesktop.org/fontconfig/fontconfig/-/commit/aad470dad519b6fe3459023b82941b4414b71313
+Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
+---
+ meson.build | 6 ++++--
+ 1 file changed, 4 insertions(+), 2 deletions(-)
+
+diff --git a/meson.build b/meson.build
+index 4439758..07e242b 100644
+--- a/meson.build
++++ b/meson.build
+@@ -383,8 +383,10 @@ endif
+ 
+ if host_machine.system() != 'windows'
+   thread_dep = dependency('threads')
+-  conf.set('HAVE_PTHREAD', 1)
+-  deps += [thread_dep]
++  if thread_dep.found() and cc.has_header('pthread.h')
++    conf.set('HAVE_PTHREAD', 1)
++    deps += [thread_dep]
++  endif
+ endif
+ 
+ fc_templatedir = get_option('template-dir')
+-- 
+2.43.0
+
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/fontconfig: fix compile issue if BR2_DEBUG_3 has been selected
  2025-01-27 12:56   ` [Buildroot] [PATCH 1/2] package/fontconfig: fix compile issue if BR2_DEBUG_3 has been selected Thomas Devoogdt
  2025-01-27 12:56     ` [Buildroot] [PATCH 2/2] package/fontconfig: fix compilation on targets without pthread support Thomas Devoogdt
@ 2025-01-27 20:19     ` Julien Olivain
  1 sibling, 0 replies; 6+ messages in thread
From: Julien Olivain @ 2025-01-27 20:19 UTC (permalink / raw)
  To: Thomas Devoogdt; +Cc: buildroot, Eric Le Bihan

On 27/01/2025 13:56, Thomas Devoogdt wrote:
> src/fcobjshash.gperf:568:7: error: stray '#' in program
> src/fcobjshash.gperf:1:18: error: expected '=', ',', ';', 'asm' or 
> '__attribute__' before numeric constant
>     1 | #define __STDC__ 1
>       |                  ^
> 
> This issue has been raised upstream [1], and reported in buildroot [2].
> Upstream has not yet defined a solution, so force it to -g2 for the 
> time being.
> 
> Fixes:
>  - 
> https://autobuild.buildroot.org/results/6ae/6aef28611ad05d8db65105ab150ae980bc6bff4e/build-end.log
>  - 
> https://autobuild.buildroot.org/results/cc3/cc38846fdf63954422ec08d3ae57f2f09ebbf8c8/build-end.log
>  - 
> https://autobuild.buildroot.org/results/b7a/b7ad9a7ecb1d06b8a3d9e86d386195f3c212b9d8/build-end.log
>  - ...
> 
> [1] https://gitlab.freedesktop.org/fontconfig/fontconfig/-/issues/436
> [2] https://patchwork.ozlabs.org/comment/3450162/
> 
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

Series applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-01-27 20:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-25 18:21 [Buildroot] [PATCH] package/fontconfig: bump to 2.16.0 Thomas Devoogdt
2025-01-25 21:38 ` Julien Olivain
2025-01-26 10:42 ` Julien Olivain
2025-01-27 12:56   ` [Buildroot] [PATCH 1/2] package/fontconfig: fix compile issue if BR2_DEBUG_3 has been selected Thomas Devoogdt
2025-01-27 12:56     ` [Buildroot] [PATCH 2/2] package/fontconfig: fix compilation on targets without pthread support Thomas Devoogdt
2025-01-27 20:19     ` [Buildroot] [PATCH 1/2] package/fontconfig: fix compile issue if BR2_DEBUG_3 has been selected Julien Olivain

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.