Re: [PATCH v1] Revert "ARM: dts: imx7: Fix NAND controller size-cells"

From: Thorsten Leemhuis <regressions@leemhuis.info>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Marek Vasut <marex@denx.de>, Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
	stable@vger.kernel.org, Francesco Dolcini <francesco@dolcini.it>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v1] Revert "ARM: dts: imx7: Fix NAND controller size-cells"
Date: Fri, 9 Dec 2022 14:30:38 +0100	[thread overview]
Message-ID: <bb4e185a-c4db-428b-a1ee-ee1ba767fffb@leemhuis.info> (raw)
In-Reply-To: <Y5ITkZtKWHzWaLS4@francesco-nb.int.toradex.com>

On 08.12.22 17:40, Francesco Dolcini wrote:
> + Arnd

Arnd, have you seen this? We haven't heard anything from Shawn afaics,
who normally would take care of a patch like this. Hence could you
consider picking up the patch at the start of this thread (e.g.
https://lore.kernel.org/all/20221205152327.26881-1-francesco@dolcini.it/
) and send it to Linus in the next 48 hours? It seems low-risk and fixes
a regression introduced this cycle various people care about. That's why
I'll likely ask Linus to consider picking this up directly before
releasing 6.1, if I don't hear anything from you soon. But I'd prefer if
the patch would go through at least somewhat the proper channels;
alternatively a ACK from you to signal Linus "yeah, pick this up" would
help as well.

Ciao, Thorsten

> On Thu, Dec 08, 2022 at 11:51:24AM +0100, Miquel Raynal wrote:
>> marex@denx.de wrote on Mon, 5 Dec 2022 17:26:53 +0100:
>>> On 12/5/22 16:23, Francesco Dolcini wrote:
>>>> From: Francesco Dolcini <francesco.dolcini@toradex.com>
>>>>
>>>> This reverts commit 753395ea1e45c724150070b5785900b6a44bd5fb.
>>>>
>>>> It introduced a boot regression on colibri-imx7, and potentially any
>>>> other i.MX7 boards with MTD partition list generated into the fdt by
>>>> U-Boot.
>>>>
>>>> While the commit we are reverting here is not obviously wrong, it fixes
>>>> only a dt binding checker warning that is non-functional, while it
>>>> introduces a boot regression and there is no obvious fix ready.
>>>>
>>>> Cc: stable@vger.kernel.org
>>>> Fixes: 753395ea1e45 ("ARM: dts: imx7: Fix NAND controller size-cells")
>>>> Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.toradex.com/
>>>> Link: https://lore.kernel.org/all/20221205144917.6514168a@xps-13/
>>>> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
>> [...]
>>> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
>> [...]
>>> Acked-by: Marek Vasut <marex@denx.de>
>> [...]
>>
>> As discussed in the above links, boot is broken on imx7 Colibri boards,
>> this revert was the most quick and straightforward fix we agreed upon
>> with the hope (~ duty?) it would make it in v6.1. Any chance you could
>> pick this up rapidly and forward it to Linus? Or should we involve
>> him directly (Thorsten?).
> 
> Hello Arnd,
> FYI - see Miquel explanation above.
> 
> Francesco
> 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/