From: Alper Nebi Yasak <alpernebiyasak@gmail.com>
To: Simon Glass <sjg@chromium.org>
Cc: Philippe Reynes <philippe.reynes@softathome.com>,
Ivan Mikhaylov <ivan.mikhaylov@siemens.com>,
Peter Geis <pgwipeout@gmail.com>, huang lin <hl@rock-chips.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Kever Yang <kever.yang@rock-chips.com>,
Tom Rini <trini@konsulko.com>,
U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH v3 21/26] binman: Support splitting an ELF file into multiple nodes
Date: Thu, 10 Mar 2022 22:30:59 +0300 [thread overview]
Message-ID: <bb9d366c-cc65-febe-45ef-8382b4e6c859@gmail.com> (raw)
In-Reply-To: <20220306031917.3005215-22-sjg@chromium.org>
On 06/03/2022 06:19, Simon Glass wrote:
> Some boards need to load an ELF file using the 'loadables' property, but
> the file has segments at different memory addresses. This means that it
> cannot be supplied as a flat binary.
>
> Allow generating a separate node in the FIT for each segment in the ELF,
> with a different load address for each.
>
> Also add checks that the fit,xxx directives are valid.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v3:
> - Fix 'segmnet' typo
> - Use seq == 0 instead of 'not seq'
>
> Changes in v2:
> - Rewrite this to use the new FIT entry-type implementation
> - Rename op-tee to tee-os
>
> tools/binman/entries.rst | 146 ++++++++++++
> tools/binman/etype/fit.py | 229 ++++++++++++++++++-
> tools/binman/ftest.py | 147 ++++++++++++
> tools/binman/test/226_fit_split_elf.dts | 67 ++++++
> tools/binman/test/227_fit_bad_dir.dts | 9 +
> tools/binman/test/228_fit_bad_dir_config.dts | 9 +
> 6 files changed, 597 insertions(+), 10 deletions(-)
> create mode 100644 tools/binman/test/226_fit_split_elf.dts
> create mode 100644 tools/binman/test/227_fit_bad_dir.dts
> create mode 100644 tools/binman/test/228_fit_bad_dir_config.dts
I still can't like this enough to add a Reviewed-by, but I guess you'll
apply the series up to and maybe including this, so:
Acked-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
next prev parent reply other threads:[~2022-03-10 19:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-06 3:18 [PATCH v3 00/26] binman: rockchip: Migrate from rockchip SPL_FIT_GENERATOR script Simon Glass
2022-03-06 3:18 ` [PATCH v3 01/26] dtoc: Make GetArgs() more flexible Simon Glass
2022-03-06 3:18 ` [PATCH v3 02/26] moveconfig: Remove remove_defconfig() Simon Glass
2022-03-06 3:18 ` [PATCH v3 03/26] moveconfig: Use re.fullmatch() to avoid extra check Simon Glass
2022-03-06 3:18 ` [PATCH v3 04/26] spl: Correct Kconfig help for TPL_BINMAN_SYMBOLS Simon Glass
2022-03-06 3:18 ` [PATCH v3 05/26] dtoc: Tidy up implementation of AddStringList() Simon Glass
2022-03-19 0:00 ` Simon Glass
2022-03-06 3:18 ` [PATCH v3 06/26] elf: Rename load_segments() and module failure Simon Glass
2022-03-06 3:18 ` [PATCH v3 07/26] binman: Tweak collect_contents_to_file() and docs Simon Glass
2022-03-06 3:18 ` [PATCH v3 08/26] binman: Rename ExpandToLimit to extend_to_limit Simon Glass
2022-03-06 3:19 ` [PATCH v3 09/26] binman: Rename ExpandEntries to gen_entries Simon Glass
2022-03-06 3:19 ` [PATCH v3 10/26] binman: Refactor fit to generate output at the end Simon Glass
2022-03-06 3:19 ` [PATCH v3 11/26] binman: Rename tools parameter to btools Simon Glass
2022-03-06 3:19 ` [PATCH v3 12/26] binman: Change how faked blobs are created Simon Glass
2022-03-06 3:19 ` [PATCH v3 13/26] binman: Make fake blobs zero-sized by default Simon Glass
2022-03-06 3:19 ` [PATCH v3 14/26] binman: Allow mkimage to use a non-zero fake-blob size Simon Glass
2022-03-06 3:19 ` [PATCH v3 15/26] binman: Read the fit entries only once Simon Glass
2022-03-06 3:19 ` [PATCH v3 16/26] binman: Update fit to move node reading into the ReadNode() method Simon Glass
2022-03-10 19:30 ` Alper Nebi Yasak
2022-03-06 3:19 ` [PATCH v3 17/26] binman: Fix some pylint warnings in fit Simon Glass
2022-03-06 3:19 ` [PATCH v3 18/26] binman: Add a consistent way to report errors with fit Simon Glass
2022-03-06 3:19 ` [PATCH v3 19/26] binman: Update fit to use node instead of subnode Simon Glass
2022-03-06 3:19 ` [PATCH v3 20/26] binman: Keep a separate list of entries for fit Simon Glass
2022-03-06 3:19 ` [PATCH v3 21/26] binman: Support splitting an ELF file into multiple nodes Simon Glass
2022-03-10 19:30 ` Alper Nebi Yasak [this message]
2022-03-12 17:59 ` Simon Glass
2022-03-06 3:19 ` [PATCH v3 22/26] rockchip: evb-rk3288: Drop raw-image support Simon Glass
2022-03-10 19:31 ` Alper Nebi Yasak
2022-03-12 5:02 ` Simon Glass
2022-03-14 21:29 ` Alper Nebi Yasak
2022-03-18 22:31 ` Simon Glass
2022-03-06 3:19 ` [PATCH v3 23/26] rockchip: Include binman script in 64-bit boards Simon Glass
2022-03-06 3:19 ` [PATCH v3 24/26] rockchip: Support building the all output files in binman Simon Glass
2022-03-06 3:19 ` [PATCH v3 25/26] rockchip: Convert all boards to use binman Simon Glass
2022-03-06 3:19 ` [PATCH v3 26/26] rockchip: Drop the FIT generator script Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb9d366c-cc65-febe-45ef-8382b4e6c859@gmail.com \
--to=alpernebiyasak@gmail.com \
--cc=hl@rock-chips.com \
--cc=ivan.mikhaylov@siemens.com \
--cc=jeffy.chen@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=pgwipeout@gmail.com \
--cc=philippe.reynes@softathome.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.