From: Thomas Huth <thuth@redhat.com>
To: Taylor Simpson <tsimpson@quicinc.com>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH] Modify tests to work with clang
Date: Mon, 18 Nov 2019 09:52:47 +0100 [thread overview]
Message-ID: <bbad38fa-d2fa-2acd-7f01-eabae34fbc18@redhat.com> (raw)
In-Reply-To: <1574032465-12186-1-git-send-email-tsimpson@quicinc.com>
On 18/11/2019 00.14, Taylor Simpson wrote:
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
> tests/tcg/multiarch/float_helpers.c | 2 --
> tests/tcg/multiarch/linux-test.c | 6 +++++-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/tests/tcg/multiarch/float_helpers.c b/tests/tcg/multiarch/float_helpers.c
> index 8ee7903..bc530e5 100644
> --- a/tests/tcg/multiarch/float_helpers.c
> +++ b/tests/tcg/multiarch/float_helpers.c
> @@ -79,11 +79,9 @@ char *fmt_16(uint16_t num)
>
> #ifndef SNANF
> /* Signaling NaN macros, if supported. */
> -# if __GNUC_PREREQ(3, 3)
> # define SNANF (__builtin_nansf (""))
> # define SNAN (__builtin_nans (""))
> # define SNANL (__builtin_nansl (""))
> -# endif
> #endif
>
> static float f32_numbers[] = {
> diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c
> index 673d7c8..8a7c15c 100644
> --- a/tests/tcg/multiarch/linux-test.c
> +++ b/tests/tcg/multiarch/linux-test.c
> @@ -485,7 +485,11 @@ static void test_signal(void)
> act.sa_flags = SA_SIGINFO;
> chk_error(sigaction(SIGSEGV, &act, NULL));
> if (setjmp(jmp_env) == 0) {
> - *(uint8_t *)0 = 0;
> + /*
> + * clang requires volatile or it will turn this into a
> + * call to abort() instead of forcing a SIGSEGV.
> + */
> + *(volatile uint8_t *)0 = 0;
> }
>
> act.sa_handler = SIG_DFL;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Taylor Simpson <tsimpson@quicinc.com>, qemu-devel@nongnu.org
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, alex.bennee@linaro.org
Subject: Re: [PATCH] Modify tests to work with clang
Date: Mon, 18 Nov 2019 09:52:47 +0100 [thread overview]
Message-ID: <bbad38fa-d2fa-2acd-7f01-eabae34fbc18@redhat.com> (raw)
In-Reply-To: <1574032465-12186-1-git-send-email-tsimpson@quicinc.com>
On 18/11/2019 00.14, Taylor Simpson wrote:
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
> tests/tcg/multiarch/float_helpers.c | 2 --
> tests/tcg/multiarch/linux-test.c | 6 +++++-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/tests/tcg/multiarch/float_helpers.c b/tests/tcg/multiarch/float_helpers.c
> index 8ee7903..bc530e5 100644
> --- a/tests/tcg/multiarch/float_helpers.c
> +++ b/tests/tcg/multiarch/float_helpers.c
> @@ -79,11 +79,9 @@ char *fmt_16(uint16_t num)
>
> #ifndef SNANF
> /* Signaling NaN macros, if supported. */
> -# if __GNUC_PREREQ(3, 3)
> # define SNANF (__builtin_nansf (""))
> # define SNAN (__builtin_nans (""))
> # define SNANL (__builtin_nansl (""))
> -# endif
> #endif
>
> static float f32_numbers[] = {
> diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c
> index 673d7c8..8a7c15c 100644
> --- a/tests/tcg/multiarch/linux-test.c
> +++ b/tests/tcg/multiarch/linux-test.c
> @@ -485,7 +485,11 @@ static void test_signal(void)
> act.sa_flags = SA_SIGINFO;
> chk_error(sigaction(SIGSEGV, &act, NULL));
> if (setjmp(jmp_env) == 0) {
> - *(uint8_t *)0 = 0;
> + /*
> + * clang requires volatile or it will turn this into a
> + * call to abort() instead of forcing a SIGSEGV.
> + */
> + *(volatile uint8_t *)0 = 0;
> }
>
> act.sa_handler = SIG_DFL;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-11-18 8:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 23:14 [PATCH] Modify tests to work with clang Taylor Simpson
2019-11-18 8:52 ` Thomas Huth [this message]
2019-11-18 8:52 ` Thomas Huth
2019-11-18 9:17 ` Richard Henderson
2019-11-18 11:48 ` Alex Bennée
-- strict thread matches above, loose matches on Subject: below --
2019-11-15 4:38 Taylor Simpson
2019-11-15 5:51 ` no-reply
2019-11-15 7:23 ` Thomas Huth
2019-11-15 12:17 ` Alex Bennée
2019-11-15 14:14 ` Taylor Simpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbad38fa-d2fa-2acd-7f01-eabae34fbc18@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.