From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-wireless-owner@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
ath10k@lists.infradead.org,
"David S. Miller" <davem@davemloft.net>,
Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH v2] ath10k: Replace zero-length array with flexible-array
Date: Thu, 07 May 2020 13:54:56 -0700 [thread overview]
Message-ID: <bbb33f11e8aaf6d482f923aee22aca39@codeaurora.org> (raw)
In-Reply-To: <20200507041127.GA31587@embeddedor>
On 2020-05-06 21:11, Gustavo A. R. Silva wrote:
[...]
> static inline struct htt_stats_conf_item *htt_stats_conf_next_item(
> @@ -1674,7 +1674,7 @@ struct htt_tx_fetch_ind {
> __le16 num_resp_ids;
> __le16 num_records;
> struct htt_tx_fetch_record records[0];
> - __le32 resp_ids[0]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
> + __le32 resp_ids[]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
> } __packed;
>
Missed to handle records[0].
-Rajkumar
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: Replace zero-length array with flexible-array
Date: Thu, 07 May 2020 13:54:56 -0700 [thread overview]
Message-ID: <bbb33f11e8aaf6d482f923aee22aca39@codeaurora.org> (raw)
In-Reply-To: <20200507041127.GA31587@embeddedor>
On 2020-05-06 21:11, Gustavo A. R. Silva wrote:
[...]
> static inline struct htt_stats_conf_item *htt_stats_conf_next_item(
> @@ -1674,7 +1674,7 @@ struct htt_tx_fetch_ind {
> __le16 num_resp_ids;
> __le16 num_records;
> struct htt_tx_fetch_record records[0];
> - __le32 resp_ids[0]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
> + __le32 resp_ids[]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
> } __packed;
>
Missed to handle records[0].
-Rajkumar
next prev parent reply other threads:[~2020-05-07 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 4:11 [PATCH v2] ath10k: Replace zero-length array with flexible-array Gustavo A. R. Silva
2020-05-07 4:11 ` Gustavo A. R. Silva
2020-05-07 20:54 ` Rajkumar Manoharan [this message]
2020-05-07 20:54 ` Rajkumar Manoharan
2020-05-11 12:37 ` Kalle Valo
2020-05-11 12:37 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbb33f11e8aaf6d482f923aee22aca39@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.