* [PATCH -perfbook] bib/perfmeas: Fix doi of McKenney99b
@ 2022-01-21 13:32 Akira Yokosawa
2022-01-21 14:16 ` Zhouyi Zhou
2022-01-23 23:44 ` Akira Yokosawa
0 siblings, 2 replies; 4+ messages in thread
From: Akira Yokosawa @ 2022-01-21 13:32 UTC (permalink / raw)
To: Paul E. McKenney, Zhouyi Zhou; +Cc: perfbook, Akira Yokosawa
Escape sequences of "%3C" and "%3E" in doi cause a build error when
"inlinelinks" option in alphapf.bst is set #0 (URLs explicit).
Fix the error by using non-escaped symbols of "<" and ">" instead.
Fixes: 62c6a33781d9 ("bib: url/doi updates")
Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
---
Hi Zhouyi,
Prompted by your patch "RFC: make some bibliography items better",
I tested an option in alphapf.bst (bibliography style file of
perfbook), namely "inlinelinks".
By setting "#0" to inlinelink (URLs explicit), URL and DOI info
in .bib files should be printed in Bibliography.
However, the build failed with McKenney99b.
This patch should fix the build error.
You still need to manually edit alphapf.bst, but please try
setting "#0" to inlinelink.
As you will see, if a bibliography has DOI info, URL info in
the note field is redundant when the URL is the one reachable
via the DOI.
Thanks, Akira
--
bib/perfmeas.bib | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bib/perfmeas.bib b/bib/perfmeas.bib
index 9ba80cfc..51f63bb7 100644
--- a/bib/perfmeas.bib
+++ b/bib/perfmeas.bib
@@ -83,7 +83,7 @@ Machine Language Rewriting",
year = {1999},
pages = {219-234},
bibsource = {DBLP, http://dblp.uni-trier.de},
- doi = {10.1002/(SICI)1097-024X(199903)29:3%3C219::AID-SPE230%3E3.0.CO;2-0}
+ doi = {10.1002/(SICI)1097-024X(199903)29:3<219::AID-SPE230>3.0.CO;2-0}
}
@Book{Menasce94,
base-commit: cd891db680ae978f5efa362cbdc074483f07042a
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -perfbook] bib/perfmeas: Fix doi of McKenney99b
2022-01-21 13:32 [PATCH -perfbook] bib/perfmeas: Fix doi of McKenney99b Akira Yokosawa
@ 2022-01-21 14:16 ` Zhouyi Zhou
2022-01-23 23:44 ` Akira Yokosawa
1 sibling, 0 replies; 4+ messages in thread
From: Zhouyi Zhou @ 2022-01-21 14:16 UTC (permalink / raw)
To: Akira Yokosawa; +Cc: Paul E. McKenney, perfbook
Thank Akira for your elaborate master work!
1. I edited the alphapf.bst, setting "#0" to inlinelink
2. apply the patch to perfmeas.bib
3. invoke "make clean" (this step is necessary if I have invoked "make" before)
4. invoke "make", and it works!
I will prepare a revised version of my patch later today.
Many thanks
Sincerely
Zhouyi
On Fri, Jan 21, 2022 at 9:32 PM Akira Yokosawa <akiyks@gmail.com> wrote:
>
> Escape sequences of "%3C" and "%3E" in doi cause a build error when
> "inlinelinks" option in alphapf.bst is set #0 (URLs explicit).
>
> Fix the error by using non-escaped symbols of "<" and ">" instead.
>
> Fixes: 62c6a33781d9 ("bib: url/doi updates")
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> ---
> Hi Zhouyi,
>
> Prompted by your patch "RFC: make some bibliography items better",
> I tested an option in alphapf.bst (bibliography style file of
> perfbook), namely "inlinelinks".
> By setting "#0" to inlinelink (URLs explicit), URL and DOI info
> in .bib files should be printed in Bibliography.
>
> However, the build failed with McKenney99b.
>
> This patch should fix the build error.
>
> You still need to manually edit alphapf.bst, but please try
> setting "#0" to inlinelink.
>
> As you will see, if a bibliography has DOI info, URL info in
> the note field is redundant when the URL is the one reachable
> via the DOI.
>
> Thanks, Akira
> --
> bib/perfmeas.bib | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bib/perfmeas.bib b/bib/perfmeas.bib
> index 9ba80cfc..51f63bb7 100644
> --- a/bib/perfmeas.bib
> +++ b/bib/perfmeas.bib
> @@ -83,7 +83,7 @@ Machine Language Rewriting",
> year = {1999},
> pages = {219-234},
> bibsource = {DBLP, http://dblp.uni-trier.de},
> - doi = {10.1002/(SICI)1097-024X(199903)29:3%3C219::AID-SPE230%3E3.0.CO;2-0}
> + doi = {10.1002/(SICI)1097-024X(199903)29:3<219::AID-SPE230>3.0.CO;2-0}
> }
>
> @Book{Menasce94,
>
> base-commit: cd891db680ae978f5efa362cbdc074483f07042a
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -perfbook] bib/perfmeas: Fix doi of McKenney99b
2022-01-21 13:32 [PATCH -perfbook] bib/perfmeas: Fix doi of McKenney99b Akira Yokosawa
2022-01-21 14:16 ` Zhouyi Zhou
@ 2022-01-23 23:44 ` Akira Yokosawa
2022-01-24 0:18 ` Paul E. McKenney
1 sibling, 1 reply; 4+ messages in thread
From: Akira Yokosawa @ 2022-01-23 23:44 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: perfbook, Zhouyi Zhou, Akira Yokosawa
On Fri, 21 Jan 2022 22:32:13 +0900, Akira Yokosawa wrote:
> Escape sequences of "%3C" and "%3E" in doi cause a build error when
> "inlinelinks" option in alphapf.bst is set #0 (URLs explicit).
>
> Fix the error by using non-escaped symbols of "<" and ">" instead.
>
> Fixes: 62c6a33781d9 ("bib: url/doi updates")
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
Paul,
You might be confused but I expected you would apply this fix as
well.
Thanks, Akira
> ---
> Hi Zhouyi,
>
> Prompted by your patch "RFC: make some bibliography items better",
> I tested an option in alphapf.bst (bibliography style file of
> perfbook), namely "inlinelinks".
> By setting "#0" to inlinelink (URLs explicit), URL and DOI info
> in .bib files should be printed in Bibliography.
>
> However, the build failed with McKenney99b.
>
> This patch should fix the build error.
>
> You still need to manually edit alphapf.bst, but please try
> setting "#0" to inlinelink.
>
> As you will see, if a bibliography has DOI info, URL info in
> the note field is redundant when the URL is the one reachable
> via the DOI.
>
> Thanks, Akira
> --
> bib/perfmeas.bib | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bib/perfmeas.bib b/bib/perfmeas.bib
> index 9ba80cfc..51f63bb7 100644
> --- a/bib/perfmeas.bib
> +++ b/bib/perfmeas.bib
> @@ -83,7 +83,7 @@ Machine Language Rewriting",
> year = {1999},
> pages = {219-234},
> bibsource = {DBLP, http://dblp.uni-trier.de},
> - doi = {10.1002/(SICI)1097-024X(199903)29:3%3C219::AID-SPE230%3E3.0.CO;2-0}
> + doi = {10.1002/(SICI)1097-024X(199903)29:3<219::AID-SPE230>3.0.CO;2-0}
> }
>
> @Book{Menasce94,
>
> base-commit: cd891db680ae978f5efa362cbdc074483f07042a
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -perfbook] bib/perfmeas: Fix doi of McKenney99b
2022-01-23 23:44 ` Akira Yokosawa
@ 2022-01-24 0:18 ` Paul E. McKenney
0 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2022-01-24 0:18 UTC (permalink / raw)
To: Akira Yokosawa; +Cc: perfbook, Zhouyi Zhou
On Mon, Jan 24, 2022 at 08:44:17AM +0900, Akira Yokosawa wrote:
> On Fri, 21 Jan 2022 22:32:13 +0900, Akira Yokosawa wrote:
> > Escape sequences of "%3C" and "%3E" in doi cause a build error when
> > "inlinelinks" option in alphapf.bst is set #0 (URLs explicit).
> >
> > Fix the error by using non-escaped symbols of "<" and ">" instead.
> >
> > Fixes: 62c6a33781d9 ("bib: url/doi updates")
> > Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
>
> Paul,
>
> You might be confused but I expected you would apply this fix as
> well.
You are quite right, I was confused! I am not sure why I was confused,
but whatever the reason, I have now queued and pushed this patch.
Thank you both for the patch and for the reminder!
Thanx, Paul
> Thanks, Akira
>
> > ---
> > Hi Zhouyi,
> >
> > Prompted by your patch "RFC: make some bibliography items better",
> > I tested an option in alphapf.bst (bibliography style file of
> > perfbook), namely "inlinelinks".
> > By setting "#0" to inlinelink (URLs explicit), URL and DOI info
> > in .bib files should be printed in Bibliography.
> >
> > However, the build failed with McKenney99b.
> >
> > This patch should fix the build error.
> >
> > You still need to manually edit alphapf.bst, but please try
> > setting "#0" to inlinelink.
> >
> > As you will see, if a bibliography has DOI info, URL info in
> > the note field is redundant when the URL is the one reachable
> > via the DOI.
> >
> > Thanks, Akira
> > --
> > bib/perfmeas.bib | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/bib/perfmeas.bib b/bib/perfmeas.bib
> > index 9ba80cfc..51f63bb7 100644
> > --- a/bib/perfmeas.bib
> > +++ b/bib/perfmeas.bib
> > @@ -83,7 +83,7 @@ Machine Language Rewriting",
> > year = {1999},
> > pages = {219-234},
> > bibsource = {DBLP, http://dblp.uni-trier.de},
> > - doi = {10.1002/(SICI)1097-024X(199903)29:3%3C219::AID-SPE230%3E3.0.CO;2-0}
> > + doi = {10.1002/(SICI)1097-024X(199903)29:3<219::AID-SPE230>3.0.CO;2-0}
> > }
> >
> > @Book{Menasce94,
> >
> > base-commit: cd891db680ae978f5efa362cbdc074483f07042a
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-24 0:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-21 13:32 [PATCH -perfbook] bib/perfmeas: Fix doi of McKenney99b Akira Yokosawa
2022-01-21 14:16 ` Zhouyi Zhou
2022-01-23 23:44 ` Akira Yokosawa
2022-01-24 0:18 ` Paul E. McKenney
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.