Re: [RFC PATCH v4 3/5] drm/xe: use xe_ras_log_wedged macro in xe_device_declare_wedged

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 6/30/2026 1:55 PM, Mallesh Koujalagi wrote:
> Replace the open-coded drm_err() call with xe_ras_log_wedged()
> macro so that wedge events are reported through the unified
> RAS/SIG logging path with a consistent format, CPER severity,
> and errno.
> 
> Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
> v2:
> - Rebase.
> 
> v3:
> - Update message in xe_ras_log_wedged().
> 
> v4:
> - Replace XE_RAS_WEDGED to xe_ras_log_wedged. (Dnyaneshwar)
> ---
>  drivers/gpu/drm/xe/xe_device.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index b6e49309a99f..7538ac7c7dfb 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -62,6 +62,7 @@
>  #include "xe_pxp.h"
>  #include "xe_query.h"
>  #include "xe_ras.h"
> +#include "xe_ras_log.h"
>  #include "xe_shrinker.h"
>  #include "xe_soc_remapper.h"
>  #include "xe_survivability_mode.h"
> @@ -1428,12 +1429,12 @@ void xe_device_declare_wedged(struct xe_device *xe)
>  	if (!atomic_xchg(&xe->wedged.flag, 1)) {
>  		xe->needs_flr_on_fini = true;
>  		xe_pm_runtime_get_noresume(xe);
> -		drm_err(&xe->drm,
> -			"CRITICAL: Xe has declared device %s as wedged.\n"
> -			"IOCTLs and executions are blocked.\n"
> -			"For recovery procedure, refer to https://docs.kernel.org/gpu/drm-uapi.html#device-wedging\n"
> -			"Please file a _new_ bug report at https://gitlab.freedesktop.org/drm/xe/kernel/issues/new\n",
> -			dev_name(xe->drm.dev));
> +		xe_ras_log_wedged(xe, -EIO,

are you sure that this errno is always correct/sufficient?
there might be different recovery methods suggested by the driver
maybe at least you want to correlate this errno with available recovery method?

> +				  "CRITICAL: Xe has declared device %s as wedged.\n"

"CRITICAL" word seems to be redundant as this error will be already tagged with the "FATAL" tag

also printing device name again is not needed as drm_err is based on dev_err which already prints that

> +				  "IOCTLs and executions are blocked.\n"
> +				  "For recovery procedure, refer to https://docs.kernel.org/gpu/drm-uapi.html#device-wedging\n"

one of the goals of this new error reporting mechanism was to provide consistent guidelines and remediation based on the error signature

so where these guidelines will be published ? maybe on the first "structured" error we should also print some hint where to look for help?

how will we make sure those new guidelines are aligned with the above mentioned recovery procedure?

> +				  "Please file a _new_ bug report at https://gitlab.freedesktop.org/drm/xe/kernel/issues/new\n",
> +				  dev_name(xe->drm.dev));
>  	}
>  
>  	for_each_gt(gt, xe, id)