Re: [RFC PATCH v4 4/5] drm/xe: Use RAS logging to report survivability mode

["Tauro, Riana" <riana.tauro@intel.com>]

On 30-06-2026 17:25, Mallesh Koujalagi wrote:
> Replace dev_err() calls with xe_ras_log_survivability() so
> survivability events are reported through the structured RAS logging
> path with a consistent format.

How about sysfs creation failure? Is that not required?

> Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_survivability_mode.c | 11 ++++++-----
>   1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
> index 427afd144f3a..a58d46f67677 100644
> --- a/drivers/gpu/drm/xe/xe_survivability_mode.c
> +++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
> @@ -17,6 +17,7 @@
>   #include "xe_mmio.h"
>   #include "xe_nvm.h"
>   #include "xe_pcode_api.h"
> +#include "xe_ras_log.h"
>   #include "xe_vsec.h"
>   
>   /**
> @@ -307,7 +308,6 @@ static int create_survivability_sysfs(struct pci_dev *pdev)
>   
>   static int enable_boot_survivability_mode(struct pci_dev *pdev)
>   {
> -	struct device *dev = &pdev->dev;
>   	struct xe_device *xe = pdev_to_xe_device(pdev);
>   	struct xe_survivability *survivability = &xe->survivability;
>   	int ret = 0;
> @@ -333,12 +333,12 @@ static int enable_boot_survivability_mode(struct pci_dev *pdev)
>   	if (ret)
>   		goto err;
>   
> -	dev_err(dev, "In Survivability Mode\n");
> +	xe_ras_log_survivability(xe, 0, "Boot Survivability Mode enabled\n");
>   
>   	return 0;
>   
>   err:
> -	dev_err(dev, "Failed to enable Survivability Mode\n");
> +	xe_ras_log_survivability(xe, ret, "Failed to enable Boot Survivability Mode\n");
>   	survivability->mode = false;
>   	return ret;
>   }
> @@ -413,11 +413,12 @@ void xe_survivability_mode_runtime_enable(struct xe_device *xe)
>   		dev_err(&pdev->dev, "Failed to create survivability sysfs\n");
>   
>   	survivability->type = XE_SURVIVABILITY_TYPE_RUNTIME;
> -	dev_err(&pdev->dev, "Runtime Survivability mode enabled\n");
> +	xe_ras_log_survivability(xe, -EIO,
> +				 "Runtime Survivability Mode enabled, firmware flash required.\n"
> +				 "Please refer to the userspace documentation for more details!\n");

Why do we need error code here and not in boot survivability?
Also what is the purpose of this error code?

Thanks
Riana


>   
>   	xe_device_set_wedged_method(xe, DRM_WEDGE_RECOVERY_VENDOR);
>   	xe_device_declare_wedged(xe);
> -	dev_err(&pdev->dev, "Firmware flash required, Please refer to the userspace documentation for more details!\n");
>   }
>   
>   /**