All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] remoteproc: qcom_q6v5_mss: Save the need_pas_mem_setup into qproc
@ 2026-11-17 19:51 ` David Heidelberg
  0 siblings, 0 replies; 3+ messages in thread
From: David Heidelberg via B4 Relay @ 2026-11-17 19:51 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Barnabás Czémán,
	Konrad Dybcio, Bryan O'Donoghue
  Cc: linux-arm-msm, linux-remoteproc, linux-kernel, Sashiko,
	David Heidelberg

From: David Heidelberg <david@ixit.cz>

On hardware requiring Peripheral Authentication Service (PAS) for modem
memory setup (e.g., SDM632), the remoteproc subsystem skips hardware memory
authentication because q6v5_probe() fails to copy the need_pas_mem_setup
flag to the allocated device instance.

Original commit didn't save the value into the structure thus quietly
skipping if (qproc->need_pas_mem_setup) condition.

Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://sashiko.dev/#/bug/linux-83fcbc28-236c-48e4-a6bd-731f4361f9ae
Fixes: f56052f4d87c ("remoteproc: qcom_q6v5_mss: Introduce need_pas_mem_setup")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 drivers/remoteproc/qcom_q6v5_mss.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
index dd052a62b8583..5d084aa2eac36 100644
--- a/drivers/remoteproc/qcom_q6v5_mss.c
+++ b/drivers/remoteproc/qcom_q6v5_mss.c
@@ -2189,16 +2189,17 @@ static int q6v5_probe(struct platform_device *pdev)
 
 	qproc->has_alt_reset = desc->has_alt_reset;
 	ret = q6v5_init_reset(qproc);
 	if (ret)
 		goto detach_proxy_pds;
 
 	qproc->version = desc->version;
 	qproc->need_mem_protection = desc->need_mem_protection;
+	qproc->need_pas_mem_setup = desc->need_pas_mem_setup;
 	qproc->has_mba_logs = desc->has_mba_logs;
 
 	ret = qcom_q6v5_init(&qproc->q6v5, pdev, rproc, MPSS_CRASH_REASON_SMEM, "modem",
 			     qcom_msa_handover);
 	if (ret)
 		goto detach_proxy_pds;
 
 	qproc->mpss_perm = BIT(QCOM_SCM_VMID_HLOS);

---
base-commit: aaa2f954c21b205a0bcd0961e5b2be4e82e58455
change-id: 20261117-qcom_q6v5_mss_msm8953-aba81523223b

Best regards,
--  
David Heidelberg <david@ixit.cz>



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-21 13:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 19:51 [PATCH] remoteproc: qcom_q6v5_mss: Save the need_pas_mem_setup into qproc David Heidelberg via B4 Relay
2026-11-17 19:51 ` David Heidelberg
2026-11-21 13:04 ` Barnabás Czémán

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.