From: <Codrin.Ciubotariu@microchip.com>
To: mirq-linux@rere.qmqm.pl, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org
Cc: alexandre.belloni@bootlin.com, arnd@arndb.de, 3chas3@gmail.com,
gregkh@linuxfoundation.org, perex@perex.cz, lgirdwood@gmail.com,
Ludovic.Desroches@microchip.com, broonie@kernel.org,
mark.rutland@arm.com, Nicolas.Ferre@microchip.com,
robh-dt@kernel.org, tiwai@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] ASoC: atmel_ssc_dai: implement left-justified data mode
Date: Mon, 26 Aug 2019 14:10:41 +0000 [thread overview]
Message-ID: <bcb80163-e08a-e46c-6632-10cee3255642@microchip.com> (raw)
In-Reply-To: <44fa6b700421e80778f20ff9ead2b148cf6d2e92.1566677788.git.mirq-linux@rere.qmqm.pl>
> Enable support for left-justified data mode for SSC-codec link.
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
>
> ---
> v2: rebased
I noticed you also added a description and you removed two comments from
v1. Please include all the changes in the changelog.
I already added my 'Reviewed-by' in v1, but since there are some more
changes from the previous version:
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks and best regards,
Codrin
>
> ---
> sound/soc/atmel/atmel_ssc_dai.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
> index 7dc6ec9b8c7a..48e9eef34c0f 100644
> --- a/sound/soc/atmel/atmel_ssc_dai.c
> +++ b/sound/soc/atmel/atmel_ssc_dai.c
> @@ -564,6 +564,15 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream,
>
> switch (ssc_p->daifmt & SND_SOC_DAIFMT_FORMAT_MASK) {
>
> + case SND_SOC_DAIFMT_LEFT_J:
> + fs_osync = SSC_FSOS_POSITIVE;
> + fs_edge = SSC_START_RISING_RF;
> +
> + rcmr = SSC_BF(RCMR_STTDLY, 0);
> + tcmr = SSC_BF(TCMR_STTDLY, 0);
> +
> + break;
> +
> case SND_SOC_DAIFMT_I2S:
> fs_osync = SSC_FSOS_NEGATIVE;
> fs_edge = SSC_START_FALLING_RF;
>
WARNING: multiple messages have this Message-ID (diff)
From: <Codrin.Ciubotariu@microchip.com>
To: <mirq-linux@rere.qmqm.pl>, <alsa-devel@alsa-project.org>,
<devicetree@vger.kernel.org>
Cc: <alexandre.belloni@bootlin.com>, <arnd@arndb.de>,
<3chas3@gmail.com>, <gregkh@linuxfoundation.org>,
<perex@perex.cz>, <lgirdwood@gmail.com>,
<Ludovic.Desroches@microchip.com>, <broonie@kernel.org>,
<mark.rutland@arm.com>, <Nicolas.Ferre@microchip.com>,
<robh-dt@kernel.org>, <tiwai@suse.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/6] ASoC: atmel_ssc_dai: implement left-justified data mode
Date: Mon, 26 Aug 2019 14:10:41 +0000 [thread overview]
Message-ID: <bcb80163-e08a-e46c-6632-10cee3255642@microchip.com> (raw)
In-Reply-To: <44fa6b700421e80778f20ff9ead2b148cf6d2e92.1566677788.git.mirq-linux@rere.qmqm.pl>
> Enable support for left-justified data mode for SSC-codec link.
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
>
> ---
> v2: rebased
I noticed you also added a description and you removed two comments from
v1. Please include all the changes in the changelog.
I already added my 'Reviewed-by' in v1, but since there are some more
changes from the previous version:
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks and best regards,
Codrin
>
> ---
> sound/soc/atmel/atmel_ssc_dai.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
> index 7dc6ec9b8c7a..48e9eef34c0f 100644
> --- a/sound/soc/atmel/atmel_ssc_dai.c
> +++ b/sound/soc/atmel/atmel_ssc_dai.c
> @@ -564,6 +564,15 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream,
>
> switch (ssc_p->daifmt & SND_SOC_DAIFMT_FORMAT_MASK) {
>
> + case SND_SOC_DAIFMT_LEFT_J:
> + fs_osync = SSC_FSOS_POSITIVE;
> + fs_edge = SSC_START_RISING_RF;
> +
> + rcmr = SSC_BF(RCMR_STTDLY, 0);
> + tcmr = SSC_BF(TCMR_STTDLY, 0);
> +
> + break;
> +
> case SND_SOC_DAIFMT_I2S:
> fs_osync = SSC_FSOS_NEGATIVE;
> fs_edge = SSC_START_FALLING_RF;
>
next prev parent reply other threads:[~2019-08-26 14:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 20:26 [PATCH v2 0/6] ] ASoC: atmel: extend SSC support Michał Mirosław
2019-08-24 20:26 ` [PATCH v2 1/6] ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig Michał Mirosław
2019-08-26 13:45 ` Codrin.Ciubotariu
2019-08-26 13:45 ` Codrin.Ciubotariu
2019-08-26 14:23 ` Alexandre Belloni
2019-08-24 20:26 ` [PATCH v2 2/6] ASoC: atmel_ssc_dai: rework DAI format configuration Michał Mirosław
2019-08-26 14:04 ` Codrin.Ciubotariu
2019-08-26 14:04 ` Codrin.Ciubotariu
2019-08-24 20:26 ` [PATCH v2 3/6] ASoC: atmel_ssc_dai: implement left-justified data mode Michał Mirosław
2019-08-26 14:10 ` Codrin.Ciubotariu [this message]
2019-08-26 14:10 ` Codrin.Ciubotariu
2019-08-24 20:26 ` [PATCH v2 4/6] dt-bindings: misc: atmel-ssc: LRCLK from TF/RF pin option Michał Mirosław
2019-08-27 22:37 ` Rob Herring
2019-08-28 13:02 ` Michał Mirosław
2019-08-28 18:34 ` Rob Herring
2019-08-24 20:26 ` [PATCH v2 5/6] misc: atmel-ssc: get LRCLK pin selection from DT Michał Mirosław
2019-08-26 14:38 ` Codrin.Ciubotariu
2019-08-26 14:38 ` Codrin.Ciubotariu
2019-08-24 20:26 ` [PATCH v2 6/6] ASoC: atmel_ssc_dai: Enable shared FSYNC source in frame-slave mode Michał Mirosław
2019-08-26 15:05 ` Codrin.Ciubotariu
2019-08-26 15:05 ` Codrin.Ciubotariu
2019-09-08 13:39 ` [alsa-devel] " mirq-linux
2019-09-08 13:39 ` mirq-linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcb80163-e08a-e46c-6632-10cee3255642@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=3chas3@gmail.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=perex@perex.cz \
--cc=robh-dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.