* [PATCH] arm64: ipi_teardown() should depend on HOTPLUG_CPU
@ 2020-09-18 15:35 ` Sergey Senozhatsky
0 siblings, 0 replies; 8+ messages in thread
From: Sergey Senozhatsky @ 2020-09-18 15:35 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: Marc Zyngier, linux-kernel, linux-arm-kernel, Sergey Senozhatsky
ipi_teardown() is used only when CONFIG_HOTPLUG_CPU is set.
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
arch/arm64/kernel/smp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index b6bde2675ccc..82e75fc2c903 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -82,9 +82,9 @@ static int nr_ipi __read_mostly = NR_IPI;
static struct irq_desc *ipi_desc[NR_IPI] __read_mostly;
static void ipi_setup(int cpu);
-static void ipi_teardown(int cpu);
#ifdef CONFIG_HOTPLUG_CPU
+static void ipi_teardown(int cpu);
static int op_cpu_kill(unsigned int cpu);
#else
static inline int op_cpu_kill(unsigned int cpu)
@@ -964,6 +964,7 @@ static void ipi_setup(int cpu)
enable_percpu_irq(ipi_irq_base + i, 0);
}
+#ifdef CONFIG_HOTPLUG_CPU
static void ipi_teardown(int cpu)
{
int i;
@@ -974,6 +975,7 @@ static void ipi_teardown(int cpu)
for (i = 0; i < nr_ipi; i++)
disable_percpu_irq(ipi_irq_base + i);
}
+#endif
void __init set_smp_ipi_range(int ipi_base, int n)
{
--
2.28.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] arm64: ipi_teardown() should depend on HOTPLUG_CPU
@ 2020-09-18 15:35 ` Sergey Senozhatsky
0 siblings, 0 replies; 8+ messages in thread
From: Sergey Senozhatsky @ 2020-09-18 15:35 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: Marc Zyngier, linux-arm-kernel, linux-kernel, Sergey Senozhatsky
ipi_teardown() is used only when CONFIG_HOTPLUG_CPU is set.
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
---
arch/arm64/kernel/smp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index b6bde2675ccc..82e75fc2c903 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -82,9 +82,9 @@ static int nr_ipi __read_mostly = NR_IPI;
static struct irq_desc *ipi_desc[NR_IPI] __read_mostly;
static void ipi_setup(int cpu);
-static void ipi_teardown(int cpu);
#ifdef CONFIG_HOTPLUG_CPU
+static void ipi_teardown(int cpu);
static int op_cpu_kill(unsigned int cpu);
#else
static inline int op_cpu_kill(unsigned int cpu)
@@ -964,6 +964,7 @@ static void ipi_setup(int cpu)
enable_percpu_irq(ipi_irq_base + i, 0);
}
+#ifdef CONFIG_HOTPLUG_CPU
static void ipi_teardown(int cpu)
{
int i;
@@ -974,6 +975,7 @@ static void ipi_teardown(int cpu)
for (i = 0; i < nr_ipi; i++)
disable_percpu_irq(ipi_irq_base + i);
}
+#endif
void __init set_smp_ipi_range(int ipi_base, int n)
{
--
2.28.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] arm64: ipi_teardown() should depend on HOTPLUG_CPU
2020-09-18 15:35 ` Sergey Senozhatsky
@ 2020-09-18 15:41 ` Will Deacon
-1 siblings, 0 replies; 8+ messages in thread
From: Will Deacon @ 2020-09-18 15:41 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: Catalin Marinas, linux-kernel, linux-arm-kernel, Marc Zyngier
On Sat, Sep 19, 2020 at 12:35:48AM +0900, Sergey Senozhatsky wrote:
> ipi_teardown() is used only when CONFIG_HOTPLUG_CPU is set.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---
> arch/arm64/kernel/smp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
I think this is a duplicate of:
https://lore.kernel.org/r/20200918123318.23764-1-yuehaibing@huawei.com
which Marc is aware of (and I'm assuming he'll fix it in his series).
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm64: ipi_teardown() should depend on HOTPLUG_CPU
@ 2020-09-18 15:41 ` Will Deacon
0 siblings, 0 replies; 8+ messages in thread
From: Will Deacon @ 2020-09-18 15:41 UTC (permalink / raw)
To: Sergey Senozhatsky
Cc: Catalin Marinas, Marc Zyngier, linux-arm-kernel, linux-kernel
On Sat, Sep 19, 2020 at 12:35:48AM +0900, Sergey Senozhatsky wrote:
> ipi_teardown() is used only when CONFIG_HOTPLUG_CPU is set.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---
> arch/arm64/kernel/smp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
I think this is a duplicate of:
https://lore.kernel.org/r/20200918123318.23764-1-yuehaibing@huawei.com
which Marc is aware of (and I'm assuming he'll fix it in his series).
Will
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm64: ipi_teardown() should depend on HOTPLUG_CPU
2020-09-18 15:41 ` Will Deacon
@ 2020-09-18 16:07 ` Marc Zyngier
-1 siblings, 0 replies; 8+ messages in thread
From: Marc Zyngier @ 2020-09-18 16:07 UTC (permalink / raw)
To: Will Deacon, Sergey Senozhatsky
Cc: Catalin Marinas, linux-kernel, linux-arm-kernel
On 2020-09-18 16:41, Will Deacon wrote:
> On Sat, Sep 19, 2020 at 12:35:48AM +0900, Sergey Senozhatsky wrote:
>> ipi_teardown() is used only when CONFIG_HOTPLUG_CPU is set.
>>
>> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>> ---
>> arch/arm64/kernel/smp.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> I think this is a duplicate of:
>
>
> https://lore.kernel.org/r/20200918123318.23764-1-yuehaibing@huawei.com
>
> which Marc is aware of (and I'm assuming he'll fix it in his series).
Indeed. Applied and pushed out. Thanks though!
M. (about to fix the same issue with arch/arm...)
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] arm64: ipi_teardown() should depend on HOTPLUG_CPU
@ 2020-09-18 16:07 ` Marc Zyngier
0 siblings, 0 replies; 8+ messages in thread
From: Marc Zyngier @ 2020-09-18 16:07 UTC (permalink / raw)
To: Will Deacon, Sergey Senozhatsky
Cc: Catalin Marinas, linux-arm-kernel, linux-kernel
On 2020-09-18 16:41, Will Deacon wrote:
> On Sat, Sep 19, 2020 at 12:35:48AM +0900, Sergey Senozhatsky wrote:
>> ipi_teardown() is used only when CONFIG_HOTPLUG_CPU is set.
>>
>> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
>> ---
>> arch/arm64/kernel/smp.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> I think this is a duplicate of:
>
>
> https://lore.kernel.org/r/20200918123318.23764-1-yuehaibing@huawei.com
>
> which Marc is aware of (and I'm assuming he'll fix it in his series).
Indeed. Applied and pushed out. Thanks though!
M. (about to fix the same issue with arch/arm...)
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] arm64: ipi_teardown() should depend on HOTPLUG_CPU
2020-09-18 16:07 ` Marc Zyngier
@ 2020-09-18 23:13 ` Sergey Senozhatsky
-1 siblings, 0 replies; 8+ messages in thread
From: Sergey Senozhatsky @ 2020-09-18 23:13 UTC (permalink / raw)
To: Marc Zyngier
Cc: Sergey Senozhatsky, Will Deacon, linux-kernel, linux-arm-kernel,
Catalin Marinas
On (20/09/18 17:07), Marc Zyngier wrote:
> On 2020-09-18 16:41, Will Deacon wrote:
> > On Sat, Sep 19, 2020 at 12:35:48AM +0900, Sergey Senozhatsky wrote:
> > > ipi_teardown() is used only when CONFIG_HOTPLUG_CPU is set.
> > >
> > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > > ---
> > > arch/arm64/kernel/smp.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > I think this is a duplicate of:
> >
> > https://lore.kernel.org/r/20200918123318.23764-1-yuehaibing@huawei.com
> >
> > which Marc is aware of (and I'm assuming he'll fix it in his series).
>
> Indeed. Applied and pushed out. Thanks though!
Oh, cool. Thanks.
-ss
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm64: ipi_teardown() should depend on HOTPLUG_CPU
@ 2020-09-18 23:13 ` Sergey Senozhatsky
0 siblings, 0 replies; 8+ messages in thread
From: Sergey Senozhatsky @ 2020-09-18 23:13 UTC (permalink / raw)
To: Marc Zyngier
Cc: Will Deacon, Sergey Senozhatsky, Catalin Marinas,
linux-arm-kernel, linux-kernel
On (20/09/18 17:07), Marc Zyngier wrote:
> On 2020-09-18 16:41, Will Deacon wrote:
> > On Sat, Sep 19, 2020 at 12:35:48AM +0900, Sergey Senozhatsky wrote:
> > > ipi_teardown() is used only when CONFIG_HOTPLUG_CPU is set.
> > >
> > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > > ---
> > > arch/arm64/kernel/smp.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > I think this is a duplicate of:
> >
> > https://lore.kernel.org/r/20200918123318.23764-1-yuehaibing@huawei.com
> >
> > which Marc is aware of (and I'm assuming he'll fix it in his series).
>
> Indeed. Applied and pushed out. Thanks though!
Oh, cool. Thanks.
-ss
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-09-18 23:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-18 15:35 [PATCH] arm64: ipi_teardown() should depend on HOTPLUG_CPU Sergey Senozhatsky
2020-09-18 15:35 ` Sergey Senozhatsky
2020-09-18 15:41 ` Will Deacon
2020-09-18 15:41 ` Will Deacon
2020-09-18 16:07 ` Marc Zyngier
2020-09-18 16:07 ` Marc Zyngier
2020-09-18 23:13 ` Sergey Senozhatsky
2020-09-18 23:13 ` Sergey Senozhatsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.