From: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Cc: frankja@linux.ibm.com, imbrenda@linux.ibm.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 1/1] s390x: add migration test for storage keys
Date: Tue, 17 May 2022 13:44:51 +0200 [thread overview]
Message-ID: <bceaae6a24324cdb72056977fd6bf7916adcc9d7.camel@linux.ibm.com> (raw)
In-Reply-To: <3ab95d5d553362a686b9526c8b53996dcaf20400.camel@linux.ibm.com>
On Tue, 2022-05-17 at 10:17 +0200, Nico Boehr wrote:
> On Mon, 2022-05-16 at 18:47 +0200, Janis Schoetterl-Glausch wrote:
> > On 5/16/22 11:07, Nico Boehr wrote:
[...]
> > > + expected_key.val = i * 2;
> > > +
> > > + /* ignore reference bit */
> >
> > Why? Are there any implicit references I'm missing?
>
> Since the PoP specifies (p. 5-122):
>
> "The record of references provided by the reference
> bit is not necessarily accurate. However, in the major-
> ity of situations, reference recording approximately
> coincides with the related storage reference."
>
> I don't really see a way to test this properly.
>
> Maybe I missed something?
No I think you're right, although in practice the reference bits should
match. Or did you observe a mismatch?
next prev parent reply other threads:[~2022-05-17 11:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 9:07 [kvm-unit-tests PATCH v2 0/1] s390x: add migration test for storage keys Nico Boehr
2022-05-16 9:07 ` [kvm-unit-tests PATCH v2 1/1] " Nico Boehr
2022-05-16 15:59 ` Claudio Imbrenda
2022-05-16 16:47 ` Janis Schoetterl-Glausch
2022-05-17 8:17 ` Nico Boehr
2022-05-17 11:44 ` Janis Schoetterl-Glausch [this message]
2022-05-17 11:53 ` Nico Boehr
2022-05-17 12:29 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bceaae6a24324cdb72056977fd6bf7916adcc9d7.camel@linux.ibm.com \
--to=scgl@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.