From: "Jarkko Nikula" <jhnikula@gmail.com>
To: Daniel Mack <daniel@caiaq.org>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] asoc tlv320aic3x: set power bits correctly
Date: Wed, 30 Apr 2008 14:50:43 +0300 [thread overview]
Message-ID: <bd7b27490804300450sc6c69d1v2edf2a8dca44bda@mail.gmail.com> (raw)
In-Reply-To: <20080430095747.GA28593@sirena.org.uk>
On Wed, Apr 30, 2008 at 12:57 PM, Mark Brown <
broonie@opensource.wolfsonmicro.com> wrote:
>
> If what you're trying to do is avoid powering on amplifiers when they
> are muted then this is best avoided since it often creates problems with
> pops and clicks due to things getting powered on and off out of the
> sequence generated by DAPM. If the amplifier is powered on before its
> inputs then it will amplify any noise generaetd by the inputs when they
> change power state. This is why ASoC mute controls for amplifiers are
> normally independent of their power controls.
>
I was looking do we have possible driver bug here and answer is no. Driver
keeps output state powered during playback if associated endpoint is enabled
with snd_soc_dapm_set_endpoint and unpowered otherwise.
So as with Mark's comment, the patch is unnecessary.
Jarkko
next prev parent reply other threads:[~2008-04-30 11:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 9:37 [PATCH] asoc tlv320aic3x: set power bits correctly Daniel Mack
2008-04-30 9:57 ` Mark Brown
2008-04-30 11:50 ` Jarkko Nikula [this message]
2008-04-30 13:11 ` Daniel Mack
2008-04-30 13:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd7b27490804300450sc6c69d1v2edf2a8dca44bda@mail.gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=daniel@caiaq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.