* [PATCH igt] igt/gem_exec_await: Flush the WCB before attempting to queue more work
@ 2017-12-21 15:48 Chris Wilson
2017-12-21 16:05 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2017-12-21 15:48 UTC (permalink / raw)
To: intel-gfx
Ensure that the terminating write into WC-memory is flushed before we
might trigger a wait for ring space.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/gem_exec_await.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/gem_exec_await.c b/tests/gem_exec_await.c
index 9c4467922..28b280ff6 100644
--- a/tests/gem_exec_await.c
+++ b/tests/gem_exec_await.c
@@ -222,6 +222,7 @@ static void wide(int fd, int ring_size, int timeout, unsigned int flags)
for (unsigned e = 0; e < nengine; e++)
exec[e].cmd[0] = MI_BATCH_BUFFER_END;
+ __sync_synchronize();
}
igt_assert_eq(intel_detect_and_clear_missed_interrupts(fd), 0);
--
2.15.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✓ Fi.CI.BAT: success for igt/gem_exec_await: Flush the WCB before attempting to queue more work
2017-12-21 15:48 [PATCH igt] igt/gem_exec_await: Flush the WCB before attempting to queue more work Chris Wilson
@ 2017-12-21 16:05 ` Patchwork
2017-12-21 16:56 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-12-22 17:03 ` [PATCH igt] " Tvrtko Ursulin
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-12-21 16:05 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: igt/gem_exec_await: Flush the WCB before attempting to queue more work
URL : https://patchwork.freedesktop.org/series/35684/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
beb26d89ff5c5621c1e6b6ac2a45439507af86b7 meson: Install .testlist files and README from tests/intel-ci
with latest DRM-Tip kernel build CI_DRM_3564
4b29b69aee8c drm-tip: 2017y-12m-21d-11h-10m-15s UTC integration manifest
No testlist changes.
Test debugfs_test:
Subgroup read_all_entries:
dmesg-warn -> PASS (fi-elk-e7500) fdo#103989 +1
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> PASS (fi-kbl-r) fdo#104172 +1
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:432s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:384s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:498s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:277s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:496s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:499s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:484s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:468s
fi-elk-e7500 total:224 pass:163 dwarn:15 dfail:0 fail:0 skip:45
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:263s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:533s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:412s
fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:413s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:425s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:480s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:424s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:480s
fi-kbl-7560u total:288 pass:268 dwarn:1 dfail:0 fail:0 skip:19 time:522s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:469s
fi-kbl-r total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:526s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:586s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:448s
fi-skl-6600u total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:526s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:556s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:509s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:513s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:453s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:548s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:414s
Blacklisted hosts:
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:598s
fi-cnl-y total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:24
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_722/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* ✗ Fi.CI.IGT: warning for igt/gem_exec_await: Flush the WCB before attempting to queue more work
2017-12-21 15:48 [PATCH igt] igt/gem_exec_await: Flush the WCB before attempting to queue more work Chris Wilson
2017-12-21 16:05 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-12-21 16:56 ` Patchwork
2017-12-22 17:03 ` [PATCH igt] " Tvrtko Ursulin
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-12-21 16:56 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: igt/gem_exec_await: Flush the WCB before attempting to queue more work
URL : https://patchwork.freedesktop.org/series/35684/
State : warning
== Summary ==
Test kms_atomic:
Subgroup plane_invalid_params:
pass -> SKIP (shard-snb)
Test prime_mmap_kms:
Subgroup buffer-sharing:
pass -> SKIP (shard-snb)
Test kms_pwrite_crc:
pass -> SKIP (shard-snb)
Test kms_cursor_legacy:
Subgroup cursora-vs-flipa-legacy:
pass -> SKIP (shard-snb)
Test drv_suspend:
Subgroup fence-restore-tiled2untiled:
skip -> PASS (shard-snb)
Subgroup sysfs-reader:
skip -> PASS (shard-hsw)
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
fail -> PASS (shard-snb) fdo#101623 +1
Test pm_rpm:
Subgroup system-suspend:
skip -> PASS (shard-hsw) fdo#103375 +1
Test kms_plane:
Subgroup plane-panning-bottom-right-pipe-b-planes:
pass -> SKIP (shard-hsw)
Test kms_atomic_transition:
Subgroup plane-all-transition-fencing:
pass -> SKIP (shard-hsw)
Test gem_tiled_swapping:
Subgroup non-threaded:
pass -> INCOMPLETE (shard-hsw) fdo#104218
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218
shard-hsw total:2685 pass:1518 dwarn:1 dfail:0 fail:10 skip:1155 time:9048s
shard-snb total:2685 pass:1290 dwarn:1 dfail:0 fail:10 skip:1383 time:7749s
Blacklisted hosts:
shard-apl total:2690 pass:1663 dwarn:1 dfail:0 fail:23 skip:1002 time:13340s
shard-kbl total:2712 pass:1792 dwarn:13 dfail:0 fail:24 skip:883 time:11115s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_722/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH igt] igt/gem_exec_await: Flush the WCB before attempting to queue more work
2017-12-21 15:48 [PATCH igt] igt/gem_exec_await: Flush the WCB before attempting to queue more work Chris Wilson
2017-12-21 16:05 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-21 16:56 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2017-12-22 17:03 ` Tvrtko Ursulin
2 siblings, 0 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2017-12-22 17:03 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 21/12/2017 15:48, Chris Wilson wrote:
> Ensure that the terminating write into WC-memory is flushed before we
> might trigger a wait for ring space.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/gem_exec_await.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/gem_exec_await.c b/tests/gem_exec_await.c
> index 9c4467922..28b280ff6 100644
> --- a/tests/gem_exec_await.c
> +++ b/tests/gem_exec_await.c
> @@ -222,6 +222,7 @@ static void wide(int fd, int ring_size, int timeout, unsigned int flags)
>
> for (unsigned e = 0; e < nengine; e++)
> exec[e].cmd[0] = MI_BATCH_BUFFER_END;
> + __sync_synchronize();
> }
>
> igt_assert_eq(intel_detect_and_clear_missed_interrupts(fd), 0);
>
In case someone is reading from the same uneducated situation as I was,
__sync_synchronize emits an mfence instructions which indeed forces a
flush of the write combine buffer.
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-22 17:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-21 15:48 [PATCH igt] igt/gem_exec_await: Flush the WCB before attempting to queue more work Chris Wilson
2017-12-21 16:05 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-21 16:56 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-12-22 17:03 ` [PATCH igt] " Tvrtko Ursulin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.