From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Irvin Cote <irvincoteg@gmail.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: Fix memory leak in nvme_init_ctrl error path
Date: Fri, 5 May 2023 01:17:55 +0000 [thread overview]
Message-ID: <bdee05ae-d572-285a-9dcc-efa7dfdf7ef3@nvidia.com> (raw)
In-Reply-To: <17ad8acb-bf02-f194-75a4-b1508c8f6cbc@grimberg.me>
On 5/4/23 01:18, Sagi Grimberg wrote:
>
>> I try to apply this patch on linux-nvme nvme-6.4 it is not applying,
>> which tree I should use for this to test it ?
>>
>> nvme (nvme-6.4) # git apply init-ctrl-fix.patch
>> error: patch failed: drivers/nvme/host/core.c:5137
>> error: drivers/nvme/host/core.c: patch does not apply
>
> It is on top of your series for the other memleaks
With this applied on the top of [1] on linux-nvme:nvme-6.4,
blktests nvme/044 and nvme/045 are passing without producing
kmemleak [2].
without this patch I'm still getting :-
backtrace:
[<0000000003b3ab89>] kmalloc_trace+0x25/0x90
[<00000000ee6a62bc>] device_add+0x4cf/0x850
[<000000006959d6db>] cdev_device_add+0x44/0x90
[<00000000a9254393>] nvme_init_ctrl+0x352/0x410 [nvme_core]
[<00000000a8a801a7>] 0xffffffffc05158b3
[<00000000a566bd92>] 0xffffffffc03734cb
[<000000001b88fc1d>] vfs_write+0xc5/0x3c0
[<0000000021d472df>] ksys_write+0x5f/0xe0
[<0000000001cad18e>] do_syscall_64+0x3b/0x90
[<000000001fc6210f>] entry_SYSCALL_64_after_hwframe+0x72/0xdc
Feel free to add :-
Tested-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
[1] http://lists.infradead.org/pipermail/linux-nvme/2023-April/039496.html
next prev parent reply other threads:[~2023-05-05 1:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 15:09 [PATCH] nvme: Fix memory leak in nvme_init_ctrl error path Sagi Grimberg
2023-05-04 5:23 ` Chaitanya Kulkarni
2023-05-04 8:18 ` Sagi Grimberg
2023-05-05 1:17 ` Chaitanya Kulkarni [this message]
2023-05-06 3:12 ` Yi Zhang
2023-05-12 15:07 ` Christoph Hellwig
2023-05-17 7:08 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdee05ae-d572-285a-9dcc-efa7dfdf7ef3@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=irvincoteg@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.