From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] block: enable passthrough command statistics
Date: Thu, 3 Oct 2024 07:20:18 -0600 [thread overview]
Message-ID: <bdf5f4c8-e943-44bc-b9cb-9dd8e726d5cd@kernel.dk> (raw)
In-Reply-To: <20241003130053.GE17031@lst.de>
On 10/3/24 7:00 AM, Christoph Hellwig wrote:
> On Wed, Oct 02, 2024 at 02:07:44PM -0700, Keith Busch wrote:
>> + accounting of the disk. Set to 0 to disable all stats. Set to 1
>> + to enable block IO stats. Set to 2 to enable passthrough stats
>> + in addition to block IO.
>
> Jens' reply suggest he likes this interface, but I have to say I
> already hated it with a passion for the merges - overloading a
> previously boolean file with a numberic value is not exactly an
> intuitive interface. Is a new sysfs file for this really a problem?
We can do a new file as well, like iostats_passthrough. Don't really
feel strongly about that part.
--
Jens Axboe
prev parent reply other threads:[~2024-10-03 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 21:07 [PATCH] block: enable passthrough command statistics Keith Busch
2024-10-03 1:30 ` Jens Axboe
2024-10-03 13:00 ` Christoph Hellwig
2024-10-03 13:20 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdf5f4c8-e943-44bc-b9cb-9dd8e726d5cd@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.