From: Johan Jonker <jbx6244@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Felipe Balbi <balbi@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: usb: rockchip,dwc3: Move RK3399 to its own schema
Date: Sat, 21 Jan 2023 00:40:12 +0100 [thread overview]
Message-ID: <be193659-e97f-23b9-b89c-d02205705db6@gmail.com> (raw)
In-Reply-To: <CAL_JsqKqiRbBJErkh2Hch+XZyLggGyjYo1rvKWPhxb99pA8mAA@mail.gmail.com>
On 1/20/23 21:30, Rob Herring wrote:
> On Wed, Jan 18, 2023 at 3:05 PM Johan Jonker <jbx6244@gmail.com> wrote:
>>
>> Hi,
>>
>> Some alignment at the examples and the unknown extcon property.
>>
>> usb@fe800000: 'extcon' does not match any of the regexes
>
> Does that go in the wrapper or dwc3 node?:
>
> arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dtb: usb@fe800000:
> usb@fe800000: Unevaluated properties are not allowed ('extcon' was
> unexpected)
> From schema:
> /home/rob/proj/linux-dt/Documentation/devicetree/bindings/usb/rockchip,rk3399-dwc3.yaml
>
> That's the dwc3 node, but the majority are in the wrapper node, so I'm
> going with the majority and leaving this one.
In wrapper code for rk33899 in dwc3-of-simple.c I don't see no extcon activity I think.
In core there's recently made some changes:
https://github.com/torvalds/linux/blame/master/drivers/usb/dwc3/core.c#L1710
usb: dwc3: Don't switch OTG -> peripheral if extcon is present
https://lore.kernel.org/all/20221017233510.53336-1-andriy.shevchenko@linux.intel.com/
Binding status update for that is unknown for me.
Do whatever suites you best.
Johan
> Rob
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Felipe Balbi <balbi@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: usb: rockchip,dwc3: Move RK3399 to its own schema
Date: Sat, 21 Jan 2023 00:40:12 +0100 [thread overview]
Message-ID: <be193659-e97f-23b9-b89c-d02205705db6@gmail.com> (raw)
In-Reply-To: <CAL_JsqKqiRbBJErkh2Hch+XZyLggGyjYo1rvKWPhxb99pA8mAA@mail.gmail.com>
On 1/20/23 21:30, Rob Herring wrote:
> On Wed, Jan 18, 2023 at 3:05 PM Johan Jonker <jbx6244@gmail.com> wrote:
>>
>> Hi,
>>
>> Some alignment at the examples and the unknown extcon property.
>>
>> usb@fe800000: 'extcon' does not match any of the regexes
>
> Does that go in the wrapper or dwc3 node?:
>
> arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dtb: usb@fe800000:
> usb@fe800000: Unevaluated properties are not allowed ('extcon' was
> unexpected)
> From schema:
> /home/rob/proj/linux-dt/Documentation/devicetree/bindings/usb/rockchip,rk3399-dwc3.yaml
>
> That's the dwc3 node, but the majority are in the wrapper node, so I'm
> going with the majority and leaving this one.
In wrapper code for rk33899 in dwc3-of-simple.c I don't see no extcon activity I think.
In core there's recently made some changes:
https://github.com/torvalds/linux/blame/master/drivers/usb/dwc3/core.c#L1710
usb: dwc3: Don't switch OTG -> peripheral if extcon is present
https://lore.kernel.org/all/20221017233510.53336-1-andriy.shevchenko@linux.intel.com/
Binding status update for that is unknown for me.
Do whatever suites you best.
Johan
> Rob
WARNING: multiple messages have this Message-ID (diff)
From: Johan Jonker <jbx6244@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Felipe Balbi <balbi@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: usb: rockchip,dwc3: Move RK3399 to its own schema
Date: Sat, 21 Jan 2023 00:40:12 +0100 [thread overview]
Message-ID: <be193659-e97f-23b9-b89c-d02205705db6@gmail.com> (raw)
In-Reply-To: <CAL_JsqKqiRbBJErkh2Hch+XZyLggGyjYo1rvKWPhxb99pA8mAA@mail.gmail.com>
On 1/20/23 21:30, Rob Herring wrote:
> On Wed, Jan 18, 2023 at 3:05 PM Johan Jonker <jbx6244@gmail.com> wrote:
>>
>> Hi,
>>
>> Some alignment at the examples and the unknown extcon property.
>>
>> usb@fe800000: 'extcon' does not match any of the regexes
>
> Does that go in the wrapper or dwc3 node?:
>
> arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dtb: usb@fe800000:
> usb@fe800000: Unevaluated properties are not allowed ('extcon' was
> unexpected)
> From schema:
> /home/rob/proj/linux-dt/Documentation/devicetree/bindings/usb/rockchip,rk3399-dwc3.yaml
>
> That's the dwc3 node, but the majority are in the wrapper node, so I'm
> going with the majority and leaving this one.
In wrapper code for rk33899 in dwc3-of-simple.c I don't see no extcon activity I think.
In core there's recently made some changes:
https://github.com/torvalds/linux/blame/master/drivers/usb/dwc3/core.c#L1710
usb: dwc3: Don't switch OTG -> peripheral if extcon is present
https://lore.kernel.org/all/20221017233510.53336-1-andriy.shevchenko@linux.intel.com/
Binding status update for that is unknown for me.
Do whatever suites you best.
Johan
> Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-20 23:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 19:30 [PATCH v2 1/2] dt-bindings: usb: snps,dwc3: Allow power-domains property Rob Herring
2023-01-18 19:30 ` Rob Herring
2023-01-18 19:30 ` Rob Herring
2023-01-18 19:30 ` [PATCH v2 2/2] dt-bindings: usb: rockchip,dwc3: Move RK3399 to its own schema Rob Herring
2023-01-18 19:30 ` Rob Herring
2023-01-18 19:30 ` Rob Herring
2023-01-18 21:05 ` Johan Jonker
2023-01-18 21:05 ` Johan Jonker
2023-01-18 21:05 ` Johan Jonker
2023-01-20 20:30 ` Rob Herring
2023-01-20 20:30 ` Rob Herring
2023-01-20 20:30 ` Rob Herring
2023-01-20 23:40 ` Johan Jonker [this message]
2023-01-20 23:40 ` Johan Jonker
2023-01-20 23:40 ` Johan Jonker
2023-01-23 21:07 ` Rob Herring
2023-01-23 21:07 ` Rob Herring
2023-01-23 21:07 ` Rob Herring
2023-01-19 0:46 ` [PATCH v2 1/2] dt-bindings: usb: snps,dwc3: Allow power-domains property Thinh Nguyen
2023-01-19 0:46 ` Thinh Nguyen
2023-01-19 0:46 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be193659-e97f-23b9-b89c-d02205705db6@gmail.com \
--to=jbx6244@gmail.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.