From: abhinavk@codeaurora.org
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
freedreno <freedreno@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>
Subject: Re: [PATCH 1/1] drm/msm/dpu: remove unused local variable 'cmd_enc'
Date: Wed, 07 Apr 2021 11:00:43 -0700 [thread overview]
Message-ID: <befdad0f2d57775e042c224faed619dc@codeaurora.org> (raw)
In-Reply-To: <20210407083334.2762-1-thunder.leizhen@huawei.com>
On 2021-04-07 01:33, Zhen Lei wrote:
> Fixes the following W=1 kernel build warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function
> ‘dpu_encoder_phys_cmd_wait_for_commit_done’:
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning:
> variable ‘cmd_enc’ set but not used [-Wunused-but-set-variable]
>
> Fixes: fe286893ed34 ("drm/msm/dpu: Remove unused call in
> wait_for_commit_done")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> index b2be39b9144e449..088900841bf8baa 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> @@ -685,10 +685,6 @@ static int
> dpu_encoder_phys_cmd_wait_for_tx_complete(
> static int dpu_encoder_phys_cmd_wait_for_commit_done(
> struct dpu_encoder_phys *phys_enc)
> {
> - struct dpu_encoder_phys_cmd *cmd_enc;
> -
> - cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);
> -
> /* only required for master controller */
> if (!dpu_encoder_phys_cmd_is_master(phys_enc))
> return 0;
WARNING: multiple messages have this Message-ID (diff)
From: abhinavk@codeaurora.org
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: freedreno <freedreno@lists.freedesktop.org>,
David Airlie <airlied@linux.ie>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Sean Paul <sean@poorly.run>
Subject: Re: [PATCH 1/1] drm/msm/dpu: remove unused local variable 'cmd_enc'
Date: Wed, 07 Apr 2021 11:00:43 -0700 [thread overview]
Message-ID: <befdad0f2d57775e042c224faed619dc@codeaurora.org> (raw)
In-Reply-To: <20210407083334.2762-1-thunder.leizhen@huawei.com>
On 2021-04-07 01:33, Zhen Lei wrote:
> Fixes the following W=1 kernel build warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function
> ‘dpu_encoder_phys_cmd_wait_for_commit_done’:
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning:
> variable ‘cmd_enc’ set but not used [-Wunused-but-set-variable]
>
> Fixes: fe286893ed34 ("drm/msm/dpu: Remove unused call in
> wait_for_commit_done")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> index b2be39b9144e449..088900841bf8baa 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
> @@ -685,10 +685,6 @@ static int
> dpu_encoder_phys_cmd_wait_for_tx_complete(
> static int dpu_encoder_phys_cmd_wait_for_commit_done(
> struct dpu_encoder_phys *phys_enc)
> {
> - struct dpu_encoder_phys_cmd *cmd_enc;
> -
> - cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);
> -
> /* only required for master controller */
> if (!dpu_encoder_phys_cmd_is_master(phys_enc))
> return 0;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-07 18:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 8:33 [PATCH 1/1] drm/msm/dpu: remove unused local variable 'cmd_enc' Zhen Lei
2021-04-07 8:33 ` Zhen Lei
2021-04-07 17:52 ` [Freedreno] " abhinavk
2021-04-07 17:52 ` abhinavk
2021-04-07 18:00 ` abhinavk [this message]
2021-04-07 18:00 ` abhinavk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=befdad0f2d57775e042c224faed619dc@codeaurora.org \
--to=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@somainline.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.