From: Changhuang Liang <changhuang.liang@starfivetech.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Jack Zhu <jack.zhu@starfivetech.com>,
<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx
Date: Wed, 19 Apr 2023 14:10:41 +0800 [thread overview]
Message-ID: <bf04808b-5988-c3d2-e2c4-4e8cdbaec838@starfivetech.com> (raw)
In-Reply-To: <CAL_JsqKVa+XHkoDbDLaD+haC2J7QDJ_oLr9RAT=7Pvwa-rWHLg@mail.gmail.com>
On 2023/4/19 2:46, Rob Herring wrote:
> On Tue, Apr 18, 2023 at 1:42 PM Rob Herring <robh@kernel.org> wrote:
>>
>> On Thu, Apr 13, 2023 at 10:41:23AM +0200, Krzysztof Kozlowski wrote:
>>> On 13/04/2023 04:34, Changhuang Liang wrote:
>>>>>>>> + lane_maps:
>>>>>>>
>>>>>>> Why did this appear? Underscores are not allowed. It looks like you
>>>>>>> re-implement some standard property.
>>>>>>>
>>>>>>
>>>>>> Will change to lane-maps.
>>>>>> Yes, according to Vinod advice, lane mapping table use device tree
>>>>>> to parse makes sense.
>>>>>
>>>>> Hm, I have a feeling that I saw such property, so you should dig into
>>>>> existing and in-flight bindings.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>>
>>>> A standard property? Like "clocks" or "resets"?
>>>
>>> Like lane-polarities now submitted to one MIPI.
>>>
>>
>> data-lanes perhaps?
>
> Except that is for the controller's endpoint rather than the phy.
> Presumably if the controller knows the mapping, then it can tell the
> phy if it needs the information. IOW, don't just copy 'data-lanes' to
> the phy. Follow the normal patterns.
>
> Rob
I am not sure if phy can fetch from the other controller's endpoint. In
addition, like our JH7110 SoC, it have data-lanes configure (data-lanes = <1 2>)
in csi2rx controller, but this data-lanes configure is not appropriate to phy,
maybe they are independent.
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Changhuang Liang <changhuang.liang@starfivetech.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Jack Zhu <jack.zhu@starfivetech.com>,
<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx
Date: Wed, 19 Apr 2023 14:10:41 +0800 [thread overview]
Message-ID: <bf04808b-5988-c3d2-e2c4-4e8cdbaec838@starfivetech.com> (raw)
In-Reply-To: <CAL_JsqKVa+XHkoDbDLaD+haC2J7QDJ_oLr9RAT=7Pvwa-rWHLg@mail.gmail.com>
On 2023/4/19 2:46, Rob Herring wrote:
> On Tue, Apr 18, 2023 at 1:42 PM Rob Herring <robh@kernel.org> wrote:
>>
>> On Thu, Apr 13, 2023 at 10:41:23AM +0200, Krzysztof Kozlowski wrote:
>>> On 13/04/2023 04:34, Changhuang Liang wrote:
>>>>>>>> + lane_maps:
>>>>>>>
>>>>>>> Why did this appear? Underscores are not allowed. It looks like you
>>>>>>> re-implement some standard property.
>>>>>>>
>>>>>>
>>>>>> Will change to lane-maps.
>>>>>> Yes, according to Vinod advice, lane mapping table use device tree
>>>>>> to parse makes sense.
>>>>>
>>>>> Hm, I have a feeling that I saw such property, so you should dig into
>>>>> existing and in-flight bindings.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>>
>>>> A standard property? Like "clocks" or "resets"?
>>>
>>> Like lane-polarities now submitted to one MIPI.
>>>
>>
>> data-lanes perhaps?
>
> Except that is for the controller's endpoint rather than the phy.
> Presumably if the controller knows the mapping, then it can tell the
> phy if it needs the information. IOW, don't just copy 'data-lanes' to
> the phy. Follow the normal patterns.
>
> Rob
I am not sure if phy can fetch from the other controller's endpoint. In
addition, like our JH7110 SoC, it have data-lanes configure (data-lanes = <1 2>)
in csi2rx controller, but this data-lanes configure is not appropriate to phy,
maybe they are independent.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Changhuang Liang <changhuang.liang@starfivetech.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Philipp Zabel <p.zabel@pengutronix.de>,
Jack Zhu <jack.zhu@starfivetech.com>,
<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v4 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx
Date: Wed, 19 Apr 2023 14:10:41 +0800 [thread overview]
Message-ID: <bf04808b-5988-c3d2-e2c4-4e8cdbaec838@starfivetech.com> (raw)
In-Reply-To: <CAL_JsqKVa+XHkoDbDLaD+haC2J7QDJ_oLr9RAT=7Pvwa-rWHLg@mail.gmail.com>
On 2023/4/19 2:46, Rob Herring wrote:
> On Tue, Apr 18, 2023 at 1:42 PM Rob Herring <robh@kernel.org> wrote:
>>
>> On Thu, Apr 13, 2023 at 10:41:23AM +0200, Krzysztof Kozlowski wrote:
>>> On 13/04/2023 04:34, Changhuang Liang wrote:
>>>>>>>> + lane_maps:
>>>>>>>
>>>>>>> Why did this appear? Underscores are not allowed. It looks like you
>>>>>>> re-implement some standard property.
>>>>>>>
>>>>>>
>>>>>> Will change to lane-maps.
>>>>>> Yes, according to Vinod advice, lane mapping table use device tree
>>>>>> to parse makes sense.
>>>>>
>>>>> Hm, I have a feeling that I saw such property, so you should dig into
>>>>> existing and in-flight bindings.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>>
>>>> A standard property? Like "clocks" or "resets"?
>>>
>>> Like lane-polarities now submitted to one MIPI.
>>>
>>
>> data-lanes perhaps?
>
> Except that is for the controller's endpoint rather than the phy.
> Presumably if the controller knows the mapping, then it can tell the
> phy if it needs the information. IOW, don't just copy 'data-lanes' to
> the phy. Follow the normal patterns.
>
> Rob
I am not sure if phy can fetch from the other controller's endpoint. In
addition, like our JH7110 SoC, it have data-lanes configure (data-lanes = <1 2>)
in csi2rx controller, but this data-lanes configure is not appropriate to phy,
maybe they are independent.
next prev parent reply other threads:[~2023-04-19 6:11 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 8:45 [PATCH v4 0/3] Add JH7110 MIPI DPHY RX support Changhuang Liang
2023-04-12 8:45 ` Changhuang Liang
2023-04-12 8:45 ` Changhuang Liang
2023-04-12 8:45 ` [PATCH v4 1/3] dt-bindings: phy: Add starfive,jh7110-dphy-rx Changhuang Liang
2023-04-12 8:45 ` Changhuang Liang
2023-04-12 8:45 ` Changhuang Liang
2023-04-12 11:34 ` Krzysztof Kozlowski
2023-04-12 11:34 ` Krzysztof Kozlowski
2023-04-12 11:34 ` Krzysztof Kozlowski
2023-04-12 12:42 ` Changhuang Liang
2023-04-12 12:42 ` Changhuang Liang
2023-04-12 12:42 ` Changhuang Liang
2023-04-12 16:55 ` Krzysztof Kozlowski
2023-04-12 16:55 ` Krzysztof Kozlowski
2023-04-12 16:55 ` Krzysztof Kozlowski
2023-04-13 1:29 ` Changhuang Liang
2023-04-13 1:29 ` Changhuang Liang
2023-04-13 1:29 ` Changhuang Liang
2023-04-13 2:34 ` Changhuang Liang
2023-04-13 2:34 ` Changhuang Liang
2023-04-13 2:34 ` Changhuang Liang
2023-04-13 8:41 ` Krzysztof Kozlowski
2023-04-13 8:41 ` Krzysztof Kozlowski
2023-04-13 8:41 ` Krzysztof Kozlowski
2023-04-13 9:02 ` Changhuang Liang
2023-04-13 9:02 ` Changhuang Liang
2023-04-13 9:02 ` Changhuang Liang
2023-04-16 17:29 ` Krzysztof Kozlowski
2023-04-16 17:29 ` Krzysztof Kozlowski
2023-04-16 17:29 ` Krzysztof Kozlowski
2023-04-17 3:37 ` Changhuang Liang
2023-04-17 3:37 ` Changhuang Liang
2023-04-17 3:37 ` Changhuang Liang
2023-05-04 1:21 ` Changhuang Liang
2023-05-04 1:21 ` Changhuang Liang
2023-05-04 1:21 ` Changhuang Liang
2023-04-18 18:42 ` Rob Herring
2023-04-18 18:42 ` Rob Herring
2023-04-18 18:42 ` Rob Herring
2023-04-18 18:46 ` Rob Herring
2023-04-18 18:46 ` Rob Herring
2023-04-18 18:46 ` Rob Herring
2023-04-19 6:10 ` Changhuang Liang [this message]
2023-04-19 6:10 ` Changhuang Liang
2023-04-19 6:10 ` Changhuang Liang
2023-04-12 8:45 ` [PATCH v4 2/3] phy: starfive: Add mipi dphy rx support Changhuang Liang
2023-04-12 8:45 ` Changhuang Liang
2023-04-12 8:45 ` Changhuang Liang
2023-04-12 8:45 ` [PATCH v4 3/3] riscv: dts: starfive: Add dphy rx node Changhuang Liang
2023-04-12 8:45 ` Changhuang Liang
2023-04-12 8:45 ` Changhuang Liang
2023-05-22 13:00 ` [PATCH v4 0/3] Add JH7110 MIPI DPHY RX support Changhuang Liang
2023-05-22 13:00 ` Changhuang Liang
2023-05-22 13:00 ` Changhuang Liang
2023-05-22 13:11 ` Conor Dooley
2023-05-22 13:11 ` Conor Dooley
2023-05-22 13:11 ` Conor Dooley
2023-05-23 1:02 ` Changhuang Liang
2023-05-23 1:02 ` Changhuang Liang
2023-05-23 1:02 ` Changhuang Liang
2023-05-23 5:13 ` Conor Dooley
2023-05-23 5:13 ` Conor Dooley
2023-05-23 5:13 ` Conor Dooley
2023-05-23 5:54 ` Changhuang Liang
2023-05-23 5:54 ` Changhuang Liang
2023-05-23 5:54 ` Changhuang Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf04808b-5988-c3d2-e2c4-4e8cdbaec838@starfivetech.com \
--to=changhuang.liang@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jack.zhu@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.