All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Ico Doornekamp <ico@pruts.nl>
Cc: linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: accel: sca3000_core: Fix superfluous indent white space
Date: Tue, 13 Sep 2016 18:37:17 +0100	[thread overview]
Message-ID: <bf8b4602-e470-60e4-c378-e2bbe22a4c88@kernel.org> (raw)
In-Reply-To: <1473530764-sup-9251@pruts.nl>

On 10/09/16 19:16, Ico Doornekamp wrote:
> * On 2016-09-10 18:26:45 +0200, Jonathan Cameron wrote:
>  
>> Another good one is to find things in staging drivers that we now
>> have IIO_INFO_* elements for.
>>
>> For example in sca3000 I see there is an explicit attribute defined that
>> could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the
>> relevant masks and appropriate sections added to the read_raw
>> and write_raw callbacks.
>>
>> Not a trivial job, but not too hard to figure out perhaps?
> 
> Not too hard, although I'm not able to actually run and test due to lack
> of hardware.
That's fine. This one is my driver (rather needing some care and attention)
and I have the hardware still.  It's somewhat of a pain to fire up so
I might do this one just on review but we'll see how busy I am at the weekend.
> 
>> + a good step up from white space patches.
> 
> I do hope the Little Penguin agrees on this :)
Should do!
> 
>> Guess maybe that needs to be a bit later if you are ploughing through
>> the eudyptula-challenge (though that didn't exist when I got started
>> so I don't know what order they do stuff in!)
> 
> I have no clue: I'm trying to stick to the steps and not peek ahead.
> 

  reply	other threads:[~2016-09-13 17:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09 17:44 [PATCH] iio: accel: sca3000_core: Fix superfluous indent white space Ico Doornekamp
2016-09-10 14:57 ` Jonathan Cameron
2016-09-10 16:01   ` Ico Doornekamp
2016-09-10 16:26     ` Jonathan Cameron
2016-09-10 18:16       ` Ico Doornekamp
2016-09-13 17:37         ` Jonathan Cameron [this message]
2016-09-13 19:22           ` Alison Schofield
2016-09-18 10:53             ` Jonathan Cameron
2016-09-20 19:50               ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf8b4602-e470-60e4-c378-e2bbe22a4c88@kernel.org \
    --to=jic23@kernel.org \
    --cc=ico@pruts.nl \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.