All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Bence Csokas <bence.csokas@arm.com>,
	cocci@inria.fr, linux-hardening@vger.kernel.org,
	Julia Lawall <julia.lawall@inria.fr>
Cc: GR-QLogic-Storage-Upstream@marvell.com,
	James.Bottomley@HansenPartnership.com, Jes.Sorensen@gmail.com,
	airlied@gmail.com, andrealmeid@igalia.com, andrew+netdev@lunn.ch,
	andrii@kernel.org, arm-scmi@vger.kernel.org, ast@kernel.org,
	bcm-kernel-feedback-list@broadcom.com, bharathsm@microsoft.com,
	bleung@chromium.org, bpf@vger.kernel.org, brauner@kernel.org,
	cem@kernel.org, christian.koenig@amd.com,
	chrome-platform@lists.linux.dev, cristian.marussi@arm.com,
	dakr@kernel.org, daniel@iogearbox.net, dave@stgolabs.net,
	davem@davemloft.net, decui@microsoft.com,
	dri-devel@lists.freedesktop.org, dsahern@kernel.org,
	dvhart@infradead.org, eddyz87@gmail.com, edumazet@kernel.org,
	emil@etsalapatis.com, g@b4.vu, gnoack@google.com,
	groeck@chromium.org, gustavoars@kernel.org,
	haiyangz@microsoft.com, hansg@kernel.org,
	herbert@gondor.apana.org.au, horms@kernel.org,
	huangjunxian6@hisilicon.com, idosch@nvidia.com,
	ihor.solodrai@linux.dev, intel-gfx@lists.freedesktop.org,
	ipsec@lists.linux.dev, jack@suse.cz, jani.nikula@linux.intel.com,
	jgg@ziepe.ca, jmorris@namei.org, johannes@sipsolutions.net,
	jolsa@kernel.org, joonas.lahtinen@linux.intel.com,
	kalesh-anakkur.purayil@broadcom.com, kees@kernel.org,
	kuba@kernel.org, laurent.pinchart@ideasonboard.com,
	leon@kernel.org, linaro-mm-sig@lists.linaro.org,
	linkinjeon@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-bluetooth@vger.kernel.org, linux-cifs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-sound@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-xfs@vger.kernel.org, luiz.dentz@gmail.com,
	lyude@redhat.com, maarten.lankhorst@linux.intel.com,
	marcel@holtmann.org, martin.lau@linux.dev, mchehab@kernel.org,
	memxor@gmail.com, mic@digikod.net, mingo@redhat.com,
	miriam.rachel.korenblit@intel.com, mkp@kernel.org,
	mripard@kernel.org, netdev@vger.kernel.org,
	nicolas.palix@imag.fr, njavali@marvell.com,
	nouveau@lists.freedesktop.org, pabeni@redhat.com,
	paul@paul-moore.com, pc@manguebit.org, perex@perex.cz,
	peterz@infradead.org, phasta@kernel.org, pkshih@realtek.com,
	rodrigo.vivi@intel.com, ronniesahlberg@gmail.com,
	samba-technical@lists.samba.org, selvin.xavier@broadcom.com,
	serge@hallyn.com, simona@ffwll.ch, song@kernel.org,
	sprasad@microsoft.com, steffen.klassert@secunet.com,
	sudeep.holla@kernel.org, sumit.semwal@linaro.org,
	tangchengchang@huawei.com, tglx@kernel.org, tiwai@suse.com,
	tom@talpey.com, tursulin@ursulin.net, tzimmermann@suse.de,
	tzungbi@kernel.org, viro@zeniv.linux.org.uk, wei.liu@kernel.org,
	willemdebruijn.kernel@gmail.com, yonghong.song@linux.dev,
	zack.rusin@broadcom.com
Subject: Re: [PATCH v4 1/2] coccinelle: Add offsetofend() variant of struct_offset()
Date: Wed, 18 Nov 2026 17:11:53 +0100	[thread overview]
Message-ID: <bfe10f1f-443e-4286-8172-6f941663c86e@web.de> (raw)
In-Reply-To: <20261118-offsetof-v4-1-95b385c10b22@arm.com>

…
> +++ b/scripts/coccinelle/api/struct_offsetof.cocci
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/// Use struct_offset() family of macros
> +///
> +// Confidence: High
> +// Options: --no-includes --ignore ./tools/
> +
> +virtual patch

Can further coccicheck operation modes become more interesting here?


> +
> +@offsetof depends on patch@
> +expression ptr, member;
> +@@
> +- offsetof(typeof(*(ptr)), member)
> ++ struct_offset(ptr, member)
> +@offsetofend depends on patch@
> +expression ptr, member;
> +@@
> +- offsetofend(typeof(*(ptr)), member)
> ++ struct_offsetofend(ptr, member)

How do you think about to use the following SmPL rule variant instead?


@replacement depends on patch@
expression pointer, member;
@@
(
-offsetof
+struct_offset
|
-offsetofend
+struct_offsetofend
)(
-typeof(*
-(pointer)
+pointer
-)
 , member
 )


Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Bence Csokas <bence.csokas@arm.com>,
	cocci@inria.fr, linux-hardening@vger.kernel.org,
	Julia Lawall <julia.lawall@inria.fr>
Cc: GR-QLogic-Storage-Upstream@marvell.com,
	James.Bottomley@HansenPartnership.com, Jes.Sorensen@gmail.com,
	andrealmeid@igalia.com, andrew+netdev@lunn.ch, andrii@kernel.org,
	arm-scmi@vger.kernel.org, ast@kernel.org,
	bcm-kernel-feedback-list@broadcom.com, bharathsm@microsoft.com,
	bleung@chromium.org, bpf@vger.kernel.org, brauner@kernel.org,
	cem@kernel.org, christian.koenig@amd.com,
	chrome-platform@lists.linux.dev, cristian.marussi@arm.com,
	dakr@kernel.org, daniel@iogearbox.net, dave@stgolabs.net,
	davem@davemloft.net, decui@microsoft.com,
	dri-devel@lists.freedesktop.org, dsahern@kernel.org,
	dvhart@infradead.org, eddyz87@gmail.com, edumazet@kernel.org,
	emil@etsalapatis.com, g@b4.vu, gnoack@google.com,
	groeck@chromium.org, gustavoars@kernel.org,
	haiyangz@microsoft.com, hansg@kernel.org,
	herbert@gondor.apana.org.au, horms@kernel.org,
	huangjunxian6@hisilicon.com, idosch@nvidia.com,
	ihor.solodrai@linux.dev, intel-gfx@lists.freedesktop.org,
	ipsec@lists.linux.dev, jack@suse.cz, jani.nikula@linux.intel.com,
	jgg@ziepe.ca, jmorris@namei.org, johannes@sipsolutions.net,
	jolsa@kernel.org, joonas.lahtinen@linux.intel.com,
	kalesh-anakkur.purayil@broadcom.com, kees@kernel.org,
	kuba@kernel.org, laurent.pinchart@ideasonboard.com,
	leon@kernel.org, linaro-mm-sig@lists.linaro.org,
	linkinjeon@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-bluetooth@vger.kernel.org, linux-cifs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-sound@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-xfs@vger.kernel.org, luiz.dentz@gmail.com,
	maarten.lankhorst@linux.intel.com, marcel@holtmann.org,
	martin.lau@linux.dev, mchehab@kernel.org, memxor@gmail.com,
	mic@digikod.net, mingo@redhat.com,
	miriam.rachel.korenblit@intel.com, mkp@kernel.org,
	mripard@kernel.org, netdev@vger.kernel.org,
	nicolas.palix@imag.fr, njavali@marvell.com,
	nouveau@lists.freedesktop.org, pabeni@redhat.com,
	paul@paul-moore.com, pc@manguebit.org, perex@perex.cz,
	peterz@infradead.org, phasta@kernel.org, pkshih@realtek.com,
	rodrigo.vivi@intel.com, ronniesahlberg@gmail.com,
	samba-technical@lists.samba.org, selvin.xavier@broadcom.com,
	serge@hallyn.com, simona@ffwll.ch, song@kernel.org,
	sprasad@microsoft.com, steffen.klassert@secunet.com,
	sudeep.holla@kernel.org, sumit.semwal@linaro.org,
	tangchengchang@huawei.com, tglx@kernel.org, tiwai@suse.com,
	tom@talpey.com, tursulin@ursulin.net, tzungbi@kernel.org,
	viro@zeniv.linux.org.uk, wei.liu@kernel.org,
	willemdebruijn.kernel@gmail.com, yonghong.song@linux.dev,
	zack.rusin@broadcom.com
Subject: Re: [PATCH v4 1/2] coccinelle: Add offsetofend() variant of struct_offset()
Date: Wed, 18 Nov 2026 17:11:53 +0100	[thread overview]
Message-ID: <bfe10f1f-443e-4286-8172-6f941663c86e@web.de> (raw)
In-Reply-To: <20261118-offsetof-v4-1-95b385c10b22@arm.com>

…
> +++ b/scripts/coccinelle/api/struct_offsetof.cocci
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/// Use struct_offset() family of macros
> +///
> +// Confidence: High
> +// Options: --no-includes --ignore ./tools/
> +
> +virtual patch

Can further coccicheck operation modes become more interesting here?


> +
> +@offsetof depends on patch@
> +expression ptr, member;
> +@@
> +- offsetof(typeof(*(ptr)), member)
> ++ struct_offset(ptr, member)
> +@offsetofend depends on patch@
> +expression ptr, member;
> +@@
> +- offsetofend(typeof(*(ptr)), member)
> ++ struct_offsetofend(ptr, member)

How do you think about to use the following SmPL rule variant instead?


@replacement depends on patch@
expression pointer, member;
@@
(
-offsetof
+struct_offset
|
-offsetofend
+struct_offsetofend
)(
-typeof(*
-(pointer)
+pointer
-)
 , member
 )


Regards,
Markus

  parent reply	other threads:[~2026-11-18 16:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 11:50 [PATCH v4 0/2] Add struct_offsetofend() for pointer arithmetic Bence Csokas
2026-11-18 11:50 ` [cocci] " Bence Csokas
2026-11-18 11:50 ` [PATCH v4 1/2] overflow: Add offsetofend() variant of struct_offset() Bence Csokas
2026-11-18 11:50   ` [cocci] " Bence Csokas
2026-11-18 12:07   ` sashiko-bot
2026-11-18 12:21     ` Bence Csókás
2026-11-18 14:07   ` Julia Lawall
2026-11-18 14:07     ` Julia Lawall
2026-11-18 14:07     ` [cocci] " Julia Lawall
2026-11-18 16:11   ` Markus Elfring [this message]
2026-11-18 16:11     ` [PATCH v4 1/2] coccinelle: " Markus Elfring
2026-11-18 18:58   ` Add struct_offsetofend() for pointer arithmetic bluez.test.bot
2026-11-18 11:50 ` [PATCH v4 2/2] treewide: Use struct_offset() Bence Csokas
2026-11-18 11:50   ` [cocci] " Bence Csokas
2026-11-18 11:56   ` sashiko-bot
2026-11-18 14:05   ` Peter Zijlstra
2026-11-18 14:05     ` Peter Zijlstra
2026-11-18 14:05     ` [cocci] " Peter Zijlstra
2026-11-19 10:19     ` David Laight
2026-11-18 22:02 ` ✓ i915.CI.BAT: success for Add struct_offsetofend() for pointer arithmetic (rev3) Patchwork
2026-11-19  4:56 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfe10f1f-443e-4286-8172-6f941663c86e@web.de \
    --to=markus.elfring@web.de \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=Jes.Sorensen@gmail.com \
    --cc=airlied@gmail.com \
    --cc=andrealmeid@igalia.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrii@kernel.org \
    --cc=arm-scmi@vger.kernel.org \
    --cc=ast@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bence.csokas@arm.com \
    --cc=bharathsm@microsoft.com \
    --cc=bleung@chromium.org \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=cem@kernel.org \
    --cc=christian.koenig@amd.com \
    --cc=chrome-platform@lists.linux.dev \
    --cc=cocci@inria.fr \
    --cc=cristian.marussi@arm.com \
    --cc=dakr@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=dave@stgolabs.net \
    --cc=davem@davemloft.net \
    --cc=decui@microsoft.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dsahern@kernel.org \
    --cc=dvhart@infradead.org \
    --cc=eddyz87@gmail.com \
    --cc=edumazet@kernel.org \
    --cc=emil@etsalapatis.com \
    --cc=g@b4.vu \
    --cc=gnoack@google.com \
    --cc=groeck@chromium.org \
    --cc=gustavoars@kernel.org \
    --cc=haiyangz@microsoft.com \
    --cc=hansg@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=horms@kernel.org \
    --cc=huangjunxian6@hisilicon.com \
    --cc=idosch@nvidia.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ipsec@lists.linux.dev \
    --cc=jack@suse.cz \
    --cc=jani.nikula@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=jmorris@namei.org \
    --cc=johannes@sipsolutions.net \
    --cc=jolsa@kernel.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=julia.lawall@inria.fr \
    --cc=kalesh-anakkur.purayil@broadcom.com \
    --cc=kees@kernel.org \
    --cc=kuba@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=leon@kernel.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=lyude@redhat.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marcel@holtmann.org \
    --cc=martin.lau@linux.dev \
    --cc=mchehab@kernel.org \
    --cc=memxor@gmail.com \
    --cc=mic@digikod.net \
    --cc=mingo@redhat.com \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=mkp@kernel.org \
    --cc=mripard@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.palix@imag.fr \
    --cc=njavali@marvell.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=pabeni@redhat.com \
    --cc=paul@paul-moore.com \
    --cc=pc@manguebit.org \
    --cc=perex@perex.cz \
    --cc=peterz@infradead.org \
    --cc=phasta@kernel.org \
    --cc=pkshih@realtek.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=ronniesahlberg@gmail.com \
    --cc=samba-technical@lists.samba.org \
    --cc=selvin.xavier@broadcom.com \
    --cc=serge@hallyn.com \
    --cc=simona@ffwll.ch \
    --cc=song@kernel.org \
    --cc=sprasad@microsoft.com \
    --cc=steffen.klassert@secunet.com \
    --cc=sudeep.holla@kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tangchengchang@huawei.com \
    --cc=tglx@kernel.org \
    --cc=tiwai@suse.com \
    --cc=tom@talpey.com \
    --cc=tursulin@ursulin.net \
    --cc=tzimmermann@suse.de \
    --cc=tzungbi@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wei.liu@kernel.org \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=yonghong.song@linux.dev \
    --cc=zack.rusin@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.